all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Fabio Natali via Guix-patches via <guix-patches@gnu.org>
To: 71254@debbugs.gnu.org
Subject: [bug#71254] [PATCH] services: oci-container: fix provided image is string.
Date: Fri, 31 May 2024 15:14:27 +0100	[thread overview]
Message-ID: <87plt283wc.fsf@fabionatali.com> (raw)
In-Reply-To: <91c850e563f05fb1fa10aea1758786dce3f79157.1716956272.git.zhengjunjie@iscas.ac.cn>

Hi Zheng,

Thanks for your patch!

For what it's worth, this is to confirm that the patch works for
me. Without the patch, I don't seem to be able to use
'oci-container-service-type', at least when the image is provided as a
string.

I can't comment on the stylistic consistency of the patch (i.e. the use
of '(when #$ ...)' vs '#$@(if ...)'), but it's a +1 for me in terms of
its effectiveness.

Just my 2 cents for other fellow reviewers and the final committer.

Best, Fabio.




  reply	other threads:[~2024-05-31 14:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-29  4:17 [bug#71254] [PATCH] services: oci-container: fix provided image is string Zheng Junjie
2024-05-31 14:14 ` Fabio Natali via Guix-patches via [this message]
2024-06-05 11:12 ` Fabio Natali via Guix-patches via
2024-06-06  5:57   ` bug#71254: " Zheng Junjie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87plt283wc.fsf@fabionatali.com \
    --to=guix-patches@gnu.org \
    --cc=71254@debbugs.gnu.org \
    --cc=me@fabionatali.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.