From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id IHW0FYToeGY0XgAAqHPOHw:P1 (envelope-from ) for ; Mon, 24 Jun 2024 03:31:16 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id IHW0FYToeGY0XgAAqHPOHw (envelope-from ) for ; Mon, 24 Jun 2024 05:31:16 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Lr3ynPGT; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1719199875; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=tGg/r7dQBcXxzuYk/FNr7jqw+bNwP+YqIwb9NzF4Vtw=; b=pnsng99roHs/5yRyPpauRzmyIOe8SwtHvfEfqL8KVFQsTGBwEEszXa6iQI0vpx/5d8jXDK aePBcS0r5yi0NLwfweqSfNw9jsYXtGOGXQrZAbBZVOUp8YEZzUohMESLnJBxHZ3/4QGQMJ VkIWGKay9N3Y9oTDSmE0pqvI+aJ65HFulstwCsY4W68ROVBQYyUmseuvoWOF20dZH3bgIT 6m1GXlsH3lM16cwv0wn8dNDk9bT2HLib/h410zuyV3YiYZdUs+kdt6dhfrBGbg8eQodn1d k6jz/OhZ/EwFGzQAOecvazrHbdcZ9a4fYWe5iJsRNSyDhY/VgWp4i4JMwlUJEQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Lr3ynPGT; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1719199875; a=rsa-sha256; cv=none; b=MHGWChIpUkHrPRJcoj/KX4o9gSTC/kQkja/tLwAWTSZY60X4hvHCvoIKCKUiPpSf7xKt4v Wb/2FGqcn7gEpSRZJS7tL7FU+StRT+ob9z07rxQ/y1Na8lwUA3lYtkdIy17wxXGqpgCXlE XvTCeBeHnaYQ/N09hZa+uURVydGzs0AqxriBYhZgDP1Qh2dWYz0q21avTuUAfs71mTwArW tyqsio9TkjfPALsjioCeEOIMQLp7fDCT0fZFtp3YOz3pTJ4Ex75s+KuQhanVi9MCWq6es9 V/KLV1nnWtICQXdiBex7Q0qODj900Dz9r4PV4nzXMVc5oa8Q5Cq6oxnvoKKnyA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8CE066D6BA for ; Mon, 24 Jun 2024 05:31:15 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sLaQ5-0007SK-FJ; Sun, 23 Jun 2024 23:31:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLaQ3-0007NS-2i for guix-patches@gnu.org; Sun, 23 Jun 2024 23:31:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sLaQ1-0001Tk-Ik for guix-patches@gnu.org; Sun, 23 Jun 2024 23:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sLaQ2-0006UL-BE for guix-patches@gnu.org; Sun, 23 Jun 2024 23:31:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70880] [PATCH 7/8] gnu: Add prusa-wxwidgets. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 24 Jun 2024 03:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70880 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: moreinfo patch To: "Artyom V. Poptsov" Cc: 70880@debbugs.gnu.org, Nikita Domnitskii Received: via spool by 70880-submit@debbugs.gnu.org id=B70880.171919980415358 (code B ref 70880); Mon, 24 Jun 2024 03:31:02 +0000 Received: (at 70880) by debbugs.gnu.org; 24 Jun 2024 03:30:04 +0000 Received: from localhost ([127.0.0.1]:36142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLaP4-0003zQ-DF for submit@debbugs.gnu.org; Sun, 23 Jun 2024 23:30:03 -0400 Received: from mail-qv1-f53.google.com ([209.85.219.53]:60793) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLaP2-0003yv-Gf for 70880@debbugs.gnu.org; Sun, 23 Jun 2024 23:30:01 -0400 Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-6aedd5167d1so17140476d6.1 for <70880@debbugs.gnu.org>; Sun, 23 Jun 2024 20:29:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719199734; x=1719804534; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=tGg/r7dQBcXxzuYk/FNr7jqw+bNwP+YqIwb9NzF4Vtw=; b=Lr3ynPGT0XHShSygFF90DeGq0B7vKpkxc64PA+yg8BoNcnGCJPFJdhNjdwaKby1Krh O1RWWwNOG98ezFY5nElzIbDk6V24D1zwFnJdYDnRH2HpZYKshFEMxmVNFcVN6pPDMCRn 9izbRgHakahtQo8eSwEqwIZxs0bdVzbH0tnKWBjBUANgZaG2DlR2nxa7G9l3lmxjxsKf V/+u0vUGKU60bZ5hfPHZr4hZ2NRKbKqFFHWLtARbi5PucXj6RCXNIr73tt3Vxwl9BJgN 7sM9s7DmSHv2w2NN6axg48ty60cyx0qTPu/y3xqnwss3Brc13KxOGakMH8qWvarQwb5u fFYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719199734; x=1719804534; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tGg/r7dQBcXxzuYk/FNr7jqw+bNwP+YqIwb9NzF4Vtw=; b=TIK5p4y2nRrNRHiKFRLPxTjqiRG4CuCnkdDdqJT532hwFbzMMgBJdF/xKZ+nCXusbA tEzdzju1NjCJo6v/uuBrX3QUQvKik15BLuDQVFwSEs1Raegg4Outvz05nzGWv6t8ELN5 7jS7uixG4tfy5S01coxET3DxKrQUB1zH2oehgJ39B0koENeTl8YjDw04tA1z35fUk9mL yuQNjITeev6mJyaKalWWB9CqaIEpcv+lgkSriTfyzd1V8ZyLaNUPmHm0ZZ2qvzHllZ+8 Jh9nWFyhoatcZo8wsMlXE8TFnS2URjeXPBoNdr6OJ1BXeB4xIX62ZKvhMMf3DB19qiCf DcCA== X-Gm-Message-State: AOJu0YzHP8uLXj6rpKSLy9vnQw9eQt0ETNLdnv9Rtf/yvqk7hhikxO3r 0GeVFBZTgrJfkvVFk5jybdPuid6cI2E5mJRidZOzmYPCrP8ex6XWkPSiXHzHOWg= X-Google-Smtp-Source: AGHT+IHCi44ww8GYMyj3yrfoonsTL42q885cRLNdrWPU09on+ccFQRrhLlXxHI/Sw5nz5aaLZsumAA== X-Received: by 2002:a05:6214:20e2:b0:6b5:24b:f430 with SMTP id 6a1803df08f44-6b540a91d2emr42682536d6.40.1719199734217; Sun, 23 Jun 2024 20:28:54 -0700 (PDT) Received: from hurd (dsl-205-233-124-241.b2b2c.ca. [205.233.124.241]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b51ef30eebsm30554166d6.97.2024.06.23.20.28.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jun 2024 20:28:53 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: (Artyom V. Poptsov's message of "Sat, 11 May 2024 20:58:35 +0300") References: Date: Sun, 23 Jun 2024 23:28:52 -0400 Message-ID: <87pls72f4b.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: 1.73 X-Migadu-Queue-Id: 8CE066D6BA X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: 1.73 X-TUID: Q+VJUGPaoub9 Hi, "Artyom V. Poptsov" writes: > * gnu/packages/engineering.scm (prusa-wxwidgets): New variable. > > Co-authored-by: Nikita Domnitskii > Change-Id: I9043c2acc95986275ee24d9c5d944e5fe2702e99 > --- > gnu/packages/engineering.scm | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm > index b1776484b5..08ff06fa94 100644 > --- a/gnu/packages/engineering.scm > +++ b/gnu/packages/engineering.scm > @@ -3798,6 +3798,33 @@ (define-public prusa-libbgcode > "Prusa Block & Binary G-code reader/writer/converter.") > (license license:agpl3)))) > > +(define-public prusa-wxwidgets > + ;; There is no tag/release, all patches are in separate branch. > + (let ((commit "78aa2dc0ea7ce99dc19adc1140f74c3e2e3f3a26")) > + (package > + (inherit wxwidgets) Due to not being delayed, inherit fields should only be used with values defined in the same module. So you should move prusa-wxwidgets to where wxwidgets comes from. See (info '(guix) Cyclic Module Dependencies'). > + (name "prusa-wxwidgets") > + (version "3.2.0") > + (home-page "https://github.com/prusa3d/wxWidgets") > + (source > + (origin > + (inherit (package-source wxwidgets)) > + (method git-fetch) > + (uri > + (git-reference > + (url home-page) > + (commit commit) > + (recursive? #t))) Recursive checkouts often mean bundled libraries are pulled and built as part of the same package, which should be avoided in Guix if the build system has supports for it. For this reason, we always leave a comment explaining why it's needed. > + (file-name (git-file-name name version)) > + (patches (search-patches "prusa-wxwidgets-makefile-fix.patch")) > + (sha256 > + (base32 > + "02nd07c23xbclnf1jjfbv6r5vqjb80gsdy2l559c5qzgdcvfd2xd")))) > + (arguments > + (substitute-keyword-arguments (package-arguments wxwidgets) > + ((#:configure-flags flags) Is this done to match upstream configuration? Perhaps add a comment. > + #~(cons "--disable-glcanvasegl" #$flags))))))) > + > (define-public prusa-slicer > (package > (name "prusa-slicer") Could you please send a v2? -- Thanks, Maxim