From: "Ludovic Courtès" <ludo@gnu.org>
To: Rodion Goritskov <rodion.goritskov@gmail.com>
Cc: 71722@debbugs.gnu.org
Subject: [bug#71722] [PATCH 0/2] services: Update agate-service-type to match actual agate options
Date: Fri, 26 Jul 2024 19:01:01 +0200 [thread overview]
Message-ID: <87plr0ay0i.fsf@gnu.org> (raw)
In-Reply-To: <cover.1719082137.git.rodion.goritskov@gmail.com> (Rodion Goritskov's message of "Sat, 22 Jun 2024 23:03:48 +0400")
Hi Rodion,
Rodion Goritskov <rodion.goritskov@gmail.com> skribis:
> This patches makes agate-service-type work again - because current version of agate present
> in Guix has some options (and their logic) changed, making service-type not working.
>
> I have checked this changes on VM and they seems to be working fine.
>
> Rodion Goritskov (2):
> services: agate: Update options for compatibility with the current
> Agate version.
> services: agate-service-type: Update documentation.
I squashed the two patches (so that the doc is always consistent with
the code) and applied them.
A few things come to mind:
1. Could you come up with a system test under gnu/tests/*.scm? That
would allow us to detect breakage early on next time.
2. Though a deprecation policy has yet to be written, the idea is that
we should avoid breaking changes in user configuration as happens
when changing/removing fields in the config record.
3. The convention in Guix is to avoid abbreviations (“certificates”
rather than “certs”, etc.). I realize those were already there
though, so I thought I’d rather not ask you for extra work.
Thanks,
Ludo’.
prev parent reply other threads:[~2024-07-26 17:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-22 19:03 [bug#71722] [PATCH 0/2] services: Update agate-service-type to match actual agate options Rodion Goritskov
2024-06-22 19:33 ` [bug#71722] [PATCH 1/2] services: agate: Update options for compatibility with the current Agate version Rodion Goritskov
2024-06-22 19:33 ` [bug#71722] [PATCH 2/2] services: agate-service-type: Update documentation Rodion Goritskov
2024-07-26 17:01 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plr0ay0i.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=71722@debbugs.gnu.org \
--cc=rodion.goritskov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.