From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 4fjLE+iS5WbFIAEAe85BDQ:P1 (envelope-from ) for ; Sat, 14 Sep 2024 13:43:04 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 4fjLE+iS5WbFIAEAe85BDQ (envelope-from ) for ; Sat, 14 Sep 2024 15:43:04 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=JcRKXBY7; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=JCC+VEl2; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1726321384; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=vkYT/uY9Ecni793gH1rJ6ABT0uP4iRIifIIZlgCzosg=; b=dL0Qmv8EHUIz6Hk9zUslqased5AViJa37cd9W0ZeDk8O3M6Y2uspC+0gFeIheb9APCFvIw zyxjDkcffKi4W7O8OmPafkBNj/DA3WrgxpsFw5q+vuAcSG5qYIeUG+ECU0kPerFd1dQO7D 5HhBN2+sQC0SFJINEEYdBnDVcuRS/PbeRi+sFBOgwcvhPW7YytPKTmKMQTwxNDFkUU8bPk P+zVFMPgS/2T0U9ot7eC5CthRCMBOQD9TLniC82V160Ub1XgBTe5lOc1QAPRapmpIfhkSe 0+WbFe9IXD2+apW3hdsr3VTp945XBVs9YBw9uT3fUTIDkxO8iMUwaEB2uZvkzA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1726321384; a=rsa-sha256; cv=none; b=BCRKO5UqyNh5IdSUwhrf/qxKzqp59goEk8FkmrcUjwStMKz/dEkO0pk8UmQXw1qtd0r8X1 VIthIkg0S1gwGQl+DOFgFusqJVh5ITGkKP4zy7JoZjdgqSzANWcJrVQanQoMaY/HwDmFBj JmtJGlll/zk9B5CDFkhtBLaVZy/8+6qZXznEDjJjWhQAB8IgYjr4eCxNoFrR/OtkEkRQfX BYo9n2AfGsuzFlwR4Wbge3ZjrXicP/ww1GVplHIKW/fKUw/kHBwxK6AEgI0AgqZNrB1WSN ewgouZtxMzCVESglPG+TldblyjsSHkcNVK9X0T3cIm/l8jKQSpX+UNyDefWJtQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=JcRKXBY7; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=JCC+VEl2; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B74C21EF06 for ; Sat, 14 Sep 2024 15:43:03 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1spT39-0006hr-9R; Sat, 14 Sep 2024 09:42:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1spT37-0006hT-17 for guix-patches@gnu.org; Sat, 14 Sep 2024 09:42:53 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1spT36-0005JW-5K for guix-patches@gnu.org; Sat, 14 Sep 2024 09:42:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=vkYT/uY9Ecni793gH1rJ6ABT0uP4iRIifIIZlgCzosg=; b=JcRKXBY7UONupmdi6Acktu4ujXzDHaZb2xZBrdrsgDBpySH0F5Efd4makioN0jRz3p51tv4k+dewxsC4lyfpfF4qcQS6LscNBoFIkAueiTiarQIg8V7MAqvYu5EgTH/n95patU3YaNjSRM1LeFy6+nUduJqCK6B5oBwndpB0HVb29A5yvom8zTb+Ox4eKSdmKm2h6uI9bLxNSiAg+ayYM4yg8xGYOrQmbdQJ7uRXcPstPgqkdAXoNbcIwLVbUg3lyPEhDHmntI6gPPJoAkxWRjM5b8ajFuyGEPSmVPwEtrCsJipDLO5Kli2TzduvsZUPi2Gz/b7CxdcTcaq9i7lGHg==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1spT3G-0006zT-LD for guix-patches@gnu.org; Sat, 14 Sep 2024 09:43:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73028] [PATCH] doc: Document usage of #:out-of-source? for meson-build-system. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 14 Sep 2024 13:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73028 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Dariqq Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 73028@debbugs.gnu.org, Florian Pelz Received: via spool by 73028-submit@debbugs.gnu.org id=B73028.172632135926820 (code B ref 73028); Sat, 14 Sep 2024 13:43:02 +0000 Received: (at 73028) by debbugs.gnu.org; 14 Sep 2024 13:42:39 +0000 Received: from localhost ([127.0.0.1]:45146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1spT2t-0006yW-9X for submit@debbugs.gnu.org; Sat, 14 Sep 2024 09:42:39 -0400 Received: from mail-pf1-f179.google.com ([209.85.210.179]:42149) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1spT2r-0006yG-1C for 73028@debbugs.gnu.org; Sat, 14 Sep 2024 09:42:37 -0400 Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-71798661a52so2309484b3a.0 for <73028@debbugs.gnu.org>; Sat, 14 Sep 2024 06:42:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726321281; x=1726926081; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=vkYT/uY9Ecni793gH1rJ6ABT0uP4iRIifIIZlgCzosg=; b=JCC+VEl28FOVHTCHIdc/NdPTc+3QCoPXvS4q7sg6+xgz7VGN0IXeKaW4ZY7W6jiX4n 7u3mg3H3l0k4wVoqQpRR8LZopzYV+hCfx3uJJTophyYSfp/HxXv4pTRbjoDLvt0FIjoD Wc3joulUAeHbNSVLT2m9ipPRvpcTOd0wOI8TD10rswXppuSEORGUlKVTFbck5wNE8rhy kcDFviwEiWG3ZKBufPyUmrfU95ZuqkSDXVx3ZWcUz1zEeCW0kF/jajOmzWatIoUGnast WGSDZmqYLMJGfc1fU9fbJFvrrJOvyDScvfz5C1o9BeyHXH+FP+UbZAu6hDzHzfuqtFQI LdLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726321281; x=1726926081; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vkYT/uY9Ecni793gH1rJ6ABT0uP4iRIifIIZlgCzosg=; b=i0K5S5DxJtCzN3+PFpybBKd88TclW0TD/P2UBRKrY6IfxMGxQsSU7t39mx29GdlD6/ a+HL65PmKPnntqZ7aAlsaJfjWlrw0o0JLrdn91hgINMn2/RGNdeXqexbtkqGnAVui+oV UMDuVG22K3uK98YZSsmyJGZ5oGxseN6gEN+f9ObNCBfXrvkE4HsJ55Py1peYNRB+GkwU w5orbQSbhH0wKcpGwZzVt3mEFHR1dk+oVWAU/5vN/OiWFSwlP886e0geMeXox+0MY2gq HcLbFiEW3HnpWcsXNXIJTjDdCziMffbIGegY1vlqCvzwxsBfEIjwru3iqYkNojjj+3wm hJSQ== X-Gm-Message-State: AOJu0YxlUs90RBBkeCnY3L/mNYFNEuEZXKVOtiqo+BE52Wse9qCXp6C+ 01t54E44BapH5ho4KJvjbPdD0sjZIlKOMUAktyo1o3BsPqWOHxBJ X-Google-Smtp-Source: AGHT+IHy/aHQ6TFwPDBsY6mo21ISFbS1VqIg3pyTa+A4uRB1/FG/rbNKczyMX21u9JklVwGtHBly+w== X-Received: by 2002:a05:6a00:18a3:b0:717:9896:fb03 with SMTP id d2e1a72fcca58-719263cbe2emr15062334b3a.6.1726321280587; Sat, 14 Sep 2024 06:41:20 -0700 (PDT) Received: from hurd ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bca0b7sm996309b3a.215.2024.09.14.06.41.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Sep 2024 06:41:19 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <8a62a876-58e8-401f-9716-9b661bd008f5@posteo.net> (dariqq@posteo.net's message of "Thu, 12 Sep 2024 19:19:02 +0000") References: <878qvy3ent.fsf@gmail.com> <97aa51a8-a945-44f4-8a61-e9bbc3eddba4@posteo.net> <87jzfhy9jf.fsf@gmail.com> <877cbhw050.fsf@gmail.com> <8a62a876-58e8-401f-9716-9b661bd008f5@posteo.net> Date: Sat, 14 Sep 2024 22:41:16 +0900 Message-ID: <87plp6s683.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -10.43 X-Migadu-Queue-Id: B74C21EF06 X-Spam-Score: -10.43 X-TUID: cPPNeert0SCd Hi Dariqq, Dariqq writes: > On 12.09.24 14:02, Maxim Cournoyer wrote: >> Hi Dariqq, >> Dariqq writes: >> [...] >> >>>>> Maybe it should not be an option at all and instead be #t >>>>> unconditionally in 'install-license-files phase in meson-build-system? >>>> Given most build phases of the gnu-build-system, which support >>>> #:out-of-source? are reused in the meson-build-system, this argument >>>> needs to be set to #t (which it currently is). But perhaps there's a >>>> way to hide it from the users, perhaps via the 'private-keywords' >>>> variable defined in the 'lower' procedure of the (guix build-system >>>> meson) module (I haven't tested). >>>> >>> >>> Something like that might be a better solution. I am not sure how >>> these 'private-keywords' work: It looks like #:meson is one but you >>> can definitly override the default meson being used. Also the >>> private-arguments seem to get stripped from the arguments in the bag >>> (not sure what that is exactly) so they might not be passed to the >>> build phases >> I think your understanding is correct. The private options are >> accepted >> on the build system, but not propagated to the lower build strata >> (applied to phases). So what we'd like here is to *not* expose an >> #:out-of-source argument at the build system level, and enforce >> #:out-of-source #t for the lower build code. I guess the static #t >> argument could be added to the bag arguments. >> > > This does not work. I tried adding that to the arguments in the bag > (and reverting the previous patch) but get an error: > > Unrecognized keyword: #:out-of-source? > > I guess this is because meson-(cross-)build now get a keyword they > don't know. Hm. Thanks for trying it out. > Maybe we could replace the install-license-files function with a > version that has #:out-of-source? set to #t?. Not sure if there is an > elegant way to do this? Is this really the only reused phase from gnu-build-system that makes use of #:out-of-source? I'd expect the 'configure' to be one, also. And in general it'd be a bit more risky; new gnu-build-system phases that would make use of #:out-of-source could start breaking in the future until thye are specially handled. -- Thanks, Maxim