From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 6MDPNpg9+2aKbwEA62LTzQ:P1 (envelope-from ) for ; Tue, 01 Oct 2024 00:08:57 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id 6MDPNpg9+2aKbwEA62LTzQ (envelope-from ) for ; Tue, 01 Oct 2024 02:08:57 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="p/R/wDLo"; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=hQcvs1Qn; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1727741336; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=7XpxWmIEG34YQry1abNzhRIo4dZHWv+FZ9nBItll93E=; b=J/i0sThu+vgpzFaWmsRX95OBIeJ2p0RNAeVGI7g9bArjY+fEWohJ9FM/Afoy7NL6tfpPsW VhfGvWss+W45novKpnxMMNiWBWNSGrrcS7p+JArvzC2ToRaqRyGoEblmfG58SqpzVpT71O +k3K/0zWdPaCR9VHDYajW03TSwnDEq820BIiwPREyAzzVwV/5VCcL8t1j+OiMUThB4mixp TVEfSfp9TeJdbpsik5/WDU+Yw0+rlywsN8dsAlHSMt1F+cJ6pS6kXn6bqiJ4dS2CcoYcwd UjMGNTw+WhJO65EQ5J3zecTeoz9rQ0J3Wzzjn1XPGr7nAGJAEYGMXmYoUbw2Cw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1727741336; a=rsa-sha256; cv=none; b=hhvCzKc3mNjnliFLDNg/0mnjERxwsXXX3hDC2149o/1RqNFlwvapJalhabneoCo+IrtE7S R5WG18RYYkWV6RbvRMAi7va4O6eXm4MPb1bicQ48JYcQx3sPs8C0cvzys0ljt0rbW7xDjv LB5W7rIo+14d7l4DTNJ6m5+wIHScAdSPCeWxE7T2PoSntf8HR+2bRCgW8Fk0Ayu3RURgEU 2poT7JFSygtMF4SdOTEfugdAFyRjWw0RxYjUlYuoPbPab7KxFct676vELW5A9JOgpve5GK KL+nqZ3e4Pd0j5Xuor0Ipr3AUHi14Y0SVrV1AUeH5fYRff/D+KkNzoyUxHhvaw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="p/R/wDLo"; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=hQcvs1Qn; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3FE638DA02 for ; Tue, 01 Oct 2024 02:08:55 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1svQRN-0004JD-B4; Mon, 30 Sep 2024 20:08:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svQRL-0004It-2R for guix-patches@gnu.org; Mon, 30 Sep 2024 20:08:31 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1svQRK-0006vl-PF for guix-patches@gnu.org; Mon, 30 Sep 2024 20:08:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=7XpxWmIEG34YQry1abNzhRIo4dZHWv+FZ9nBItll93E=; b=p/R/wDLon0WlryMss9fwwr6T95y094nu3Ba+xDvIHIhw3WGj2VVYQnUWpVDE42EcpuvNw3GFI4cAyomu+eRN5rL0q35mthfcqp7T32AUP/BXDkXWWhGy9io1jI055uTDaez1F+dajeyyXHqfha38EK/dSKX6qR9qb56UWSHQiVjLUCNK9i8f9HmnKgB/0GaYWC1+e9gM1dlXoe8RBUdB8ixvzIPUrRNLhc16LtxsDPoztBVMopZFh3FEvw49sjY4ExPuvzEcdBfrooM+u6dD4J9Nv1aYPBtf/z9bJSwLih7QnqnxcZhfunFS40C1yD7C1i1tU1QpW05TdEbR8IQD2w==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1svQRq-0001dW-Ic; Mon, 30 Sep 2024 20:09:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72925] [PATCH v3] adding jpm package Resent-From: Suhail Singh Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org, "Suhail Singh" Resent-Date: Tue, 01 Oct 2024 00:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72925 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Omar Bassam Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Munyoki Kilyungi , Katherine Cox-Buday , Guillaume Le Vaillant , jgart Received: via spool by 72925-submit@debbugs.gnu.org id=B72925.17277413276280 (code B ref 72925); Tue, 01 Oct 2024 00:09:02 +0000 Received: (at 72925) by debbugs.gnu.org; 1 Oct 2024 00:08:47 +0000 Received: from localhost ([127.0.0.1]:47896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svQRa-0001dE-8Q for submit@debbugs.gnu.org; Mon, 30 Sep 2024 20:08:46 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:56665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svQRU-0001d6-UM for 72925@debbugs.gnu.org; Mon, 30 Sep 2024 20:08:43 -0400 Received: by mail-qt1-f194.google.com with SMTP id d75a77b69052e-45830ff5b70so42704431cf.1 for <72925@debbugs.gnu.org>; Mon, 30 Sep 2024 17:08:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727741222; x=1728346022; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=7XpxWmIEG34YQry1abNzhRIo4dZHWv+FZ9nBItll93E=; b=hQcvs1Qneb/V7QZEHFcCcafTFxbpv+513b37mFqTk0vdNah8EjbLZbBab2uA6A3+9C agkZsR7qTXKToorDo4orf7fhhHQD0l1dYPHRil0Wkz7FUT00lAYkR/dd7i5RQDC4QQeg x1aMlQD4dBh3QGFUCPG5I8kfXvCfTQ8wOLF2fTgMe4WvdI6GAqzvLA7PmyLV4wJ93Xcs E6HH+vdsCAWXoTeqhDx2rfQoN9KxO0FT2/BUSFtXHdSZ4g3Aj0qfyj/iEW8de/TvgXsq 4MCNpEHiraEFb/rK3cRZVPDZzMJHBc47P5/A7pxIGrG/SQhse4JlSkpF5yKB39x2uiqN VqTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727741222; x=1728346022; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7XpxWmIEG34YQry1abNzhRIo4dZHWv+FZ9nBItll93E=; b=d0Xi+C4RpG0ZWL0JqGdzGe6Pb/PrFaokCX97jNyHCtCAc6MexH+8Ls+DP3NFZ9zy2I 0mUcIv4+xWBGDaWi8aBs/llaev+z1B9C0JemMy5VHChWVv/uAlKptBmohPK4BtutQHdp E4hbu8BQfHO6ivdVQ8j8WSmcuaA/Xuw+3aUO4zkblp6fl8QyuXeUcqp3MceBx3ci/1KW tByGvxJ1eSjaq0Jj+KpXzvK27xmXelottXImTRm4M9xWn+6QKSA+zqroUIY0S/P15c3v JkWjnMzYvE2gnMhcd/+TIMLs+mnzGHJ2IPafrWzE/Ef3DTUU6A2Q7EJOZRbS9Z+qidYr R9+A== X-Gm-Message-State: AOJu0Yz0mG2dtgWZwXAUQK/mO9o2d0VZGIVE+aVnOew7zDM7UyrrOeV8 KS5sTfqEaQGqazLfvMcTts5fEsNlSf0zVmUWMgRqOohZJA2QGh1D X-Google-Smtp-Source: AGHT+IHxqWm++2y2YjvgVMWLvDXnKffwwO/qMDT3LB0nct2rVDawQ3rX1Y7vHZw895ZPl+scr7T+Tw== X-Received: by 2002:a05:622a:199a:b0:447:f4f6:7a1 with SMTP id d75a77b69052e-45c9f2c628amr182709481cf.52.1727741221727; Mon, 30 Sep 2024 17:07:01 -0700 (PDT) Received: from gnus ([65.94.70.53]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-45c9f350fadsm40571751cf.80.2024.09.30.17.06.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2024 17:07:00 -0700 (PDT) From: Suhail Singh In-Reply-To: <4e623d9571ff648ae1d1c6ffb8f9d73c421a5c10.1727683810.git.omar.bassam88@gmail.com> (Omar Bassam's message of "Mon, 30 Sep 2024 11:12:13 +0300") References: <4e623d9571ff648ae1d1c6ffb8f9d73c421a5c10.1727683810.git.omar.bassam88@gmail.com> Date: Mon, 30 Sep 2024 20:06:48 -0400 Message-ID: <87plok7kkn.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 3FE638DA02 X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: 0.18 X-Migadu-Spam-Score: 0.18 X-TUID: /zLm3G0BxA7y Omar, thank you for sending a revised patch. I have a few comments relating to style and one unanswered question from our last exchange. > Subject: [bug#72925] [PATCH v3] adding jpm package In v4, could you please update the commit message to conform to the ChangeLog format as noted in . Please see for additional details. If you're using magit, `magit-generate-changelog' can help with this. In your case the commit will probably look something like: #+begin_quote gnu: Add jpm. * gnu/packages/lisp.scm (jpm): New variable. #+end_quote Omar Bassam writes: > +(define-public jpm > + (package > + (name "jpm") > + (version "1.1.0") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/janet-lang/jpm.git") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 (base32 "05rdxigmiy7vf93s16a8n2029lq33073jccz1rjl4iisxj6piw4l")))) There are no build errors with this, however, it's not clear how to verify that the runtime behaviour of jpm is as expected. After installing janet and jpm in a guix profile, running a command such as: #+begin_src sh jpm install sh #+end_src Results in the following: #+begin_example $> jpm install sh error: Read-only file system: /gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/.cache in os/mkdir [src/core/os.c] on line 1981 in download-bundle [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] on line 200, column 3 in bundle-install [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] on line 217, column 13 in resolve-bundle-name [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] on line 118, column 20 in resolve-bundle [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] on line 148, column 9 in bundle-install [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] on line 216, column 4 in install [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/commands.janet] (tail call) on line 190, column 20 in run-main [boot.janet] on line 4432, column 16 in cli-main [boot.janet] on line 4613, column 17 #+end_example Could you please share an example code snippet which can be used to verify correctness of the installation? Additionally, it seems that the jpm repository comes with a test (./test/installtest.janet and ./testinstall). However, it doesn't seem like we're running it during the build. Could you please share the reasons why? If possible, we should enable and run these tests. > + (build-system copy-build-system) > + (arguments > + (list > + #:phases #~(modify-phases %standard-phases > + (add-after 'unpack 'fix-prefix-path > + (lambda _ > + (substitute* "configs/linux_config.janet" > + (("/usr/local") #$output)) > + (setenv "PREFIX" #$output))) > + (replace 'install > + (lambda _ V3 doesn't cleanly apply due to whitespace issues on this (^) line. Please fix. On a related note, in case you're not aware, please observe all the steps listed in . Steps 3 and 4 recommend invoking guix lint and guix style which, unless I'm mistaken, would've caught this issue. -- Suhail