[bug#74568] [PATCH] add scenefx

[Zheng Junjie <zhengjunjie@iscas.ac.cn>]

[-- Attachment #1: Type: text/plain, Size: 1755 bytes --]

Josep Bigorra <jjbigorra@gmail.com> writes:

> This is my first attempt to contribute! :) I want to update Swayfx to 0.4 after this, but first, scenefx must be in guix packages. Hopefully
> this will do?

please use plain-txt e-mail. and use `mumi send-email' or
`git send-email' to send patch. see
https://guix.gnu.org/manual/devel/en/html_node/Sending-a-Patch-Series.html#Single-Patches-1

>-    (name "sway")

If you do not modify the package, do not modify the indentation of the package

>+   (inputs (map (lambda (x) (specification->package x))
>+                `("basu"
>+                  "cairo"
>+                  "gdk-pixbuf"
>+                  "json-c"
>+                  "cmake"
>+                  "libevdev"
>+                  "libinput-minimal"
>+                  "libxkbcommon"
>+                  "pcre2"
>+                  "pkg-config"
>+                  "pcre2"
>+                  "wayland"
>+                  "libdrm"
>+                  "wlroots@0.17.4")))

You cannot use specification->package in a package, use the scheme
variable.

many package is not needed, just pixman mesa libxkbcommon libdrm
wlroots-0.17. see meson.build.

and pkg-config usually is native-inputs, It need to actually run on
cross-compiling.

>+   (home-page "https://github.com/wlrfx/scenefx.git")

guix lint scenefx say scenefx@0.1: permanent redirect from https://github.com/wlrfx/scenefx.git to https://github.com/wlrfx/scenefx.

so should https://github.com/wlrfx/scenefx.

>+   (synopsis "SceneFX")
>+   (description
>+    "SceneFX")

Please write useful synopsis and description
see https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html

After the completion of the modified like
https://issues.guix.gnu.org/74568#1

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]