bug#44256: “guix import cran -a bioconductor FOO” downloads twice

bug#44256: “guix import cran -a bioconductor FOO” downloads twice

[zimoun]

Dear,

--8<---------------cut here---------------start------------->8---
$ guix import cran -a bioconductor CATALYST

Starting download of /tmp/guix-file.OPtOW1
From https://bioconductor.org/packages/release/bioc/src/contrib/CATALYST_1.12.2.tar.gz...
 …12.2.tar.gz  10.2MiB                567KiB/s 00:18 [##################] 100.0%

Starting download of /tmp/guix-file.V6sC1Z
From https://bioconductor.org/packages/release/bioc/src/contrib/CATALYST_1.12.2.tar.gz...
 …12.2.tar.gz  10.2MiB                565KiB/s 00:19 [##################] 100.0%
--8<---------------cut here---------------end--------------->8---

I have not investigated more, if the issue is from the importer or from
the information provided by Bioconductor.


All the best,
simon

bug#44256: “guix import cran -a bioconductor FOO” downloads twice

[zimoun]

Hi,

On Tue, 27 Oct 2020 at 14:55, zimoun <zimon.toutoune@gmail.com> wrote:

> $ guix import cran -a bioconductor CATALYST
>
> Starting download of /tmp/guix-file.OPtOW1
>>From https://bioconductor.org/packages/release/bioc/src/contrib/CATALYST_1.12.2.tar.gz...
>  …12.2.tar.gz  10.2MiB                567KiB/s 00:18 [##################] 100.0%
>
> Starting download of /tmp/guix-file.V6sC1Z
>>From https://bioconductor.org/packages/release/bioc/src/contrib/CATALYST_1.12.2.tar.gz...
>  …12.2.tar.gz  10.2MiB                565KiB/s 00:19 [##################] 100.0%
>
> I have not investigated more, if the issue is from the importer or from
> the information provided by Bioconductor.

It comes from ’cran->guix-package’ in (guix import cran):

--8<---------------cut here---------------start------------->8---
     (let ((description (fetch-description repo package-name)))
       (if description
           (description->package repo description)
--8<---------------cut here---------------end--------------->8---

where ’fetch-description’ effectively downloads but then
’description->package’ downloads again:

--8<---------------cut here---------------start------------->8---
         (source     (download source-url #:method (cond
                                                    (git? 'git)
                                                    (hg? 'hg)
                                                    (else #f))))
--8<---------------cut here---------------end--------------->8---

This second download is not necessary.  The fix needs some care with the
different repositories.


Cheers,
simon

bug#44256: “guix import cran -a bioconductor FOO” downloads twice

[Ricardo Wurmus]

Fixed with commit 64d9c7ea3fec163d86dde933471594ef2fe8c356 (on r-team
branch).  This will soon be rebased on top of the master branch and
merged.

-- 
Ricardo

bug#44256: “guix import cran -a bioconductor FOO” downloads twice

[Simon Tournier]

Hi Ricardo,

On Fri, 29 Nov 2024 at 19:35, Ricardo Wurmus <rekado@elephly.net> wrote:
> Fixed with commit 64d9c7ea3fec163d86dde933471594ef2fe8c356 (on r-team
> branch).  This will soon be rebased on top of the master branch and
> merged.

Cool for the fix!  Hum, I do not find this commit.  Do I miss something?

Cheers,
simon

bug#44256: “guix import cran -a bioconductor FOO” downloads twice

[Ricardo Wurmus]

Simon Tournier <zimon.toutoune@gmail.com> writes:

> Hi Ricardo,
>
> On Fri, 29 Nov 2024 at 19:35, Ricardo Wurmus <rekado@elephly.net> wrote:
>> Fixed with commit 64d9c7ea3fec163d86dde933471594ef2fe8c356 (on r-team
>> branch).  This will soon be rebased on top of the master branch and
>> merged.
>
> Cool for the fix!  Hum, I do not find this commit.  Do I miss something?

You didn't miss anything.  The r-team branch keeps getting rebased as
other branches are merged into master, so the commit hash changes.  I'll
try to remember to close this bug once the r-team branch has been
merged.

-- 
Ricardo

bug#44256: “guix import cran -a bioconductor FOO” downloads twice

[Ricardo Wurmus]

The commit fixing it is f0a93b18b4488c3bb802197aba4a31b28508c902 on the
master branch.

Since this bug was reported, there is a new extraneous download which
does not originate from the importer itself, as discussed here:
https://yhetil.org/guix-devel/87zflkctrz.fsf@elephly.net/

It may be worth opening a new bug report about this.

-- 
Ricardo