From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id CLoRHSp7eWersAAA62LTzQ:P1 (envelope-from ) for ; Sat, 04 Jan 2025 18:17:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id CLoRHSp7eWersAAA62LTzQ (envelope-from ) for ; Sat, 04 Jan 2025 19:17:14 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=bnQDlOoq; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=WCNtaxE7; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1736014634; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=SEvfXEA5jtmDZovbOao6leZLt9wioqSQX3ORyYQwcxw=; b=YGvCdYnrEiynli81zK+xQKhGzdMejJ+wdwwZjHUqXUcHyz0Ksfh+JUNXAW6YUmYv8jxtb6 E+0n+LQDtSsIhidsG5GLVuTYYZOfShmIYprOSOXLSxvAvkcote75mv9RyK2+jxugfd+/5V nyyCYu1FcpLX5VYSfaB2JU9PQOwTI6sYOOrnVhB8hXwux4oerhekbtLtuUibdS/IQ1+z76 BNzcrkEkSGIWq+Klw2gGKIKru+DsxPgXTR0I3w0U8gmiwQTphmBmijd29+ZiWuQJpZ6m5E gjKIVpNuM2pcYAID+ItnvNk46Nc+TaJhVbSqqDkCdVml1ZCLMr3lVJY5J9Niig== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=bnQDlOoq; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=WCNtaxE7; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1736014634; a=rsa-sha256; cv=none; b=Fl/jWjhghK01jEHyqEWHog+KecpwFj2G01u+poPk573a0QX+WjhsCp3jpUVgTrtiqKdPBJ 4+YchFrw1SB9skTLlt7QUPpSEZSS5dqBs3Zgum06uD4nAG/bWxAxIcnuv6BYlCjbDZYNax Udnlymb1unO6P2upKoSkoHaVlyeg5VXWTzBRJXHC01re80GMttTqiGCdnkWQ7Jpu9TELEG tQVqft7atn0DSXoMnZIVtprVaQe0MA2ETpXZycE6llQZFH1Dei+OixjGmtahfCMLaqLoYe i9UcVwem+qhlutfK6lLiNGjwwZVw1mbMpbJ2ndGPzU/wkimVhNULFJG6OydBtw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 11EA944C9B for ; Sat, 04 Jan 2025 19:17:14 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tU8hs-0004O3-NC; Sat, 04 Jan 2025 13:17:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU8hq-0004Nn-5y for guix-patches@gnu.org; Sat, 04 Jan 2025 13:17:02 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tU8hp-0001NX-T9 for guix-patches@gnu.org; Sat, 04 Jan 2025 13:17:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=SEvfXEA5jtmDZovbOao6leZLt9wioqSQX3ORyYQwcxw=; b=bnQDlOoqlPJxwNFQMnEWNs7NdVdmkoGhiK+QQh8/1vtVRb5+pJJ/+EX8hvUSFEPaT579B9+SYO9X8uZve5xVWYcBEpp7y//iuu1X6BaW9H/h0vOlrlJ6xsm7hVIMMaXLAx9usNRHA/8Le0FW344IKG1v/1z6TVPvyynZwJTN3U0b3v6qMH7+RmjGHyiXRrZvHbmXuqT3NHb8KPigpaO53h9QG6IafJ7NUcOfZRR/mRpoKLCYWEz2BU7XrsL7EfAmdggrhMmRRDq/6NWbloW+lbPI25UWsvPydZXNH1Ov6TNTJ3j1uXsIyHaeU7CZj3qchPUb/7kjBpXfHHdfxvXFEQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tU8hp-0005cJ-Lo for guix-patches@gnu.org; Sat, 04 Jan 2025 13:17:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74860] [PATCH 02/10] services: Add =?UTF-8?Q?=E2=80=98log-rotation-service-type=E2=80=99.?= Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 04 Jan 2025 18:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74860 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 74860@debbugs.gnu.org Received: via spool by 74860-submit@debbugs.gnu.org id=B74860.173601458921534 (code B ref 74860); Sat, 04 Jan 2025 18:17:01 +0000 Received: (at 74860) by debbugs.gnu.org; 4 Jan 2025 18:16:29 +0000 Received: from localhost ([127.0.0.1]:57263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU8hI-0005bF-Qp for submit@debbugs.gnu.org; Sat, 04 Jan 2025 13:16:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48104) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tU8hG-0005an-0D for 74860@debbugs.gnu.org; Sat, 04 Jan 2025 13:16:26 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU8hA-0001Kz-F9; Sat, 04 Jan 2025 13:16:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=SEvfXEA5jtmDZovbOao6leZLt9wioqSQX3ORyYQwcxw=; b=WCNtaxE7q9TN4uvwwpm4 QQjgxI7Ew2FejZRB/lUDv0lZ8M40kHIcVT9JZPp4tv8SIA+ccicEvnZjifCG7y7s2rV2XTaZtmtVs fcybxnn9/RqyyKtCUc5icuDY7og0JZdoQxJouAeXjTHj1dKy9fIg4az9PhsXuanV4BjPaMATv9cg+ D2khCECQMFScdxF/7z9v3qkAw2nOtAKCvqpE6fdKyPJlM3uJsAZUC5E1r+zP1adHY/AQMkL1PECZZ YWldF8l77WUrGmwJdwPRyGC9fWibyBQLffABJV8GHARvnJ5+Ns9ybZBxuYdUwjx15cpKDGWjeDLFv agMC3CMdaXTQYQ==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <87seq15md4.fsf@gmail.com> (Maxim Cournoyer's message of "Thu, 02 Jan 2025 23:19:51 +0900") References: <97dd04a5fbb49bcacc4b7d61749f64c8c6fae9d5.1734129908.git.ludo@gnu.org> <87seq15md4.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quintidi 15 =?UTF-8?Q?Niv=C3=B4se?= an 233 de la =?UTF-8?Q?R=C3=A9volution,?= jour du Lapin X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 04 Jan 2025 19:16:10 +0100 Message-ID: <87pll2phqt.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 11EA944C9B X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -4.38 X-Spam-Score: -4.38 X-TUID: vK9PWpWLPQA6 Hi, Maxim Cournoyer skribis: >> +@item @code{compression} (default: @code{'gzip}) >> +This is the compression method used for rotated log files, one of >> +@code{'none}, @code{'gzip}, and @code{'zstd}. > > Why not default to zstd? It's superior to gzip in all regards, as far > as I know. We use it already preferably to gzip to compress man pages > for example. Perhaps we should consider it as our default compressor > from now on? It=E2=80=99s just that it=E2=80=99s the default, conservative choice, and a= lso what rottlog has been doing. But yes, why not change to zstd. I=E2=80=99ll make that change. > Is there a technical reason for not using define-configuration here? Not really, habit mostly. > Otherwise, define-configuration offers superior error checking and > useful error messages on invalid input types. I=E2=80=99m not entirely convinced but yeah I=E2=80=99ll do that in v2. Thanks! Ludo=E2=80=99.