all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* lightdm updates need to review.
@ 2025-01-08  1:39 Feng Shu
  2025-01-08 13:44 ` jbranso
  0 siblings, 1 reply; 4+ messages in thread
From: Feng Shu @ 2025-01-08  1:39 UTC (permalink / raw)
  To: guix-devel


Hello everyone.

I have try many display-manager in guix: gdm, sddm, slim and lightdm,
and finally find lightdm is very comfortable to use after it fix session
menu dispear problem in gux:

1. it start very fast.
2. lightdm-gtk-greeter can change font, background easy.
3. it can support other greeters.


I have send the below patches, please review them if someone have time,
thanks,

1. Add lightdm-greeter-general-configuration and simplify code

    https://issues.guix.gnu.org/75048


with this configuration, user can use other greeter, for example:
slick-greeter, lightdm-mini-greeter, lightdm-tiny-greeter or
lightdm-pantheon-greeter easily.

2. Add slick-greeter

    https://issues.guix.gnu.org/75043

3. Add lightdm-tiny-greeter

   https://issues.guix.gnu.org/75417

4. Add lightdm-pantheon-greeter 

   https://issues.guix.gnu.org/75186


For I use xfce4, so I just package some greeter using gtk, and do not
package greeter using qt, if someone interesting, can try :-)

the below is lightdm configuration to test:


```
(service lightdm-service-type
               (lightdm-configuration
                (greeters
                 (list (lightdm-greeter-general-configuration
                        (greeter-package slick-greeter)
                        (greeter-session-name "slick-greeter")
                        (greeter-config-name "slick-greeter.conf")
                        (config (list "[Greeter]"
                                      "font-name = San 12"
                                      "background = /run/current-system/profile/share/backgrounds/guix/guix-checkered-16-9.svg")))
                       (lightdm-greeter-general-configuration
                        (greeter-package lightdm-mini-greeter)
                        (greeter-session-name "lightdm-mini-greeter")
                        (greeter-config-name "lightdm-mini-greeter.conf")
                        (config (list "[greeter]"
                                      "user = guest"
                                      "[greeter-hotkeys]"
                                      "mod-key = control"
                                      "session-key = e")))
                       (lightdm-greeter-general-configuration
                        (greeter-package (customize-lightdm-tiny-greeter #:session "icewm"))
                        (greeter-session-name "lightdm-tiny-greeter")
                        (greeter-config-name "lightdm-tiny-greeter.conf")
                        (config (list "## Lightdm-mini-greeter have no config, ignore it!")))
                       (lightdm-greeter-general-configuration)
                       (lightdm-gtk-greeter-configuration
                        (lightdm-gtk-greeter lightdm-gtk-greeter-gee)
                        (extra-config
                         (list "font-name = San 10"
                               "icon-size = 64"
                               "xft-dpi = 140"
                               "clock-format = %Y-%m-%d %H:%M"
                               ;; We need to use "~~" to generate a tilde, for
                               ;; extra-config sting will be handle as
                               ;; control-string of format function.
                               "indicators = ~~host;~~spacer;~~session;~~a11y;~~clock;~~power")))))
                (seats
                 (list (lightdm-seat-configuration
                        (name "*")
                        (greeter-session 'lightdm-tiny-greeter))))

                (xorg-configuration
                 (xorg-configuration
                  ;; The QXL virtual GPU driver is added to provide a better
                  ;; SPICE experience.
                  (modules (cons xf86-video-qxl
                                 %default-xorg-modules))
                  (keyboard-layout keyboard-layout)
                  (server-arguments
                   (append %default-xorg-server-arguments
                           '("-dpi" "140")))))))


```


-- 



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: lightdm updates need to review.
  2025-01-08  1:39 lightdm updates need to review Feng Shu
@ 2025-01-08 13:44 ` jbranso
  2025-01-08 22:00   ` Feng Shu
  0 siblings, 1 reply; 4+ messages in thread
From: jbranso @ 2025-01-08 13:44 UTC (permalink / raw)
  To: Feng Shu, guix-devel

Thanks for the submission Feng!

Just a couple of things:

1) Try to send your email as plaintext, not html.  Most developers prefer 
plaintext emails.  :)

2)  I would encourage you to read this webpage: 
    https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html

   Essentially you should submit patches with "git send-email"
   ( https://git-send-email.io/ ), and you should submit patches to:
   guix-patches@gnu.org .  Guix devel does not create an bug report.
   BUT guix-patches@gnu.org will create a correspending bug report at
   issues.guix.gnu.org.

Thanks again for helping guix!


Joshua
A very helpful elf


January 7, 2025 at 8:39 PM, "Feng Shu" <tumashu@163.com mailto:tumashu@163.com?to=%22Feng%20Shu%22%20%3Ctumashu%40163.com%3E > wrote:



> 
> Hello everyone.
> 
> I have try many display-manager in guix: gdm, sddm, slim and lightdm,
> and finally find lightdm is very comfortable to use after it fix session
> menu dispear problem in gux:
> 
> 1. it start very fast.
> 2. lightdm-gtk-greeter can change font, background easy.
> 3. it can support other greeters.
> 
> I have send the below patches, please review them if someone have time,
> thanks,
> 
> 1. Add lightdm-greeter-general-configuration and simplify code
> 
>  https://issues.guix.gnu.org/75048
> 
> with this configuration, user can use other greeter, for example:
> slick-greeter, lightdm-mini-greeter, lightdm-tiny-greeter or
> lightdm-pantheon-greeter easily.
> 
> 2. Add slick-greeter
> 
>  https://issues.guix.gnu.org/75043
> 
> 3. Add lightdm-tiny-greeter
> 
>  https://issues.guix.gnu.org/75417
> 
> 4. Add lightdm-pantheon-greeter 
> 
>  https://issues.guix.gnu.org/75186
> 
> For I use xfce4, so I just package some greeter using gtk, and do not
> package greeter using qt, if someone interesting, can try :-)
> 
> the below is lightdm configuration to test:
> 
> ```
> (service lightdm-service-type
>  (lightdm-configuration
>  (greeters
>  (list (lightdm-greeter-general-configuration
>  (greeter-package slick-greeter)
>  (greeter-session-name "slick-greeter")
>  (greeter-config-name "slick-greeter.conf")
>  (config (list "[Greeter]"
>  "font-name = San 12"
>  "background = /run/current-system/profile/share/backgrounds/guix/guix-checkered-16-9.svg")))
>  (lightdm-greeter-general-configuration
>  (greeter-package lightdm-mini-greeter)
>  (greeter-session-name "lightdm-mini-greeter")
>  (greeter-config-name "lightdm-mini-greeter.conf")
>  (config (list "[greeter]"
>  "user = guest"
>  "[greeter-hotkeys]"
>  "mod-key = control"
>  "session-key = e")))
>  (lightdm-greeter-general-configuration
>  (greeter-package (customize-lightdm-tiny-greeter #:session "icewm"))
>  (greeter-session-name "lightdm-tiny-greeter")
>  (greeter-config-name "lightdm-tiny-greeter.conf")
>  (config (list "## Lightdm-mini-greeter have no config, ignore it!")))
>  (lightdm-greeter-general-configuration)
>  (lightdm-gtk-greeter-configuration
>  (lightdm-gtk-greeter lightdm-gtk-greeter-gee)
>  (extra-config
>  (list "font-name = San 10"
>  "icon-size = 64"
>  "xft-dpi = 140"
>  "clock-format = %Y-%m-%d %H:%M"
>  ;; We need to use "~~" to generate a tilde, for
>  ;; extra-config sting will be handle as
>  ;; control-string of format function.
>  "indicators = ~~host;~~spacer;~~session;~~a11y;~~clock;~~power")))))
>  (seats
>  (list (lightdm-seat-configuration
>  (name "*")
>  (greeter-session 'lightdm-tiny-greeter))))
> 
>  (xorg-configuration
>  (xorg-configuration
>  ;; The QXL virtual GPU driver is added to provide a better
>  ;; SPICE experience.
>  (modules (cons xf86-video-qxl
>  %default-xorg-modules))
>  (keyboard-layout keyboard-layout)
>  (server-arguments
>  (append %default-xorg-server-arguments
>  '("-dpi" "140")))))))
> 
> ```
> 
> --
>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: lightdm updates need to review.
  2025-01-08 13:44 ` jbranso
@ 2025-01-08 22:00   ` Feng Shu
  2025-01-09 13:33     ` jbranso
  0 siblings, 1 reply; 4+ messages in thread
From: Feng Shu @ 2025-01-08 22:00 UTC (permalink / raw)
  To: jbranso; +Cc: guix-devel

jbranso@dismail.de writes:

> Thanks for the submission Feng!
>
> Just a couple of things:
>
> 1) Try to send your email as plaintext, not html.  Most developers prefer 
> plaintext emails.  :)

OK, :-)

>
> 2)  I would encourage you to read this webpage: 
>     https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html
>
>    Essentially you should submit patches with "git send-email"
>    ( https://git-send-email.io/ ), and you should submit patches to:
>    guix-patches@gnu.org .  Guix devel does not create an bug report.
>    BUT guix-patches@gnu.org will create a correspending bug report at
>    issues.guix.gnu.org.
>
> Thanks again for helping guix!


Yes, all patches has been sent to guix-patches@gnu.org, see below:

1. https://issues.guix.gnu.org/75048
2. https://issues.guix.gnu.org/75043
3. https://issues.guix.gnu.org/75417
4. https://issues.guix.gnu.org/75186

>
>
> Joshua
> A very helpful elf
>
>
> January 7, 2025 at 8:39 PM, "Feng Shu" <tumashu@163.com mailto:tumashu@163.com?to=%22Feng%20Shu%22%20%3Ctumashu%40163.com%3E > wrote:
>
>
>
>> 
>> Hello everyone.
>> 
>> I have try many display-manager in guix: gdm, sddm, slim and lightdm,
>> and finally find lightdm is very comfortable to use after it fix session
>> menu dispear problem in gux:
>> 
>> 1. it start very fast.
>> 2. lightdm-gtk-greeter can change font, background easy.
>> 3. it can support other greeters.
>> 
>> I have send the below patches, please review them if someone have time,
>> thanks,
>> 
>> 1. Add lightdm-greeter-general-configuration and simplify code
>> 
>>  https://issues.guix.gnu.org/75048> 
>> with this configuration, user can use other greeter, for example:
>> slick-greeter, lightdm-mini-greeter, lightdm-tiny-greeter or
>> lightdm-pantheon-greeter easily.
>> 
>> 2. Add slick-greeter
>> 
>>  https://issues.guix.gnu.org/75043> 
>> 3. Add lightdm-tiny-greeter
>> 
>>  https://issues.guix.gnu.org/75417> 
>> 4. Add lightdm-pantheon-greeter 
>> 
>>  https://issues.guix.gnu.org/75186> 
>> For I use xfce4, so I just package some greeter using gtk, and do not
>> package greeter using qt, if someone interesting, can try :-)
>> 
>> the below is lightdm configuration to test:
>> 
>> ```
>> (service lightdm-service-type
>>  (lightdm-configuration
>>  (greeters
>>  (list (lightdm-greeter-general-configuration
>>  (greeter-package slick-greeter)
>>  (greeter-session-name "slick-greeter")
>>  (greeter-config-name "slick-greeter.conf")
>>  (config (list "[Greeter]"
>>  "font-name = San 12"
>>  "background = /run/current-system/profile/share/backgrounds/guix/guix-checkered-16-9.svg")))
>>  (lightdm-greeter-general-configuration
>>  (greeter-package lightdm-mini-greeter)
>>  (greeter-session-name "lightdm-mini-greeter")
>>  (greeter-config-name "lightdm-mini-greeter.conf")
>>  (config (list "[greeter]"
>>  "user = guest"
>>  "[greeter-hotkeys]"
>>  "mod-key = control"
>>  "session-key = e")))
>>  (lightdm-greeter-general-configuration
>>  (greeter-package (customize-lightdm-tiny-greeter #:session "icewm"))
>>  (greeter-session-name "lightdm-tiny-greeter")
>>  (greeter-config-name "lightdm-tiny-greeter.conf")
>>  (config (list "## Lightdm-mini-greeter have no config, ignore it!")))
>>  (lightdm-greeter-general-configuration)
>>  (lightdm-gtk-greeter-configuration
>>  (lightdm-gtk-greeter lightdm-gtk-greeter-gee)
>>  (extra-config
>>  (list "font-name = San 10"
>>  "icon-size = 64"
>>  "xft-dpi = 140"
>>  "clock-format = %Y-%m-%d %H:%M"
>>  ;; We need to use "~~" to generate a tilde, for
>>  ;; extra-config sting will be handle as
>>  ;; control-string of format function.
>>  "indicators = ~~host;~~spacer;~~session;~~a11y;~~clock;~~power")))))
>>  (seats
>>  (list (lightdm-seat-configuration
>>  (name "*")
>>  (greeter-session 'lightdm-tiny-greeter))))
>> 
>>  (xorg-configuration
>>  (xorg-configuration
>>  ;; The QXL virtual GPU driver is added to provide a better
>>  ;; SPICE experience.
>>  (modules (cons xf86-video-qxl
>>  %default-xorg-modules))
>>  (keyboard-layout keyboard-layout)
>>  (server-arguments
>>  (append %default-xorg-server-arguments
>>  '("-dpi" "140")))))))
>> 
>> ```
>> 
>> --
>>

-- 



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: lightdm updates need to review.
  2025-01-08 22:00   ` Feng Shu
@ 2025-01-09 13:33     ` jbranso
  0 siblings, 0 replies; 4+ messages in thread
From: jbranso @ 2025-01-09 13:33 UTC (permalink / raw)
  To: Feng Shu; +Cc: guix-devel

January 8, 2025 at 5:00 PM, "Feng Shu" <tumashu@163.com mailto:tumashu@163.com?to=%22Feng%20Shu%22%20%3Ctumashu%40163.com%3E > wrote:



> 
> jbranso@dismail.de mailto:jbranso@dismail.de  writes:
> 
> > 
> > Thanks for the submission Feng!
> > 
> >  Just a couple of things:
> > 
> >  1) Try to send your email as plaintext, not html. Most developers prefer 
> >  plaintext emails. :)
> > 
> OK, :-)
> 
> > 
> > 2) I would encourage you to read this webpage: 
> >  https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html
> > 
> >  Essentially you should submit patches with "git send-email"
> >  ( https://git-send-email.io/ ), and you should submit patches to:
> >  guix-patches@gnu.org . Guix devel does not create an bug report.
> >  BUT guix-patches@gnu.org will create a correspending bug report at
> >  issues.guix.gnu.org.
> > 
> >  Thanks again for helping guix!
> > 
> Yes, all patches has been sent to guix-patches@gnu.org, see below:
> 
> 1. https://issues.guix.gnu.org/75048
> 2. https://issues.guix.gnu.org/75043
> 3. https://issues.guix.gnu.org/75417
> 4. https://issues.guix.gnu.org/75186

Ok you are way ahead of me!  I wish there was more that I could do
to help you out.  Best of luck!

> > Joshua
> >  A very helpful elf
> > 
> >  January 7, 2025 at 8:39 PM, "Feng Shu" <tumashu@163.com mailto:tumashu@163.com?to=%22Feng%20Shu%22%20%3Ctumashu%40163.com%3E > wrote:
> > 
> > > 
> > > Hello everyone.
> > >  
> > >  I have try many display-manager in guix: gdm, sddm, slim and lightdm,
> > >  and finally find lightdm is very comfortable to use after it fix session
> > >  menu dispear problem in gux:
> > >  
> > >  1. it start very fast.
> > >  2. lightdm-gtk-greeter can change font, background easy.
> > >  3. it can support other greeters.
> > >  
> > >  I have send the below patches, please review them if someone have time,
> > >  thanks,
> > >  
> > >  1. Add lightdm-greeter-general-configuration and simplify code
> > >  
> > >  https://issues.guix.gnu.org/75048> https://issues.guix.gnu.org/75048%3E  
> > >  with this configuration, user can use other greeter, for example:
> > >  slick-greeter, lightdm-mini-greeter, lightdm-tiny-greeter or
> > >  lightdm-pantheon-greeter easily.
> > >  
> > >  2. Add slick-greeter
> > >  
> > >  https://issues.guix.gnu.org/75043> https://issues.guix.gnu.org/75043%3E  
> > >  3. Add lightdm-tiny-greeter
> > >  
> > >  https://issues.guix.gnu.org/75417> https://issues.guix.gnu.org/75417%3E  
> > >  4. Add lightdm-pantheon-greeter 
> > >  
> > >  https://issues.guix.gnu.org/75186> https://issues.guix.gnu.org/75186%3E  
> > >  For I use xfce4, so I just package some greeter using gtk, and do not
> > >  package greeter using qt, if someone interesting, can try :-)
> > >  
> > >  the below is lightdm configuration to test:
> > >  
> > >  ```
> > >  (service lightdm-service-type
> > >  (lightdm-configuration
> > >  (greeters
> > >  (list (lightdm-greeter-general-configuration
> > >  (greeter-package slick-greeter)
> > >  (greeter-session-name "slick-greeter")
> > >  (greeter-config-name "slick-greeter.conf")
> > >  (config (list "[Greeter]"
> > >  "font-name = San 12"
> > >  "background = /run/current-system/profile/share/backgrounds/guix/guix-checkered-16-9.svg")))
> > >  (lightdm-greeter-general-configuration
> > >  (greeter-package lightdm-mini-greeter)
> > >  (greeter-session-name "lightdm-mini-greeter")
> > >  (greeter-config-name "lightdm-mini-greeter.conf")
> > >  (config (list "[greeter]"
> > >  "user = guest"
> > >  "[greeter-hotkeys]"
> > >  "mod-key = control"
> > >  "session-key = e")))
> > >  (lightdm-greeter-general-configuration
> > >  (greeter-package (customize-lightdm-tiny-greeter #:session "icewm"))
> > >  (greeter-session-name "lightdm-tiny-greeter")
> > >  (greeter-config-name "lightdm-tiny-greeter.conf")
> > >  (config (list "## Lightdm-mini-greeter have no config, ignore it!")))
> > >  (lightdm-greeter-general-configuration)
> > >  (lightdm-gtk-greeter-configuration
> > >  (lightdm-gtk-greeter lightdm-gtk-greeter-gee)
> > >  (extra-config
> > >  (list "font-name = San 10"
> > >  "icon-size = 64"
> > >  "xft-dpi = 140"
> > >  "clock-format = %Y-%m-%d %H:%M"
> > >  ;; We need to use "~~" to generate a tilde, for
> > >  ;; extra-config sting will be handle as
> > >  ;; control-string of format function.
> > >  "indicators = ~~host;~~spacer;~~session;~~a11y;~~clock;~~power")))))
> > >  (seats
> > >  (list (lightdm-seat-configuration
> > >  (name "*")
> > >  (greeter-session 'lightdm-tiny-greeter))))
> > >  
> > >  (xorg-configuration
> > >  (xorg-configuration
> > >  ;; The QXL virtual GPU driver is added to provide a better
> > >  ;; SPICE experience.
> > >  (modules (cons xf86-video-qxl
> > >  %default-xorg-modules))
> > >  (keyboard-layout keyboard-layout)
> > >  (server-arguments
> > >  (append %default-xorg-server-arguments
> > >  '("-dpi" "140")))))))
> > >  
> > >  ```
> > >  
> > >  --
> > >
> > 
> --
>


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-01-09 13:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-08  1:39 lightdm updates need to review Feng Shu
2025-01-08 13:44 ` jbranso
2025-01-08 22:00   ` Feng Shu
2025-01-09 13:33     ` jbranso

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.