From: "Ludovic Courtès" <ludo@gnu.org>
To: Karl Hallsby <karl@hallsby.com>
Cc: 72249@debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: [bug#72249] [PATCH 2/2] services: Add xe-guest-utilities-service-type.
Date: Thu, 09 Jan 2025 14:45:00 +0100 [thread overview]
Message-ID: <87plkwp0df.fsf@gnu.org> (raw)
In-Reply-To: <05dbe98e7be3b45ddbf4a49df643e35333df78e7.1736366732.git.karl@hallsby.com> (Karl Hallsby's message of "Wed, 8 Jan 2025 14:10:26 -0600")
Hello,
Karl Hallsby <karl@hallsby.com> skribis:
> * gnu/services/virtualization.scm (xe-guest-utilities-configuration,
> xe-guest-utilities-service-type): New variables.
> * doc/guix.texi: Document them.
>
> Change-Id: Ife4e79fa6d1a9d5a21bf7479488884f2a5cf8d56
I’m only looking at the doc side of things. Minor comments:
> +@cindex xen
> +@cindex xen guest agent
“Xen”, capitalized.
> +The Xen guest agent allows a Xen host to control the emulated system.
> +The @code{xe-guest-utilities} service runs the agent on Guix guests.
I’m surprised it’s all “xe-”, not “xen-”, but I guess that’s the way it
is. :-)
It would be nice to add a sentence or two about what said utilities do,
perhaps with a link to upstream documentation if that helps?
> +@item @code{log-file} (default: @code{"/var/log/xe-guest-utilities.log"})
> +Path to @code{xe-guest-utilities} log file.
“Name of the @code{xe-guest-utilities} log file.”
(We use the term “path” for “search paths”.)
Apart from that LGTM!
Thanks,
Ludo’.
prev parent reply other threads:[~2025-01-09 13:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 5:14 [bug#72249] [PATCH 0/2] Add xe-guest-utilities and daemon Karl Hallsby via Guix-patches via
2024-07-23 5:22 ` [bug#72249] [PATCH 1/2] gnu: Add xe-guest-utilities Karl Hallsby via Guix-patches via
2024-07-23 5:22 ` [bug#72249] [PATCH 2/2] services: Add xe-guest-utilities-service-type Karl Hallsby via Guix-patches via
2025-01-08 20:10 ` [bug#72249] [PATCH 1/2] gnu: Add xe-guest-utilities Karl Hallsby via Guix-patches via
2025-01-08 20:10 ` [bug#72249] [PATCH 2/2] services: Add xe-guest-utilities-service-type Karl Hallsby via Guix-patches via
2025-01-09 13:45 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plkwp0df.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=72249@debbugs.gnu.org \
--cc=karl@hallsby.com \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.