[PATCH] distro: Add MIT Kerberos 5.

[PATCH] distro: Add MIT Kerberos 5.

[Andreas Enge]

[-- Attachment #1.1: Type: text/plain, Size: 63 bytes --]

Patch attached; if only more software were gnu style!

Andreas

[-- Attachment #1.2: Type: text/html, Size: 984 bytes --]

[-- Attachment #2: 0007-distro-Add-MIT-Kerberos-5.patch --]
[-- Type: text/x-patch, Size: 3930 bytes --]

From 3f69c32b403195337923f3d9f913cd271475105e Mon Sep 17 00:00:00 2001
From: Andreas Enge <andreas@enge.fr>
Date: Sun, 30 Dec 2012 00:08:46 +0100
Subject: [PATCH 7/7] distro: Add MIT Kerberos 5.

* distro/packages/mit-krb5.scm: New file.
* Makefile.am (MODULES): Add it.
---
 Makefile.am                  |    1 +
 distro/packages/mit-krb5.scm |   69 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 70 insertions(+)
 create mode 100644 distro/packages/mit-krb5.scm

diff --git a/Makefile.am b/Makefile.am
index 2726873..dd4f52f 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -81,6 +81,7 @@ MODULES =					\
   distro/packages/lsh.scm			\
   distro/packages/m4.scm			\
   distro/packages/make-bootstrap.scm		\
+  distro/packages/mit-krb5.scm			\
   distro/packages/multiprecision.scm		\
   distro/packages/nano.scm			\
   distro/packages/ncurses.scm			\
diff --git a/distro/packages/mit-krb5.scm b/distro/packages/mit-krb5.scm
new file mode 100644
index 0000000..1737e9a
--- /dev/null
+++ b/distro/packages/mit-krb5.scm
@@ -0,0 +1,69 @@
+;;; Guix --- Nix package management from Guile.         -*- coding: utf-8 -*-
+;;; Copyright (C) 2012 Andreas Enge <andreas@enge.fr>
+;;;
+;;; This file is part of Guix.
+;;;
+;;; Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (distro packages mit-krb5)
+  #:use-module (distro)
+  #:use-module (distro packages bison)
+  #:use-module (distro packages perl)
+  #:use-module (guix licenses)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu))
+
+(define-public mit-krb5
+  (package
+   (name "mit-krb5")
+   (version "1.11")
+   (source (origin
+            (method url-fetch)
+            (uri (string-append "http://web.mit.edu/kerberos/www/dist/krb5/"
+                                version
+                                "/krb5-" version
+                                "-signed.tar"))
+            (sha256 (base32
+                     "0lc6lxb98qzg4x01lppq700vkr1ax9rld09znahrinwqnf9zndzy"))))
+   (build-system gnu-build-system)
+   (inputs `(("bison" ,bison)
+             ("perl" ,perl)
+             ))
+   (arguments
+    (lambda (system)
+      `(#:tests? #f
+        #:phases
+        (alist-replace
+         'unpack
+         (lambda* (#:key source #:allow-other-keys)
+          (system* "echo" source)
+          (let ((inner
+                 (substring source
+                            (string-index-right source #\k)
+                            (string-index-right source #\-))))
+           (system* "echo" inner)
+           (and (zero? (system* "tar" "xvf" source))
+                (zero? (system* "tar" "xvf" (string-append inner ".tar.gz")))
+                (chdir inner)
+                (chdir "src"))))
+          %standard-phases))))
+   (synopsis "MIT Kerberos 5")
+   (description
+    "Massachusetts Institute of Technology implementation of Kerberos.
+Kerberos is a network authentication protocol designed to provide strong
+authentication for client/server applications by using secret-key cryptography.")
+   (license (bsd-style "file://NOTICE"
+                       "See NOTICE in the distribution."))
+   (home-page "http://web.mit.edu/kerberos/")))
-- 
1.7.10.4

Re: [PATCH] distro: Add MIT Kerberos 5.

[Nikita Karetnikov]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

> +      `(#:tests? #f

Ludo told me some time ago that it's necessary to write a comment when
you disable tests. It should explain why they were disabled.

Could you add it?

Nikita

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

Re: [PATCH] distro: Add MIT Kerberos 5.

[Andreas Enge]

[-- Attachment #1: Type: text/plain, Size: 1900 bytes --]

Am Sonntag, 30. Dezember 2012 schrieb Nikita Karetnikov:
> > +      `(#:tests? #f
> Ludo told me some time ago that it's necessary to write a comment when
> you disable tests. It should explain why they were disabled.

This is a mistake, thanks for spotting it!

Actually, the tests do fail with:
make[2]: Entering directory `/tmp/nix-build-mit-
krb5-1.11.drv-0/krb5-1.11/src/tests/resolve'
LD_LIBRARY_PATH=`echo -L../../lib | sed -e "s/-L//g" -e "s/ /:/g"`; export 
LD_LIBRARY_PATH;   ./resolve
Error looking up IP address
Hostname:  localhost
Host address: 127.0.0.1
FQDN: localhost
Resolve library appears to have passed the test
LD_LIBRARY_PATH=`echo -L../../lib | sed -e "s/-L//g" -e "s/ /:/g"`; export 
LD_LIBRARY_PATH;   ./addrinfo-test -p telnet
getaddrinfo(hostname (null), service telnet,
            hints { no-flags }):
        error => Servname not supported for ai_socktype
make[2]: *** [check] Error 1

In my non-guix environment, I obtain
privat@debian:/tmp/krb5-1.11/src/tests/resolve$ ./addrinfo-test -p telnet
getaddrinfo(hostname (null), service telnet,
            hints { no-flags }):
0x2109f40:
        family = AF_INET6       proto = TCP     socktype = STREAM
        addr = ::1                              port = 23
        getnameinfo => ip6-localhost, telnet
0x2109270:
        family = AF_INET        proto = TCP     socktype = STREAM
        addr = 127.0.0.1                        port = 23
        getnameinfo => localhost, telnet

I suppose the problem is that the telnet ports are not defined in guix; 
when I manually do
./addrinfo-test -p t
I obtain the same kind of error:
getaddrinfo(hostname (null), service t,
            hints { no-flags }):
        error => Servname not supported for ai_socktype

Instead of disabling all tests, one might patch the Makefile.in inside 
src/tests/resolve to not execute the telnet related tests.

What do you think?

Andreas

[-- Attachment #2: Type: text/html, Size: 9027 bytes --]

Re: [PATCH] distro: Add MIT Kerberos 5.

[Ludovic Courtès]

Hi,

Andreas Enge <andreas@enge.fr> skribis:

> Resolve library appears to have passed the test
> LD_LIBRARY_PATH=`echo -L../../lib | sed -e "s/-L//g" -e "s/ /:/g"`; export 
> LD_LIBRARY_PATH;   ./addrinfo-test -p telnet
> getaddrinfo(hostname (null), service telnet,
>             hints { no-flags }):
>         error => Servname not supported for ai_socktype

This is because this test relies on the presence of /etc/services when
looking up the “telnet” service by name (which is missing in chroots.)

Possibilities include:

  • patching the test avoid that (for instance, by changing ‘localhost’
    to ‘127.0.0.1’, ‘telnet’ by ‘23’, etc.), unless it would no longer
    make sense;

  • patching the test machinery to skip the test;

  • turning off all the tests, as a last resort, if they are all really
    network-dependent.

Any idea what would be the most relevant approach here?

HTH,
Ludo’.

Re: [PATCH] distro: Add MIT Kerberos 5.

[Andreas Enge]

[-- Attachment #1: Type: text/plain, Size: 746 bytes --]

Am Sonntag, 30. Dezember 2012 schrieb Ludovic Courtès:
> This is because this test relies on the presence of /etc/services when
> looking up the “telnet” service by name (which is missing in chroots.)
> Possibilities include:
>   • patching the test avoid that (for instance, by changing ‘localhost’
>     to ‘127.0.0.1’, ‘telnet’ by ‘23’, etc.), unless it would no longer
>     make sense;
>   • patching the test machinery to skip the test;
>   • turning off all the tests, as a last resort, if they are all really
>     network-dependent.
> Any idea what would be the most relevant approach here?

I think both of the first two approaches would work, while the third one 
should be avoided.

Andreas

[-- Attachment #2: Type: text/html, Size: 3405 bytes --]

Re: [PATCH] distro: Add MIT Kerberos 5.

[Andreas Enge]

[-- Attachment #1: Type: text/plain, Size: 510 bytes --]

Am Dienstag, 1. Januar 2013 schrieb Andreas Enge:
> Am Sonntag, 30. Dezember 2012 schrieb Ludovic Courtès:
> >   • patching the test avoid that (for instance, by changing
> >   ‘localhost’
> >     to ‘127.0.0.1’, ‘telnet’ by ‘23’, etc.), unless it would no longer
> >     make sense;
> 
> I think both of the first two approaches would work, while the third one
> should be avoided.

I just pushed a new version with tests, two of which needed additional 
patching.

Andreas


[-- Attachment #2: Type: text/html, Size: 3048 bytes --]

Re: [PATCH] distro: Add MIT Kerberos 5.

[Ludovic Courtès]

Andreas Enge <andreas@enge.fr> skribis:

> From 3f69c32b403195337923f3d9f913cd271475105e Mon Sep 17 00:00:00 2001
> From: Andreas Enge <andreas@enge.fr>
> Date: Sun, 30 Dec 2012 00:08:46 +0100
> Subject: [PATCH 7/7] distro: Add MIT Kerberos 5.
>
> * distro/packages/mit-krb5.scm: New file.
> * Makefile.am (MODULES): Add it.
> ---
>  Makefile.am                  |    1 +
>  distro/packages/mit-krb5.scm |   69 ++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 70 insertions(+)
>  create mode 100644 distro/packages/mit-krb5.scm

Applied, thanks!

> +        #:phases
> +        (alist-replace
> +         'unpack
> +         (lambda* (#:key source #:allow-other-keys)
> +          (system* "echo" source)
> +          (let ((inner
> +                 (substring source
> +                            (string-index-right source #\k)
> +                            (string-index-right source #\-))))
> +           (system* "echo" inner)
> +           (and (zero? (system* "tar" "xvf" source))
> +                (zero? (system* "tar" "xvf" (string-append inner ".tar.gz")))
> +                (chdir inner)
> +                (chdir "src"))))
> +          %standard-phases))))

... and congrats on finding out the right tricks.  ;-)

Ludo’.