From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: The new patch method and mit-krb5 Date: Wed, 30 Oct 2013 19:15:32 +0100 Message-ID: <87ob66iq0r.fsf@gnu.org> References: <87zjprpr1h.fsf@netris.org> <877gcukc01.fsf@gnu.org> <20131030162016.GA16421@debian> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbaIv-0001r4-8m for guix-devel@gnu.org; Wed, 30 Oct 2013 14:15:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VbaIp-00013x-4I for guix-devel@gnu.org; Wed, 30 Oct 2013 14:15:41 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:24421) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbaIo-00013o-Tp for guix-devel@gnu.org; Wed, 30 Oct 2013 14:15:35 -0400 In-Reply-To: <20131030162016.GA16421@debian> (Andreas Enge's message of "Wed, 30 Oct 2013 17:20:16 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andreas Enge Cc: guix-devel@gnu.org Andreas Enge skribis: > On Wed, Oct 30, 2013 at 04:35:26PM +0100, Ludovic Court=C3=A8s wrote: >> The new method won=E2=80=99t work in this case. >> Thus, the patch has to be applied manually with > > Alternatively, could we modify > (guix packages patch-and-repack) > so that instead of calling "tar" directly, it executes the phase named 'u= npack > of the package? After that, it would apply the patches and repackage. The notion of phases is internal to the build system, so we can=E2=80=99t r= eally do that. What we could do is to add a =E2=80=98snippet=E2=80=99 field in wh= ere users could provide an expression to use as the patch phase. > This would be more flexible. For instance, we could use it to derive a ud= ev > source tarball out of the systemd sources, which would then be returned v= ia > guix build udev -S Nice example. ;-) Though I suppose this case is easily addressed with just (chdir "udev") or something similar no? Ludo=E2=80=99.