From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: add libglade
Date: Fri, 28 Feb 2014 21:09:41 +0100
Message-ID: <87ob1ryp6i.fsf@gnu.org>
References: <38aed3a0611cb51be3edf81cbbef1677.squirrel@fruiteater.riseup.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40482)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1WJTki-0004hF-Mk
	for guix-devel@gnu.org; Fri, 28 Feb 2014 15:09:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1WJTkd-0002QJ-W0
	for guix-devel@gnu.org; Fri, 28 Feb 2014 15:09:48 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:39180)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1WJTkd-0002Q9-PG
	for guix-devel@gnu.org; Fri, 28 Feb 2014 15:09:43 -0500
In-Reply-To: <38aed3a0611cb51be3edf81cbbef1677.squirrel@fruiteater.riseup.net>
	(ggrant@riseup.net's message of "Thu, 27 Feb 2014 15:56:07 -0800")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: ggrant@riseup.net
Cc: guix-devel@gnu.org

ggrant@riseup.net skribis:

> Hoping to gradually get back into packaging some stuff of interest. Here's
> libglade for now, if anything looks wrong be sure to let me know. :^)

OK, so here=E2=80=99s a proper review, on the assumption that it=E2=80=99s =
needed.

> From 58b053edfabd89b5c9da034b295791ceb1cf1281 Mon Sep 17 00:00:00 2001
> From: Guy Grant <ggrant@riseup.net>
> Date: Thu, 27 Feb 2014 17:46:06 -0600
> Subject: [PATCH] gnu: Add libglade

Please add a proper commit log.

> +(define-public libglade
> +  (package
> +    (name "libglade")
> +    (version "2.6.4")
> +    (source (origin
> +             (method url-fetch)
> +             (uri (string-append
> +                   "http://ftp.gnome.org/pub/GNOME/sources/libglade/2.6/=
libglade-"
> +                   version
> +                   ".tar.gz"))

Use mirror://gnome.

> +    (synopsis "Allows you to load glade interface files in a program at =
runtime")

Rather something like =E2=80=9CLoad GTK+2 Glade interface files at run time=
=E2=80=9D, WDYT?

> +    (description
> +     "Libglade is a library that provides interfaces for loading graphic=
al interfaces=20
> +described in glade xml files and for accessing the widgets built in the =
loading process,=20
> +.glade files are generated by the Glade application.")
> +    (license license:lgpl2.0)))

I guess it=E2=80=99s v2.0-or-any-later-version, no?  (Or even 2.1.)  Could =
you
check that?  If that is the case, then use license:lgpl2.0+.

Could you send an updated patch?

Thanks!

Ludo=E2=80=99.