From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: guix.el: Key bindings for a "package list" Date: Sat, 06 Sep 2014 12:17:03 +0400 Message-ID: <87oaut5fk0.fsf@gmail.com> References: <87a96e7bu3.fsf@gmail.com> <87wq9ifn49.fsf@taylan.uni.cx> <87zjee5jlj.fsf@gmail.com> <87y4txu86l.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37353) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQBBI-0000Ii-Et for guix-devel@gnu.org; Sat, 06 Sep 2014 04:17:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XQBB9-0005uJ-Be for guix-devel@gnu.org; Sat, 06 Sep 2014 04:17:12 -0400 In-Reply-To: <87y4txu86l.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Fri, 05 Sep 2014 22:24:50 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s (2014-09-06 00:24 +0400) wrote: > BTW, M-x list-packages lists installed packages at the bottom, and with > a different face. > > What about doing something similar for guix-newest-available-packages & c= o.? No objection for a face, but I don't think such sorting should be the default one. I think it is done in "package.el" just because there is no way to display only installed or obsolete packages there. But as in "guix.el" we have "M-x guix-installed-packages" and "M-x guix-obsolete-packages", in my opinion it would be better to leave the current sorting by name. Besides a user can easily sort a list by "Installed" column if he wants. But of course if most people find such sort preferable, I will comply. Here is the patch for a new face. OK to push? (I'm never sure in a commit message). --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-emacs-Add-a-face-for-installed-packages.patch >From eafaf96cf86eb353aa414da6773254aca648e260 Mon Sep 17 00:00:00 2001 From: Alex Kost Date: Sat, 6 Sep 2014 12:08:42 +0400 Subject: [PATCH] emacs: Add a face for installed packages. * emacs/guix-list.el (guix-package-list-installed): New face. (guix-package-list-get-name): Use it. --- emacs/guix-list.el | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/emacs/guix-list.el b/emacs/guix-list.el index 0460d20..08fb3cb 100644 --- a/emacs/guix-list.el +++ b/emacs/guix-list.el @@ -448,6 +448,11 @@ This macro defines the following functions: (upgrade . ?U) (delete . ?D))) +(defface guix-package-list-installed + '((t :inherit guix-package-info-installed-outputs)) + "Face used if there are installed outputs for the current package." + :group 'guix-package-list) + (defface guix-package-list-obsolete '((t :inherit guix-package-info-obsolete)) "Face used if a package is obsolete." @@ -478,10 +483,13 @@ likely)." (defun guix-package-list-get-name (name entry) "Return NAME of the package ENTRY. -Colorize it with `guix-package-list-obsolete' if needed." +Colorize it with `guix-package-list-installed' or +`guix-package-list-obsolete' if needed." (guix-get-string name - (when (guix-get-key-val entry 'obsolete) - 'guix-package-list-obsolete))) + (cond ((guix-get-key-val entry 'obsolete) + 'guix-package-list-obsolete) + ((guix-get-key-val entry 'installed) + 'guix-package-list-installed)))) (defun guix-package-list-get-installed-outputs (installed &optional _) "Return string with outputs from INSTALLED entries." -- 2.1.0 --=-=-=--