From: Eric Bavier <ericbavier@gmail.com>
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 4/5] guix: lint: Check for empty synopses and descriptions.
Date: Sat, 25 Oct 2014 11:14:35 -0500 [thread overview]
Message-ID: <87oat0xh1w.fsf@gmail.com> (raw)
In-Reply-To: <544A3EAD.3020205@gmail.com>
Cyril Roelandt writes:
> On 10/24/2014 07:06 AM, Eric Bavier wrote:
>> From 94794a8cb470238f60db977b7640202517d379c4 Mon Sep 17 00:00:00 2001
>> From: Eric Bavier <bavier@member.fsf.org>
>> Date: Wed, 22 Oct 2014 13:48:55 -0500
>> Subject: [PATCH 4/5] guix: lint: Check for empty synopses and descriptions.
>>
>> * guix/scripts/lint.scm (check-description-style,
>> check-synopsis-style): New emptiness checks.
>> * tests/lint.scm: Test them.
>> ---
>> guix/scripts/lint.scm | 14 ++++++++++++++
>> tests/lint.scm | 18 ++++++++++++++++++
>> 2 files changed, 32 insertions(+)
>
>
> Should we also check for descriptions that are just #f ? There are a few
> valid cases, but in general, it's an issue. WDYT ?
We may want to. I think what we're trying to catch is the case where a
developer initially put a placeholder in, but might have forgotten to go
back fill the field in with a proper string. Depending on the
developer's taste, the placeholder might be an empty string, or #f.
I'll try out the #f check, and see if it runs into any problems.
--
Eric Bavier
Please avoid sending me Word or PowerPoint attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html
prev parent reply other threads:[~2014-10-25 16:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 5:06 [PATCH 4/5] guix: lint: Check for empty synopses and descriptions Eric Bavier
2014-10-24 11:57 ` Cyril Roelandt
2014-10-25 16:14 ` Eric Bavier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oat0xh1w.fsf@gmail.com \
--to=ericbavier@gmail.com \
--cc=guix-devel@gnu.org \
--cc=tipecaml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.