Re: [PATCH] gnu: Add slock.

[David Thompson <dthompson2@worcester.edu>]

Tomáš Čech <sleep_walker@suse.cz> writes:

> * gnu/packages/dwm.scm (slock): New variable.
> ---
>  gnu/packages/dwm.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>
> diff --git a/gnu/packages/dwm.scm b/gnu/packages/dwm.scm
> index 88758f2..2db2010 100644
> --- a/gnu/packages/dwm.scm
> +++ b/gnu/packages/dwm.scm
> @@ -112,3 +112,31 @@ state.")
>       "A dynamic menu for X, originally designed for dwm.  It manages large
>  numbers of user-defined menu items efficiently.")
>      (license x11)))
> +
> +(define-public slock
> +  (package
> +    (name "slock")
> +    (version "1.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://dl.suckless.org/tools/slock-"
> +                                  version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "1r70s3npmp0nyrfdsxz8cw1i1z8n9phqdlw02wjphv341h3yajp0"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     '(#:tests? #f

Please explain why tests are disabled with a comment.

> +       #:make-flags (list "CC=gcc"
> +                          (string-append "PREFIX=" %output))
> +       #:phases
> +       (alist-delete 'configure %standard-phases)))

A nitpick, but I think it looks better if there isn't a newline between
this and #:phases.

> +    (inputs
> +     `(("libx11" ,libx11)
> +       ("libxext" ,libxext)
> +       ("libxinerama" ,libxinerama)))
> +    (home-page "http://tools.suckless.org/slock/")
> +    (synopsis "Simple X session lock")
> +    (description
> +     "Simple X session lock with trivial feedback on password entry.")
> +    (license x11)))
> -- 
> 2.0.4
>
>

Looking good to me!  Thanks!

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate