From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 3/4] import: cpan: Use corelist to filter dependencies.
Date: Sat, 14 Feb 2015 00:15:22 +0100
Message-ID: <87oaox1jzp.fsf@gnu.org>
References: <1423756695-13378-1-git-send-email-bavier@member.fsf.org>
	<1423756695-13378-4-git-send-email-bavier@member.fsf.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38779)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YMPSU-0006sU-1e
	for guix-devel@gnu.org; Fri, 13 Feb 2015 18:15:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YMPSO-00006N-SR
	for guix-devel@gnu.org; Fri, 13 Feb 2015 18:15:37 -0500
In-Reply-To: <1423756695-13378-4-git-send-email-bavier@member.fsf.org> (Eric
	Bavier's message of "Thu, 12 Feb 2015 09:58:14 -0600")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Eric Bavier <bavier@member.fsf.org>
Cc: guix-devel@gnu.org

Eric Bavier <bavier@member.fsf.org> skribis:

> * guix/import/cpan.scm (%corelist): New variable.
>   (module->dist-name, core-module?): New procedures.
>   (cpan-module->sexp)[convert-inputs]: Use them.  Include "test" dependen=
cies
>   in converted inputs.
> * doc/guix.texi (Invoking guix import)[cpan]: Mention corelist filtering.

[...]

> +(define %corelist
> +  (let* ((perl (with-store store
> +                 (derivation->output-path
> +                  (package-derivation store perl))))
> +         (core (string-append perl "/bin/corelist")))
> +    (and (access? core X_OK)
> +         core)))

What about adding:

  (warning (_ "the 'corelist' command is unavailable, not filtering modules=
~%"))

?

Or perhaps it would be even better to take it from $PATH, otherwise the
situation could be confusing: even if Perl is installed, the user could
get an =E2=80=9Cunavailable=E2=80=9D warning just because it=E2=80=99s not =
the exact same Perl.

WDYT?

Thanks,
Ludo=E2=80=99.