From: ludo@gnu.org (Ludovic Courtès)
To: Eric Bavier <bavier@member.fsf.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 3/4] import: cpan: Use corelist to filter dependencies.
Date: Sat, 14 Feb 2015 00:15:22 +0100 [thread overview]
Message-ID: <87oaox1jzp.fsf@gnu.org> (raw)
In-Reply-To: <1423756695-13378-4-git-send-email-bavier@member.fsf.org> (Eric Bavier's message of "Thu, 12 Feb 2015 09:58:14 -0600")
Eric Bavier <bavier@member.fsf.org> skribis:
> * guix/import/cpan.scm (%corelist): New variable.
> (module->dist-name, core-module?): New procedures.
> (cpan-module->sexp)[convert-inputs]: Use them. Include "test" dependencies
> in converted inputs.
> * doc/guix.texi (Invoking guix import)[cpan]: Mention corelist filtering.
[...]
> +(define %corelist
> + (let* ((perl (with-store store
> + (derivation->output-path
> + (package-derivation store perl))))
> + (core (string-append perl "/bin/corelist")))
> + (and (access? core X_OK)
> + core)))
What about adding:
(warning (_ "the 'corelist' command is unavailable, not filtering modules~%"))
?
Or perhaps it would be even better to take it from $PATH, otherwise the
situation could be confusing: even if Perl is installed, the user could
get an “unavailable” warning just because it’s not the exact same Perl.
WDYT?
Thanks,
Ludo’.
next prev parent reply other threads:[~2015-02-13 23:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 15:58 [PATCH 0/4] Perl build system and importer Eric Bavier
2015-02-12 15:58 ` [PATCH 1/4] build-system/perl: Use Build.PL for builds if present Eric Bavier
2015-02-13 23:07 ` Ludovic Courtès
2015-02-12 15:58 ` [PATCH 2/4] guix: licenses: Add Artistic 2.0 license Eric Bavier
2015-02-13 23:07 ` Ludovic Courtès
2015-02-12 15:58 ` [PATCH 3/4] import: cpan: Use corelist to filter dependencies Eric Bavier
2015-02-13 23:15 ` Ludovic Courtès [this message]
2015-02-14 2:46 ` Eric Bavier
2015-02-23 20:49 ` Ludovic Courtès
2015-02-12 15:58 ` [PATCH 4/4] import: cpan: Sort inputs, use mirror url, adjust licenses Eric Bavier
2015-02-13 23:17 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oaox1jzp.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=bavier@member.fsf.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.