From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add libsbsms.
Date: Wed, 25 Feb 2015 15:03:57 +0100
Message-ID: <87oaoiw0j6.fsf@gnu.org>
References: <87lhjqluob.fsf@taylan.uni.cx> <878ufqluj0.fsf@taylan.uni.cx>
	<87fv9u9b1x.fsf@gnu.org> <87oaoi7v1u.fsf@taylan.uni.cx>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49926)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YQcZI-00013f-Q1
	for guix-devel@gnu.org; Wed, 25 Feb 2015 09:04:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YQcZE-0006JU-4g
	for guix-devel@gnu.org; Wed, 25 Feb 2015 09:04:04 -0500
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37160)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YQcZE-0006JP-1l
	for guix-devel@gnu.org; Wed, 25 Feb 2015 09:04:00 -0500
In-Reply-To: <87oaoi7v1u.fsf@taylan.uni.cx> ("Taylan Ulrich
	\=\?utf-8\?Q\?\=5C\=22Bay\=C4\=B1rl\=C4\=B1\=2FKammer\=5C\=22\=22's\?\=
	message of "Wed, 25 Feb 2015 00:23:57 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Taylan Ulrich =?utf-8?Q?=22Bay=C4=B1rl=C4=B1?=
	=?utf-8?Q?=2FKammer=22?= <taylanbayirli@gmail.com>
Cc: guix-devel@gnu.org

taylanbayirli@gmail.com (Taylan Ulrich "Bay=C4=B1rl=C4=B1/Kammer") skribis:

> ludo@gnu.org (Ludovic Court=C3=A8s) writes:
>
>>> +        (lambda* (#:key inputs #:allow-other-keys)
>>> +          ;; Originally a symlink to '/usr/local/share/automake-1.12/a=
r-lib'.
>>> +          (delete-file "ar-lib")
>>> +          (symlink
>>> +           (string-append (assoc-ref inputs "automake") "/share/automa=
ke-"
>>> +                          ,(package-version automake) "/ar-lib")
>>> +           "ar-lib"))
>>
>> I think it could just run =E2=80=9Cautomake --add-missing=E2=80=9D inste=
ad, which is
>> lightly more elegant and future-proof.
>
> That seems to lead to:
>
> configure.ac:119: error: version mismatch.  This is Automake 1.15,
> configure.ac:119: but the definition used by this AM_INIT_AUTOMAKE
> configure.ac:119: comes from Automake 1.12.  You should recreate
> configure.ac:119: aclocal.m4 with aclocal and run automake again.
> configure.ac:119: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and=
 its use is discouraged.
> configure.ac:119: You should use the Autoconf-provided 'AC_PROG_MKDIR_P' =
macro instead,
> configure.ac:119: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your Mak=
efile.am files.
> configure.ac:39: installing './ar-lib'
>
> It works if I just run 'autoreconf -vif'.  Is that fine?
>
> I have to additionally add autoconf and libtool as inputs for that by
> the way.

Yes, which is a bit wasteful.

In that case your initial solution is better IMO.

OK to push it, then!

Thank you,
Ludo=E2=80=99.