From mboxrd@z Thu Jan  1 00:00:00 1970
From: taylanbayirli@gmail.com (Taylan Ulrich =?utf-8?Q?Bay=C4=B1rl=C4=B1?=
	=?utf-8?Q?=2FKammer?=)
Subject: Re: [PATCH] gnu: Add libsbsms.
Date: Wed, 25 Feb 2015 00:23:57 +0100
Message-ID: <87oaoi7v1u.fsf@taylan.uni.cx>
References: <87lhjqluob.fsf@taylan.uni.cx> <878ufqluj0.fsf@taylan.uni.cx>
	<87fv9u9b1x.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39974)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <taylanbayirli@gmail.com>) id 1YQOpj-0003ox-6r
	for guix-devel@gnu.org; Tue, 24 Feb 2015 18:24:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <taylanbayirli@gmail.com>) id 1YQOpd-0004Nw-FU
	for guix-devel@gnu.org; Tue, 24 Feb 2015 18:24:07 -0500
In-Reply-To: <87fv9u9b1x.fsf@gnu.org> ("Ludovic
	\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
	\=\?utf-8\?Q\?s\?\= message of "Tue, 24 Feb 2015 23:52:58 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

ludo@gnu.org (Ludovic Court=C3=A8s) writes:

>> +        (lambda* (#:key inputs #:allow-other-keys)
>> +          ;; Originally a symlink to '/usr/local/share/automake-1.12/ar=
-lib'.
>> +          (delete-file "ar-lib")
>> +          (symlink
>> +           (string-append (assoc-ref inputs "automake") "/share/automak=
e-"
>> +                          ,(package-version automake) "/ar-lib")
>> +           "ar-lib"))
>
> I think it could just run =E2=80=9Cautomake --add-missing=E2=80=9D instea=
d, which is
> lightly more elegant and future-proof.

That seems to lead to:

configure.ac:119: error: version mismatch.  This is Automake 1.15,
configure.ac:119: but the definition used by this AM_INIT_AUTOMAKE
configure.ac:119: comes from Automake 1.12.  You should recreate
configure.ac:119: aclocal.m4 with aclocal and run automake again.
configure.ac:119: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and i=
ts use is discouraged.
configure.ac:119: You should use the Autoconf-provided 'AC_PROG_MKDIR_P' ma=
cro instead,
configure.ac:119: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your Makef=
ile.am files.
configure.ac:39: installing './ar-lib'

It works if I just run 'autoreconf -vif'.  Is that fine?

I have to additionally add autoconf and libtool as inputs for that by
the way.

The final result would be:


  (arguments
   `(#:phases
     ;; Do this right after unpack because there's a danling symlink to
     ;; '/usr/local/share/automake-1.12/ar-lib' which causes a "no such
     ;; file or directory" during shebang patching.
     (alist-cons-after
      'unpack 'autoreconf
      (lambda* (#:key inputs #:allow-other-keys)
        (zero? (system* "autoreconf" "-vif")))
      %standard-phases)))


Taylan