From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: Bugs in parsing build options
Date: Thu, 26 Feb 2015 00:05:43 +0100
Message-ID: <87oaoh1tiw.fsf@gnu.org>
References: <CAJ41eeyECrUPfEhS+9puU3y0iczEeCs8JgKB8RnTRofVNOW_4w@mail.gmail.com>
	<CAJ41eewKNWaw8ufRS3N6CdrK7j=isv7LKhSh3J0oUVSv8DxBUA@mail.gmail.com>
	<87fvcszuno.fsf@gnu.org> <87bnkopawy.fsf_-_@gmail.com>
	<87oaoj7wu0.fsf@gnu.org> <871tlegiot.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49876)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YQl1h-0005CF-QR
	for guix-devel@gnu.org; Wed, 25 Feb 2015 18:05:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YQl1c-0001nU-RG
	for guix-devel@gnu.org; Wed, 25 Feb 2015 18:05:57 -0500
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54021)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YQl1c-0001nQ-Ny
	for guix-devel@gnu.org; Wed, 25 Feb 2015 18:05:52 -0500
In-Reply-To: <871tlegiot.fsf@gmail.com> (Alex Kost's message of "Wed, 25 Feb
	2015 17:38:26 +0300")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org

Alex Kost <alezost@gmail.com> skribis:

> Suppose a user specifies "--no-substitutes" in his GUIX_BUILD_OPTIONS
> and then he calls "guix system reconfigure".  What would happen?
> Substitutes _will be used_ anyway, because:
> =E2=80=98(parse-options-from args)=E2=80=99 will contain =E2=80=98(substi=
tutes? . #t)=E2=80=99 among
> other things and it will shadow the false value for substitutes returned
> by =E2=80=98(parse-options-from (environment-build-options))=E2=80=99.
>
> Now (after your patch) the same will happen with "--no-grub":
> =E2=80=9Cexport GUIX_BUILD_OPTIONS=3D--no-grub=E2=80=9D will not be honor=
ed unless a user
> explicitly specifies "--no-grub" option one more time in a "guix system"
> command.

Oh, that=E2=80=99s right.  AFAICS, commit cf6ce3e fixes it.

It was a good opportunity to factorize all that and to add tests.

Thanks!

Ludo=E2=80=99.