From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Add cutadapt.
Date: Tue, 24 Mar 2015 22:00:19 +0100 [thread overview]
Message-ID: <87oaniyuu4.fsf@gnu.org> (raw)
In-Reply-To: <idjh9tfd7e9.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's message of "Fri, 20 Mar 2015 16:18:38 +0100")
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
> From 18a14112b6e22248638d2b34e1c1b935e1bcd343 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Fri, 20 Mar 2015 16:17:55 +0100
> Subject: [PATCH] gnu: Add cutadapt.
>
> * gnu/packages/bioinformatics.scm (cutadapt): New variable.
[...]
> + (setenv "PYTHONPATH"
> + (string-append
> + (getenv "PYTHONPATH")
> + ":" (assoc-ref outputs "out")
> + "/lib/python"
> + ,(version-major+minor (package-version python))
> + "/site-packages"))
It’s best to check the Python version on the build side, using something
like ‘get-python-version’ from python-build-system.scm (so that if
someone inherits this package and changes the Python that is used it
still works.)
Other than that LGTM!
Ludo’.
next prev parent reply other threads:[~2015-03-24 21:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 15:18 [PATCH] Add cutadapt Ricardo Wurmus
2015-03-24 21:00 ` Ludovic Courtès [this message]
2015-03-31 15:41 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oaniyuu4.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.