From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: [PATCH 1/3] gnu: Add ruby-git. Date: Mon, 15 Jun 2015 16:32:20 -0400 Message-ID: <87oakghfvv.fsf@netris.org> References: <87wpz7u7qg.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> <87a8w0ius3.fsf@netris.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4b3Z-0002AX-Qs for guix-devel@gnu.org; Mon, 15 Jun 2015 16:32:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z4b3V-0006Pf-R3 for guix-devel@gnu.org; Mon, 15 Jun 2015 16:32:33 -0400 Received: from world.peace.net ([50.252.239.5]:56560) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4b3V-0006Pb-OU for guix-devel@gnu.org; Mon, 15 Jun 2015 16:32:29 -0400 In-Reply-To: (David Thompson's message of "Mon, 15 Jun 2015 16:28:53 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: "Thompson, David" Cc: guix-devel "Thompson, David" writes: > On Mon, Jun 15, 2015 at 4:25 PM, Mark H Weaver wrote: >> It would be good to rewrite the references to the 'git' binary in the >> code to use an absolute path. This argues for making 'git' a normal >> input. What do you think? > > I was conflicted about this when packaging so I didn't touch it. The > git binary is a configurable variable here, and I believe it defaults > to 'git'. I could try to patch the default value of it to be an > absolute path to git in the store, if you think that is reasonable. Sure, sounds like the right approach to me. Thanks, Mark