* [PATCH] Update enlightenment.scm: Add Rage Player
@ 2015-08-05 13:38 Daniel Pimentel
2015-08-05 13:59 ` Thompson, David
2015-08-05 14:11 ` Ricardo Wurmus
0 siblings, 2 replies; 12+ messages in thread
From: Daniel Pimentel @ 2015-08-05 13:38 UTC (permalink / raw)
To: guix-devel
[-- Attachment #1: Type: text/plain, Size: 88 bytes --]
Patch that Add Rage player to enlightenment.scm.
Thanks,
--
Daniel Pimentel (d4n1 3:)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0003-gnu-enlightenment-Add-Rage-player.patch --]
[-- Type: text/x-diff; name=0003-gnu-enlightenment-Add-Rage-player.patch, Size: 1619 bytes --]
From 6219eee540bc2015f2a8eb8d397488dfef76a3c4 Mon Sep 17 00:00:00 2001
From: Daniel Pimentel <d4n1@member.fsf.org>
Date: Wed, 5 Aug 2015 10:35:11 -0300
Subject: [PATCH 3/3] gnu: enlightenment: Add Rage player *
gnu/packages/enlightenment.scm: Add Rage 0.1.4.
---
gnu/packages/enlightenment.scm | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/gnu/packages/enlightenment.scm b/gnu/packages/enlightenment.scm
index 28757f9..5aa6525 100644
--- a/gnu/packages/enlightenment.scm
+++ b/gnu/packages/enlightenment.scm
@@ -237,6 +237,31 @@ URL and local path detection, themes, popup based content viewer for non-text
contents and more.")
(license license:bsd-2)))
+(define-public rage
+ (package
+ (name "rage")
+ (version "0.1.4")
+ (source (origin
+ (method url-fetch)
+ (uri
+ (string-append
+ "http://download.enlightenment.org/rel/apps/rage/rage-"
+ version ".tar.gz"))
+ (sha256
+ (base32 "10j3n8crk16jzqz2hn5djx6vms5f6x83qyiaphhqx94h9dgv2mgg"))))
+ (build-system gnu-build-system)
+ (native-inputs
+ `(("pkg-config" ,pkg-config)))
+ (inputs
+ `(("efl" ,efl)
+ ("elementary" ,elementary)))
+ (home-page "http://www.enlightenment.org")
+ (synopsis "Powerful video play based on EFL")
+ (description
+ "Rage is a video and audio player written with Enlightenment Foundation Libraries
+with some extra bells and whistles.")
+ (license license:bsd-2)))
+
(define-public enlightenment
(package
(name "enlightenment")
--
2.4.3
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] Update enlightenment.scm: Add Rage Player
2015-08-05 13:38 [PATCH] Update enlightenment.scm: Add Rage Player Daniel Pimentel
@ 2015-08-05 13:59 ` Thompson, David
2015-08-05 14:08 ` Daniel Pimentel
2015-08-05 14:11 ` Ricardo Wurmus
1 sibling, 1 reply; 12+ messages in thread
From: Thompson, David @ 2015-08-05 13:59 UTC (permalink / raw)
To: Daniel Pimentel; +Cc: guix-devel
On Wed, Aug 5, 2015 at 9:38 AM, Daniel Pimentel <d4n1@openmailbox.org> wrote:
> Patch that Add Rage player to enlightenment.scm.
This is the third thread about this. In the future, could you keep
the discussion in a single thread?
Thanks for your contribution!
- Dave
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Update enlightenment.scm: Add Rage Player
2015-08-05 13:59 ` Thompson, David
@ 2015-08-05 14:08 ` Daniel Pimentel
0 siblings, 0 replies; 12+ messages in thread
From: Daniel Pimentel @ 2015-08-05 14:08 UTC (permalink / raw)
To: Thompson, David; +Cc: guix-devel, guix-devel-bounces+d4n1=opmbx.org
On 2015-08-05 10:59, Thompson, David wrote:
> On Wed, Aug 5, 2015 at 9:38 AM, Daniel Pimentel <d4n1@openmailbox.org>
> wrote:
>> Patch that Add Rage player to enlightenment.scm.
>
> This is the third thread about this. In the future, could you keep
> the discussion in a single thread?
>
> Thanks for your contribution!
>
> - Dave
I'm sorry Thompson and Guixs,
next patches/discussion I'll keep in a single thread.
Thanks,
--
Daniel Pimentel (d4n1 3:)
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Update enlightenment.scm: Add Rage Player
2015-08-05 13:38 [PATCH] Update enlightenment.scm: Add Rage Player Daniel Pimentel
2015-08-05 13:59 ` Thompson, David
@ 2015-08-05 14:11 ` Ricardo Wurmus
2015-08-05 14:27 ` Daniel Pimentel
1 sibling, 1 reply; 12+ messages in thread
From: Ricardo Wurmus @ 2015-08-05 14:11 UTC (permalink / raw)
To: Daniel Pimentel; +Cc: guix-devel
Hi Daniel,
unfortunately, the commit message is still not correct. It’s all on one
line and “gnu: enlightenment:” should be “gnu:” instead. If you use
“git commit” without “-m” you can edit the message in your default
editor (configurable by setting the EDITOR variable).
> +(define-public rage
> + (package
> + (name "rage")
> + (version "0.1.4")
> + (source (origin
> + (method url-fetch)
> + (uri
> + (string-append
> + "http://download.enlightenment.org/rel/apps/rage/rage-"
> + version ".tar.gz"))
> + (sha256
> + (base32 "10j3n8crk16jzqz2hn5djx6vms5f6x83qyiaphhqx94h9dgv2mgg"))))
> + (build-system gnu-build-system)
> + (native-inputs
> + `(("pkg-config" ,pkg-config)))
> + (inputs
> + `(("efl" ,efl)
> + ("elementary" ,elementary)))
> + (home-page "http://www.enlightenment.org")
The home page for “rage” actually seems to be
https://www.enlightenment.org/about-rage
> + (synopsis "Powerful video play based on EFL")
“video play” –> “video player”. Not sure if “Powerful” is a good word
for a synopsis. What makes it powerful? If this cannot be expressed
within the limited space of a synopsis it should be omitted.
> + (description
> + "Rage is a video and audio player written with Enlightenment Foundation Libraries
> +with some extra bells and whistles.")
This line looks a little too long. When in Emacs please just use M-q to
break the long line according to our limits.
~~ Ricardo
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Update enlightenment.scm: Add Rage Player
2015-08-05 14:11 ` Ricardo Wurmus
@ 2015-08-05 14:27 ` Daniel Pimentel
2015-08-05 14:31 ` Ricardo Wurmus
0 siblings, 1 reply; 12+ messages in thread
From: Daniel Pimentel @ 2015-08-05 14:27 UTC (permalink / raw)
To: Ricardo Wurmus; +Cc: guix-devel, guix-devel-bounces+d4n1=opmbx.org
[-- Attachment #1: Type: text/plain, Size: 1921 bytes --]
On 2015-08-05 11:11, Ricardo Wurmus wrote:
> Hi Daniel,
>
> unfortunately, the commit message is still not correct. It’s all on
> one
> line and “gnu: enlightenment:” should be “gnu:” instead. If you use
> “git commit” without “-m” you can edit the message in your default
> editor (configurable by setting the EDITOR variable).
>
>> +(define-public rage
>> + (package
>> + (name "rage")
>> + (version "0.1.4")
>> + (source (origin
>> + (method url-fetch)
>> + (uri
>> + (string-append
>> +
>> "http://download.enlightenment.org/rel/apps/rage/rage-"
>> + version ".tar.gz"))
>> + (sha256
>> + (base32
>> "10j3n8crk16jzqz2hn5djx6vms5f6x83qyiaphhqx94h9dgv2mgg"))))
>> + (build-system gnu-build-system)
>> + (native-inputs
>> + `(("pkg-config" ,pkg-config)))
>> + (inputs
>> + `(("efl" ,efl)
>> + ("elementary" ,elementary)))
>> + (home-page "http://www.enlightenment.org")
>
> The home page for “rage” actually seems to be
> https://www.enlightenment.org/about-rage
>
>> + (synopsis "Powerful video play based on EFL")
>
> “video play” –> “video player”. Not sure if “Powerful” is a good word
> for a synopsis. What makes it powerful? If this cannot be expressed
> within the limited space of a synopsis it should be omitted.
>
>> + (description
>> + "Rage is a video and audio player written with Enlightenment
>> Foundation Libraries
>> +with some extra bells and whistles.")
>
> This line looks a little too long. When in Emacs please just use M-q
> to
> break the long line according to our limits.
>
> ~~ Ricardo
Thanks Ricardo,
I did the corrections using emacs editor and I did commit based on logs
(see git log). It's right now?
--
Daniel Pimentel (d4n1 3:)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0004-gnu-Add-Rage-player.patch --]
[-- Type: text/x-diff; name=0004-gnu-Add-Rage-player.patch, Size: 1225 bytes --]
From 11acae5bf4cbad9bb5d8707989e53074c647ef8c Mon Sep 17 00:00:00 2001
From: Daniel Pimentel <d4n1@member.fsf.org>
Date: Wed, 5 Aug 2015 11:22:15 -0300
Subject: [PATCH 4/4] gnu: Add Rage player.
* gnu/packages/enlightenment.scm: Change URI in home-page and description.
---
gnu/packages/enlightenment.scm | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/gnu/packages/enlightenment.scm b/gnu/packages/enlightenment.scm
index 5aa6525..48b9a32 100644
--- a/gnu/packages/enlightenment.scm
+++ b/gnu/packages/enlightenment.scm
@@ -255,11 +255,11 @@ contents and more.")
(inputs
`(("efl" ,efl)
("elementary" ,elementary)))
- (home-page "http://www.enlightenment.org")
- (synopsis "Powerful video play based on EFL")
+ (home-page "https://www.enlightenment.org/about-rage")
+ (synopsis "Video and audio player based on EFL")
(description
- "Rage is a video and audio player written with Enlightenment Foundation Libraries
-with some extra bells and whistles.")
+ "Rage is a video and audio player written with Enlightenment Foundation
+Libraries with some extra bells and whistles.")
(license license:bsd-2)))
(define-public enlightenment
--
2.4.3
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] Update enlightenment.scm: Add Rage Player
2015-08-05 14:27 ` Daniel Pimentel
@ 2015-08-05 14:31 ` Ricardo Wurmus
2015-08-05 14:35 ` Daniel Pimentel
0 siblings, 1 reply; 12+ messages in thread
From: Ricardo Wurmus @ 2015-08-05 14:31 UTC (permalink / raw)
To: Daniel Pimentel; +Cc: guix-devel, guix-devel-bounces+d4n1=opmbx.org
> Thanks Ricardo,
>
> I did the corrections using emacs editor and I did commit based on logs
> (see git log). It's right now?
The new patch you just sent is only the latest commit. Could you please
squash your commits so that we get *one* patch only instead of multiple
patches that are to be applied after another?
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Update enlightenment.scm: Add Rage Player
2015-08-05 14:31 ` Ricardo Wurmus
@ 2015-08-05 14:35 ` Daniel Pimentel
2015-08-06 14:16 ` Daniel Pimentel
0 siblings, 1 reply; 12+ messages in thread
From: Daniel Pimentel @ 2015-08-05 14:35 UTC (permalink / raw)
To: Ricardo Wurmus; +Cc: guix-devel, guix-devel-bounces+d4n1=opmbx.org
On 2015-08-05 11:31, Ricardo Wurmus wrote:
>> Thanks Ricardo,
>>
>> I did the corrections using emacs editor and I did commit based on
>> logs
>> (see git log). It's right now?
>
> The new patch you just sent is only the latest commit. Could you
> please
> squash your commits so that we get *one* patch only instead of multiple
> patches that are to be applied after another?
Allright, I'll do it and I'll send again :)
Thank so much.
--
Daniel Pimentel (d4n1 3:)
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Update enlightenment.scm: Add Rage Player
2015-08-05 14:35 ` Daniel Pimentel
@ 2015-08-06 14:16 ` Daniel Pimentel
2015-08-06 14:24 ` Ricardo Wurmus
2015-08-18 16:51 ` Ludovic Courtès
0 siblings, 2 replies; 12+ messages in thread
From: Daniel Pimentel @ 2015-08-06 14:16 UTC (permalink / raw)
To: Ricardo Wurmus; +Cc: guix-devel, guix-devel-bounces+d4n1=opmbx.org
[-- Attachment #1: Type: text/plain, Size: 625 bytes --]
On 2015-08-05 11:35, Daniel Pimentel wrote:
> On 2015-08-05 11:31, Ricardo Wurmus wrote:
>>> Thanks Ricardo,
>>>
>>> I did the corrections using emacs editor and I did commit based on
>>> logs
>>> (see git log). It's right now?
>>
>> The new patch you just sent is only the latest commit. Could you
>> please
>> squash your commits so that we get *one* patch only instead of
>> multiple
>> patches that are to be applied after another?
> Allright, I'll do it and I'll send again :)
>
> Thank so much.
Ricardo and Guixs,
in attach patch with add Rage player in enlightenment.scm.
Thanks,
--
Daniel Pimentel (d4n1 3:)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-Rage-player.patch --]
[-- Type: text/x-diff; name=0001-gnu-Add-Rage-player.patch, Size: 1608 bytes --]
From 96bed3aa54bc87ff9434b3c0d2f15572bb62fe80 Mon Sep 17 00:00:00 2001
From: Daniel Pimentel <d4n1@member.fsf.org>
Date: Thu, 6 Aug 2015 11:12:54 -0300
Subject: [PATCH] gnu: Add Rage player.
* gnu/packages/enlightenment.scm: Add Rage.
---
gnu/packages/enlightenment.scm | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/gnu/packages/enlightenment.scm b/gnu/packages/enlightenment.scm
index 28757f9..48b9a32 100644
--- a/gnu/packages/enlightenment.scm
+++ b/gnu/packages/enlightenment.scm
@@ -237,6 +237,31 @@ URL and local path detection, themes, popup based content viewer for non-text
contents and more.")
(license license:bsd-2)))
+(define-public rage
+ (package
+ (name "rage")
+ (version "0.1.4")
+ (source (origin
+ (method url-fetch)
+ (uri
+ (string-append
+ "http://download.enlightenment.org/rel/apps/rage/rage-"
+ version ".tar.gz"))
+ (sha256
+ (base32 "10j3n8crk16jzqz2hn5djx6vms5f6x83qyiaphhqx94h9dgv2mgg"))))
+ (build-system gnu-build-system)
+ (native-inputs
+ `(("pkg-config" ,pkg-config)))
+ (inputs
+ `(("efl" ,efl)
+ ("elementary" ,elementary)))
+ (home-page "https://www.enlightenment.org/about-rage")
+ (synopsis "Video and audio player based on EFL")
+ (description
+ "Rage is a video and audio player written with Enlightenment Foundation
+Libraries with some extra bells and whistles.")
+ (license license:bsd-2)))
+
(define-public enlightenment
(package
(name "enlightenment")
--
2.4.3
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] Update enlightenment.scm: Add Rage Player
2015-08-06 14:16 ` Daniel Pimentel
@ 2015-08-06 14:24 ` Ricardo Wurmus
2015-08-06 14:33 ` Daniel Pimentel
2015-08-18 16:51 ` Ludovic Courtès
1 sibling, 1 reply; 12+ messages in thread
From: Ricardo Wurmus @ 2015-08-06 14:24 UTC (permalink / raw)
To: Daniel Pimentel; +Cc: guix-devel, guix-devel-bounces+d4n1=opmbx.org
Thanks for the updated patch!
> * gnu/packages/enlightenment.scm: Add Rage.
This should really be:
* gnu/packages/enlightenment.scm (rage): New variable.
Other than that I have no important objections. I think this looks ugly
and could be improved, but I don’t think it’s very important:
> + (uri
> + (string-append
> + "http://download.enlightenment.org/rel/apps/rage/rage-"
> + version ".tar.gz"))
I’d put “(uri (string-append ...” on the same line, pull part of the
string onto the same line and align the rest accordingly.
But I better leave the comments and the final decision to someone else.
~~ Ricardo
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Update enlightenment.scm: Add Rage Player
2015-08-06 14:24 ` Ricardo Wurmus
@ 2015-08-06 14:33 ` Daniel Pimentel
0 siblings, 0 replies; 12+ messages in thread
From: Daniel Pimentel @ 2015-08-06 14:33 UTC (permalink / raw)
To: Ricardo Wurmus; +Cc: guix-devel, guix-devel-bounces+d4n1=opmbx.org
On 2015-08-06 11:24, Ricardo Wurmus wrote:
> Thanks for the updated patch!
>
>> * gnu/packages/enlightenment.scm: Add Rage.
>
> This should really be:
>
> * gnu/packages/enlightenment.scm (rage): New variable.
>
> Other than that I have no important objections. I think this looks
> ugly
> and could be improved, but I don’t think it’s very important:
>
>> + (uri
>> + (string-append
>> +
>> "http://download.enlightenment.org/rel/apps/rage/rage-"
>> + version ".tar.gz"))
>
> I’d put “(uri (string-append ...” on the same line, pull part of the
> string onto the same line and align the rest accordingly.
>
> But I better leave the comments and the final decision to someone else.
>
> ~~ Ricardo
All right, I can change if necessary.
I'll wait for it.
Thanks,
--
Daniel Pimentel (d4n1 3:)
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Update enlightenment.scm: Add Rage Player
2015-08-06 14:16 ` Daniel Pimentel
2015-08-06 14:24 ` Ricardo Wurmus
@ 2015-08-18 16:51 ` Ludovic Courtès
2015-08-18 18:28 ` Daniel Pimentel
1 sibling, 1 reply; 12+ messages in thread
From: Ludovic Courtès @ 2015-08-18 16:51 UTC (permalink / raw)
To: Daniel Pimentel; +Cc: guix-devel, guix-devel-bounces+d4n1=opmbx.org
Daniel Pimentel <d4n1@openmailbox.org> skribis:
> From 96bed3aa54bc87ff9434b3c0d2f15572bb62fe80 Mon Sep 17 00:00:00 2001
> From: Daniel Pimentel <d4n1@member.fsf.org>
> Date: Thu, 6 Aug 2015 11:12:54 -0300
> Subject: [PATCH] gnu: Add Rage player.
>
> * gnu/packages/enlightenment.scm: Add Rage.
Applied. I changed the URL to ‘https’ (this was needed because the http
URL redirects to https) and added a copyright line for you.
Thanks!
Ludo’.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Update enlightenment.scm: Add Rage Player
2015-08-18 16:51 ` Ludovic Courtès
@ 2015-08-18 18:28 ` Daniel Pimentel
0 siblings, 0 replies; 12+ messages in thread
From: Daniel Pimentel @ 2015-08-18 18:28 UTC (permalink / raw)
To: ludo; +Cc: guix-devel, guix-devel-bounces+d4n1=opmbx.org
On 2015-08-18 13:51, ludo@gnu.org wrote:
> Daniel Pimentel <d4n1@openmailbox.org> skribis:
>
>> From 96bed3aa54bc87ff9434b3c0d2f15572bb62fe80 Mon Sep 17 00:00:00 2001
>> From: Daniel Pimentel <d4n1@member.fsf.org>
>> Date: Thu, 6 Aug 2015 11:12:54 -0300
>> Subject: [PATCH] gnu: Add Rage player.
>>
>> * gnu/packages/enlightenment.scm: Add Rage.
>
> Applied. I changed the URL to ‘https’ (this was needed because the
> http
> URL redirects to https) and added a copyright line for you.
>
> Thanks!
>
> Ludo’.
Thanks Ludo and Guix Devs,
In soon I'll try create package to Nmap, Blender and other more complex
(lot of dependencies).
Thnaks,
--
Daniel Pimentel (d4n1 3:)
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2015-08-18 18:28 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-05 13:38 [PATCH] Update enlightenment.scm: Add Rage Player Daniel Pimentel
2015-08-05 13:59 ` Thompson, David
2015-08-05 14:08 ` Daniel Pimentel
2015-08-05 14:11 ` Ricardo Wurmus
2015-08-05 14:27 ` Daniel Pimentel
2015-08-05 14:31 ` Ricardo Wurmus
2015-08-05 14:35 ` Daniel Pimentel
2015-08-06 14:16 ` Daniel Pimentel
2015-08-06 14:24 ` Ricardo Wurmus
2015-08-06 14:33 ` Daniel Pimentel
2015-08-18 16:51 ` Ludovic Courtès
2015-08-18 18:28 ` Daniel Pimentel
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.