From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH] Update enlightenment.scm: Add Rage Player
Date: Wed, 05 Aug 2015 16:11:07 +0200
Message-ID: <87oailvn9g.fsf@elephly.net>
References: <e404f780a9b6927060c7810871b1cb55@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52948)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1ZMzPQ-0004Po-7x
	for guix-devel@gnu.org; Wed, 05 Aug 2015 10:11:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1ZMzPM-0001CQ-VJ
	for guix-devel@gnu.org; Wed, 05 Aug 2015 10:11:08 -0400
Received: from sender163-mail.zoho.com ([74.201.84.163]:25642)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1ZMzPM-0001B3-Mn
	for guix-devel@gnu.org; Wed, 05 Aug 2015 10:11:04 -0400
In-reply-to: <e404f780a9b6927060c7810871b1cb55@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Daniel Pimentel <d4n1@openmailbox.org>
Cc: guix-devel@gnu.org

Hi Daniel,

unfortunately, the commit message is still not correct.  It’s all on one
line and “gnu: enlightenment:” should be “gnu:” instead.  If you use
“git commit” without “-m” you can edit the message in your default
editor (configurable by setting the EDITOR variable).

> +(define-public rage
> +  (package
> +    (name "rage")
> +    (version "0.1.4")
> +    (source (origin
> +              (method url-fetch)
> +              (uri
> +               (string-append
> +                "http://download.enlightenment.org/rel/apps/rage/rage-"
> +                version ".tar.gz"))
> +              (sha256
> +               (base32 "10j3n8crk16jzqz2hn5djx6vms5f6x83qyiaphhqx94h9dgv2mgg"))))
> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("efl" ,efl)
> +       ("elementary" ,elementary)))
> +    (home-page "http://www.enlightenment.org")

The home page for “rage” actually seems to be
https://www.enlightenment.org/about-rage

> +    (synopsis "Powerful video play based on EFL")

“video play” –> “video player”.  Not sure if “Powerful” is a good word
for a synopsis.  What makes it powerful?  If this cannot be expressed
within the limited space of a synopsis it should be omitted.

> +    (description
> +     "Rage is a video and audio player written with Enlightenment Foundation Libraries 
> +with some extra bells and whistles.")

This line looks a little too long.  When in Emacs please just use M-q to
break the long line according to our limits.

~~ Ricardo