From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH 2/2] gnu: Add ruby-simplecov.
Date: Wed, 16 Sep 2015 11:34:18 +0200
Message-ID: <87oah27lnp.fsf@elephly.net>
References: <55f8ead6.KirY0UdOBnhexzdH%pjotr.public12@thebird.nl>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47581)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1Zc96i-00060i-9s
	for guix-devel@gnu.org; Wed, 16 Sep 2015 05:34:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1Zc96f-00072M-3L
	for guix-devel@gnu.org; Wed, 16 Sep 2015 05:34:28 -0400
Received: from sender163-mail.zoho.com ([74.201.84.163]:25398)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1Zc96e-000722-HM
	for guix-devel@gnu.org; Wed, 16 Sep 2015 05:34:25 -0400
In-reply-to: <55f8ead6.KirY0UdOBnhexzdH%pjotr.public12@thebird.nl>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Pjotr Prins <pjotr.public12@thebird.nl>
Cc: guix-devel@gnu.org

Hi Pjotr,

> * gnu/packages/ruby.scm (ruby-simplecov): New variable.

[...]

> +  (propagated-inputs
> +    `(("ruby-docile" ,ruby-docile)
> +      ("ruby-json" ,ruby-json)))
> +    (arguments
> +     '(#:tests? #f)) ; needs github-markup, among others
> +  (synopsis "Code coverage for Ruby")

I find it very surprising to see only “docile” and “json” as inputs and
not “ruby-simplecov-html”.  According to
https://rubygems.org/gems/simplecov “simplecov-html” is a runtime
dependency.

With my Ruby packages I’ve been closely following the dependencies as
they are declared on rubygems.org.

I’ve sent a patch to add “ruby-simplecov-html” to the ML a couple of
minutes ago, so maybe you could update your patch and add it as an
input.

> +  (description "Code coverage analysis tool for Ruby.  It uses Ruby's
> +built-in Coverage library to gather code coverage data, but makes
> +processing its results much easier by providing a clean API to filter,
> +group, merge, format, and display those results, giving you a complete
> +code coverage suite that can be set up with just a couple lines of
> +code.
> +")

The closing quote and the closing parenthesis should be on the same line
as the period.  The rest looks good to me.

~~ Ricardo