Re: [PATCH 2/3] emacs: Add key bindings for 'guix-build-log-minor-mode'.

[ludo@gnu.org (Ludovic Courtès)]

Alex Kost <alezost@gmail.com> skribis:

> I use (add-hook 'shell-mode-hook 'guix-build-log-minor-mode) and I found
> that along with phases highlighting, it is useful to have some key
> bindings available in this minor mode, so this patch adds "C-c
> M-n/M-p/TAB/S-TAB" keys to it.

Excellent!

> From fe50e7233fa5144f31f7db583d0289f056dd9dd0 Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost@gmail.com>
> Date: Thu, 29 Oct 2015 21:27:56 +0300
> Subject: [PATCH 2/3] emacs: Add key bindings for 'guix-build-log-minor-mode'.
>
> * emacs/guix-build-log.el (guix-build-log-mode-map): Move keys to ...
>   (guix-build-log-common-map): ...here.  New variable.
>   (guix-build-log-minor-mode-map): New variable.
>   (guix-build-log-minor-mode): Use it.
> * doc/emacs.texi (Emacs Build Log): Document it.

OK to push.

> +  (add-hook 'shell-mode-hook 'guix-build-log-minor-mode)

I wonder if we should do that automatically by default.  That way
everyone would get the cool features, even those who didn’t bother to
read all the manual.

WDYT?

Thanks,
Ludo’.