From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 1/2] gnu: Add qtkeychain.
Date: Thu, 12 Nov 2015 14:03:15 +0100
Message-ID: <87oaezxtd8.fsf@gnu.org>
References: <1446497399-30726-1-git-send-email-efraim@flashner.co.il>
	<1446497399-30726-2-git-send-email-efraim@flashner.co.il>
	<87d1vocf05.fsf@gnu.org> <20151107203145.75002d7c@debian-netbook>
	<87r3jxn2xz.fsf@gnu.org> <20151112142223.453c0fe2@debian-netbook>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55732)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZwrX9-0003Kf-LW
	for guix-devel@gnu.org; Thu, 12 Nov 2015 08:03:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZwrX4-0002BZ-29
	for guix-devel@gnu.org; Thu, 12 Nov 2015 08:03:23 -0500
In-Reply-To: <20151112142223.453c0fe2@debian-netbook> (Efraim Flashner's
	message of "Thu, 12 Nov 2015 14:22:23 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org

Efraim Flashner <efraim@flashner.co.il> skribis:

> On Tue, 10 Nov 2015 19:07:20 +0100
> ludo@gnu.org (Ludovic Court=C3=A8s) wrote:
>
>> Efraim Flashner <efraim@flashner.co.il> skribis:
>>=20
>> > On Thu, 05 Nov 2015 22:28:42 +0100
>> > ludo@gnu.org (Ludovic Court=C3=A8s) wrote:
>> >=20=20
>> >> Efraim Flashner <efraim@flashner.co.il> skribis:
>> >>=20=20=20
>> >> > * gnu/packages/qt.scm (qtkeychain): New variable.=20=20=20=20
>> >>=20
>> >> [...]
>> >>=20=20=20
>> >> > +       (modify-phases
>> >> > +         %standard-phases=20=20=20=20
>> >>=20
>> >> =E2=80=98%standard-phases=E2=80=99 goes on the previous line.
>> >>=20=20=20
>> >> > +         (add-before
>> >> > +          'configure 'set-qt-trans-dir
>> >> > +           (lambda _
>> >> > +             (substitute* "CMakeLists.txt"
>> >> > +              (("\\$\\{qt_translations_dir\\}")
>> >> > +                "${CMAKE_INSTALL_PREFIX}/share/qtkeychain/translat=
ions")))))))=20=20=20=20
>> >>=20
>> >> Is Qt able to find translations installed there?  Is some environment
>> >> variable needed to tell it where to look for them?=20=20
>> >
>> > I don't really know.=20=20
>>=20
>> Could you check by running it with a non-English locale listed that
>> appears in the =E2=80=98translations=E2=80=99 directory?

[...]

> It works! I did `export LANG=3Dde` and then
> ran /./gnu/store/...owncloud/bin/owncloud, and I got a German popup telli=
ng
> me there was no associated keychain and I had to enter the password mysel=
f.

Good!

So I think, with the tiny stylistic issues I reported fixed, you
can push.

Thank you for your patience!

Ludo=E2=80=99.