From: ludo@gnu.org (Ludovic Courtès)
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/2] gnu: Add qtkeychain.
Date: Thu, 12 Nov 2015 14:03:15 +0100 [thread overview]
Message-ID: <87oaezxtd8.fsf@gnu.org> (raw)
In-Reply-To: <20151112142223.453c0fe2@debian-netbook> (Efraim Flashner's message of "Thu, 12 Nov 2015 14:22:23 +0200")
Efraim Flashner <efraim@flashner.co.il> skribis:
> On Tue, 10 Nov 2015 19:07:20 +0100
> ludo@gnu.org (Ludovic Courtès) wrote:
>
>> Efraim Flashner <efraim@flashner.co.il> skribis:
>>
>> > On Thu, 05 Nov 2015 22:28:42 +0100
>> > ludo@gnu.org (Ludovic Courtès) wrote:
>> >
>> >> Efraim Flashner <efraim@flashner.co.il> skribis:
>> >>
>> >> > * gnu/packages/qt.scm (qtkeychain): New variable.
>> >>
>> >> [...]
>> >>
>> >> > + (modify-phases
>> >> > + %standard-phases
>> >>
>> >> ‘%standard-phases’ goes on the previous line.
>> >>
>> >> > + (add-before
>> >> > + 'configure 'set-qt-trans-dir
>> >> > + (lambda _
>> >> > + (substitute* "CMakeLists.txt"
>> >> > + (("\\$\\{qt_translations_dir\\}")
>> >> > + "${CMAKE_INSTALL_PREFIX}/share/qtkeychain/translations")))))))
>> >>
>> >> Is Qt able to find translations installed there? Is some environment
>> >> variable needed to tell it where to look for them?
>> >
>> > I don't really know.
>>
>> Could you check by running it with a non-English locale listed that
>> appears in the ‘translations’ directory?
[...]
> It works! I did `export LANG=de` and then
> ran /./gnu/store/...owncloud/bin/owncloud, and I got a German popup telling
> me there was no associated keychain and I had to enter the password myself.
Good!
So I think, with the tiny stylistic issues I reported fixed, you
can push.
Thank you for your patience!
Ludo’.
next prev parent reply other threads:[~2015-11-12 13:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 20:49 [PATCH 0/2] Owncloud-client Efraim Flashner
2015-11-02 20:49 ` [PATCH 1/2] gnu: Add qtkeychain Efraim Flashner
2015-11-05 21:28 ` Ludovic Courtès
2015-11-07 18:31 ` Efraim Flashner
2015-11-08 6:17 ` Efraim Flashner
2015-11-10 18:07 ` Ludovic Courtès
2015-11-12 12:22 ` Efraim Flashner
2015-11-12 13:03 ` Ludovic Courtès [this message]
2015-11-02 20:49 ` [PATCH 2/2] gnu: Add owncloud-client Efraim Flashner
2015-11-05 21:32 ` Ludovic Courtès
2015-11-07 18:35 ` Efraim Flashner
2015-11-10 18:02 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oaezxtd8.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=efraim@flashner.co.il \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.