From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] Add package definition for GNU XaoS Date: Tue, 15 Dec 2015 22:24:15 +0300 Message-ID: <87oadrseg0.fsf@gmail.com> References: <20151214220139.27f55979@himbaca> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43732) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8vCt-0001Aq-E5 for guix-devel@gnu.org; Tue, 15 Dec 2015 14:24:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8vCq-0004fs-Ob for guix-devel@gnu.org; Tue, 15 Dec 2015 14:24:19 -0500 Received: from mail-lb0-x229.google.com ([2a00:1450:4010:c04::229]:33058) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8vCq-0004fg-H2 for guix-devel@gnu.org; Tue, 15 Dec 2015 14:24:16 -0500 Received: by mail-lb0-x229.google.com with SMTP id kw15so12300729lbb.0 for ; Tue, 15 Dec 2015 11:24:16 -0800 (PST) In-Reply-To: <20151214220139.27f55979@himbaca> (Fabian Harfert's message of "Mon, 14 Dec 2015 22:01:39 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Fabian Harfert Cc: guix-devel@gnu.org Fabian Harfert (2015-12-15 00:01 +0300) wrote: > Hello, > > this is my first contribution to this project. I hope everything is > right with this package definition for GNU XaoS > (see https://www.gnu.org/software/xaos/). It's a nice program to > discover fractals, so I decided to use it for my first packaging > attempt. Hello, great attempt! And thank you for showing this awesome program! I didn't know about it. [...] > +(define-public xaos > + (package > + (name "xaos") > + (version "3.6") > + (source (origin > + (method url-fetch) > + (uri (string-append "mirror://sourceforge/xaos/xaos-" version > + ".tar.gz")) > + (sha256 > + (base32 > + "15cd1cx1dyygw6g2nhjqq3bsfdj8sj8m4va9n75i0f3ryww3x7wq")))) > + (build-system gnu-build-system) > + (native-inputs `(("gettext", gnu-gettext))) It should be: `(("gettext" ,gnu-gettext)) ^^ > + (inputs `(("libx11" ,libx11) > + ("zlib" ,zlib) > + ("libpng" ,libpng) > + ("gsl" ,gsl))) > + (arguments > + `(#:tests? #f ;no "check" target > + #:make-flags '("LOCALEDIR=$DATAROOTDIR/locale"))) > + (synopsis "Real-time fractal zoomer") > + (description "GNU XaoS is a graphical program that generates fractal patterns and Please do not make such long lines, we stay within 80 columns (I personally prefer to stay within 72 if possible). > +allows you to zoom in and out of them infinitely in a fluid, continuous > +manner. It also includes tutorials that help to explain how fractals are > +built. It can generate many different fractal types such as the Mandelbrot > +set.") > + (home-page "http://www.gnu.org/software/xaos/") > + (license license:gpl2+))) Otherwise, the patch looks good to me, so if there will be no other comments I'll push it soon. -- Alex