From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mathieu Lirzin <mthl@gnu.org>
Subject: Re: [PATCH 06/13] build: Generate man pages after compiling guile
	objects.
Date: Fri, 29 Jan 2016 23:56:27 +0100
Message-ID: <87oac4ngf8.fsf@gnu.org>
References: <1453666771-16869-1-git-send-email-mthl@gnu.org>
	<1453666771-16869-7-git-send-email-mthl@gnu.org>
	<87d1somgfd.fsf@gnu.org> <87zivs2jej.fsf@gnu.org>
	<20160127203742.52245ef3@openmailbox.org> <87oac5k8sp.fsf@gnu.org>
	<7bfbfb841466c6889effbd21d089d616@openmailbox.org>
	<87k2mtk5ak.fsf@gnu.org> <20160128182733.5291643b@openmailbox.org>
	<87y4b8nywm.fsf@gnu.org>
	<a2f7bede1bdbd72fec77826bab045466@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47573)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mthl@gnu.org>) id 1aPHy0-0000OJ-Jx
	for guix-devel@gnu.org; Fri, 29 Jan 2016 17:56:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mthl@gnu.org>) id 1aPHxz-00063e-SG
	for guix-devel@gnu.org; Fri, 29 Jan 2016 17:56:36 -0500
In-Reply-To: <a2f7bede1bdbd72fec77826bab045466@openmailbox.org> (Eric Bavier's
	message of "Fri, 29 Jan 2016 10:46:55 -0600")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Eric Bavier <ericbavier@openmailbox.org>
Cc: guix-devel@gnu.org

Eric Bavier <ericbavier@openmailbox.org> writes:

>> +doc/guix-%.1: guix/scripts/%.scm $(GOBJECTS)
>> +	-$(AM_V_HELP2MAN)case '$?' in \
>> +	  *$<*) $(gen_man) --output="$@" "guix `basename "$<" .scm`";; \
>> +	  *)    : ;; \
>> +	esac
>
> The `basename "$<" .scm` could be reduced to $* here.
>
> In my patch I was trying to avoid printing the case et al in verbose
> mode.  This should be fine though; anyone reading the output of a
> verbose build might not be put off my the sh.
>
> The rest LGTM!

pushed in 36629097523b0abd89d1b931293150cb9c1f242d with slight
modifications.

Thanks,

--
Mathieu Lirzin