From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#20145: (guix build download) leaks file descriptor on TLS
	connections
Date: Thu, 17 Mar 2016 23:57:45 +0100
Message-ID: <87oaac1zme.fsf@gnu.org>
References: <87619w6efb.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49024)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1aggrl-0002NS-LY
	for bug-guix@gnu.org; Thu, 17 Mar 2016 18:58:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1aggri-0002EG-Fz
	for bug-guix@gnu.org; Thu, 17 Mar 2016 18:58:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:54405)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1aggri-0002E8-E4
	for bug-guix@gnu.org; Thu, 17 Mar 2016 18:58:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1aggri-0008Ev-9B
	for bug-guix@gnu.org; Thu, 17 Mar 2016 18:58:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-To: bug-guix@gnu.org
Resent-Message-ID: <handler.20145.D20145.145825547831659.done@debbugs.gnu.org>
In-Reply-To: <87619w6efb.fsf@gnu.org> ("Ludovic
	\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
	\=\?utf-8\?Q\?s\?\= message of "Thu, 19 Mar 2015 19:16:24 +0100")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: 20145-done@debbugs.gnu.org

ludo@gnu.org (Ludovic Court=C3=A8s) skribis:

> When opening an HTTPS connection, the file descriptor beneath the port
> returned by =E2=80=98tls-wrap=E2=80=99 is leaked.
>
> This is not a problem in most cases (downloads) because the process is
> left as soon as the download is over.
>
> This is more problematic for =E2=80=98guix lint=E2=80=99, which may open =
a large number
> of HTTPS connections for the =E2=80=98source=E2=80=99 and =E2=80=98home-p=
age=E2=80=99 checkers when
> working on all the packages.

This is essentially solved by commits
14d6ca3e4dd23ee92adb5e2fcf58546e67534631 and
097a951e96718a037dbfa6d579e2d26f7dab3e82.

One still needs to be careful, though, for instance because closing a
chunked encoding port (which is a custom binary input port wrapped
around the real socket port) still fails to close the raw socket port
that=E2=80=99s behind the TLS session record port.

Ludo=E2=80=99.