From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 3/3] import: Add Hackage updater.
Date: Mon, 28 Mar 2016 18:12:05 +0200
Message-ID: <87oa9ysht6.fsf@gnu.org>
References: <1458705269-31766-1-git-send-email-ericbavier@openmailbox.org>
	<1458705269-31766-3-git-send-email-ericbavier@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59961)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1akZm1-0004sW-SA
	for guix-devel@gnu.org; Mon, 28 Mar 2016 12:12:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1akZm1-0005uf-1c
	for guix-devel@gnu.org; Mon, 28 Mar 2016 12:12:13 -0400
In-Reply-To: <1458705269-31766-3-git-send-email-ericbavier@openmailbox.org>
	(ericbavier@openmailbox.org's message of "Tue, 22 Mar 2016 22:54:29
	-0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: ericbavier@openmailbox.org
Cc: guix-devel@gnu.org, Eric Bavier <bavier@member.fsf.org>

ericbavier@openmailbox.org skribis:

> From: Eric Bavier <bavier@member.fsf.org>
>
> * guix/import/hackage.scm (guix-package->hackage-name, hackage-package?)
>   (latest-release): New procedures.
>   (%hackage-updater): New variable.
> * guix/scripts/refresh.scm (%updaters): Add it.
> * doc/guix.texi (Invoking guix refresh): Mention it.

[...]

> +(define guix-package->hackage-name
> +  (let ((uri-rx (make-regexp "https?://hackage.haskell.org/package/([^/]=
+)/.*"))
> +        (name-rx (make-regexp "(.*)-[0-9\\.]+")))
> +    (lambda (package)
> +      "Given a Guix package name, return the corresponding Hackage name."
> +      (let* ((source-url (and=3D> (package-source package) origin-uri))
> +             (name (match:substring (regexp-exec uri-rx source-url) 1)))
> +        (match (regexp-exec name-rx name)
> +          (#f name)
> +          (m (match:substring m 1)))))))

It might be useful to honor a =E2=80=98cabal-package-name=E2=80=99 property=
 in cases
where guessing doesn=E2=80=99t work.  That can always be added later, thoug=
h.

[...]

>                   %elpa-updater
>                   %cran-updater
>                   %bioconductor-updater
> +                 %hackage-updater

Make it:

  ((guix import hackage) =3D> %hackage-importer)

to be on the safe side.

If you confirm that =E2=80=98guix refresh -t hackage=E2=80=99 doesn=E2=80=
=99t crash, go for it!

Thank you!

Ludo=E2=80=99.