From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Nieuwenhuizen <janneke@gnu.org>
Subject: Re: [PATCH v4 1/9] gnu: cross: Use CROSS_*_INCLUDE_PATH for system
	headers.
Date: Tue, 26 Apr 2016 11:03:42 +0200
Message-ID: <87oa8wyc5t.fsf@drakenvlieg.flower>
References: <87vb492l7s.fsf@drakenvlieg.flower> <8760w2nzl4.fsf@elephly.net>
	<87d1q8lb7j.fsf@drakenvlieg.flower> <87k2k99l7w.fsf@gnu.org>
	<87d1pssnwl.fsf@drakenvlieg.flower> <871t614pk6.fsf@gnu.org>
	<87bn4yhurl.fsf_-_@drakenvlieg.flower> <87vb36x9ac.fsf@igalia.com>
	<87vb492l7s.fsf@drakenvlieg.flower> <877fgio11v.fsf@elephly.net>
	<87r3eq2y2s.fsf@drakenvlieg.flower> <8760w2nzl4.fsf@elephly.net>
	<87d1q8lb7j.fsf@drakenvlieg.flower> <87k2k99l7w.fsf@gnu.org>
	<87d1pssnwl.fsf@drakenvlieg.flower> <871t614pk6.fsf@gnu.org>
	<87bn4yhurl.fsf_-_@drakenvlieg.flower> <87vb36x9ac.fsf@igalia.com>
	<87wpnmgc5k.fsf@drakenvlieg.flower> <87oa8wx0jg.fsf@igalia.com>
	<87shy8ydd7.fsf@drakenvlieg.flower>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54130)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <janneke@gnu.org>) id 1auyuZ-0004n7-EB
	for guix-devel@gnu.org; Tue, 26 Apr 2016 05:04:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <janneke@gnu.org>) id 1auyuV-0005V8-8l
	for guix-devel@gnu.org; Tue, 26 Apr 2016 05:04:03 -0400
In-Reply-To: <87shy8ydd7.fsf@drakenvlieg.flower> (Jan Nieuwenhuizen's message
	of "Tue, 26 Apr 2016 10:37:40 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Andy Wingo <wingo@igalia.com>
Cc: guix-devel@gnu.org

Jan Nieuwenhuizen writes:

Just a quick thing I noticed while preparing new patch

>>> +-  if (temp && *cross_compile =3D=3D '0')
>>> ++  if (temp)
>>> +     {
>>> +       const char *startp, *endp;
>>> +       char *nstore =3D (char *) alloca (strlen (temp) + 3);
>>
>> Why this change?
>
> Not a change per se, AIUI our cross patch makes COMPILER_PATH now
> valid, as we populate it from CROSS_*.

This is foo; this change is only for LIBRARY_PATH_ENV and the patch
above reverts the one below, making them a no-op

>>> --  if (temp && *cross_compile =3D=3D '0')
>>> -+  if (temp)
>>> -     {
>>> -       const char *startp, *endp;
>>> -       char *nstore =3D (char *) alloca (strlen (temp) + 3);
>>> --=20
>>> 2.7.3
>>
>> Similar comment as above.
>
> Not a change per se, AIUI our cross patch makes LIBRARY_PATH[_ENV] now
> valid, as we populate it from CROSS_LIBRARY_PATH.

In my new patch this gcc.c patch was the first, and the old guix patch
it was the last.  I have moved this gcc.c patch it to the bottom now and
then it dissappears from the guix patch. :-)

Greetings, Jan

--=20
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar=C2=AE  http://AvatarAcademy.nl=
=20=20