From: ludo@gnu.org (Ludovic Courtès)
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 22808@debbugs.gnu.org
Subject: bug#22808: Add a function to simplify many of the new python2-foo definitions
Date: Tue, 26 Apr 2016 15:09:15 +0200 [thread overview]
Message-ID: <87oa8wtt38.fsf@gnu.org> (raw)
In-Reply-To: <20160426124428.GA12637@debian-netbook> (Efraim Flashner's message of "Tue, 26 Apr 2016 15:44:28 +0300")
Efraim Flashner <efraim@flashner.co.il> skribis:
> On Tue, Apr 26, 2016 at 11:54:28AM +0200, Ludovic Courtès wrote:
>> ludo@gnu.org (Ludovic Courtès) skribis:
[...]
>> What about this:
>>
>
>> --- a/gnu/packages/python.scm
>> +++ b/gnu/packages/python.scm
>> @@ -345,6 +345,14 @@ instead of @command{python3}.")))
>> (define-public python-wrapper (wrap-python3 python))
>> (define-public python-minimal-wrapper (wrap-python3 python-minimal))
>>
>> +(define (package-with-python2+setuptools p)
>> + (let ((base (package-with-python2 (strip-python2-variant p))))
>> + (package
>> + (inherit base)
>> + (native-inputs `(("python2-setuptools" ,python2-setuptools)
>> + ,@(package-native-inputs base))))))
>> +
>> +\f
>> (define-public python-psutil
>> (package
>> (name "python-psutil")
>
>>
>> Then we need to change all the occurrences of this pattern to use this
>> new procedure.
>>
>> Thoughts?
>>
>> Ludo’.
>
> Would we still need the properties field in python-foo?
Yes.
> What would this mean for packages that need python2-setuptools and other
> python2- specific packages? Specifically, would all the calls to
> package-native-inputs cause a slowdown in computing the package?
It wouldn’t change anything, since this exact same pattern is already
used in many different places in python.scm (search for
“python2-setuptools” and you’ll see :-)). It would simply allow us to
factorize it.
Ludo’.
next prev parent reply other threads:[~2016-04-26 13:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 21:14 bug#22808: Add a function to simplify many of the new python2-foo definitions Christopher Allan Webber
2016-02-26 23:26 ` Ludovic Courtès
2016-04-26 9:54 ` Ludovic Courtès
2016-04-26 12:44 ` Efraim Flashner
2016-04-26 13:09 ` Ludovic Courtès [this message]
2019-01-31 14:39 ` bug#22808: Close Andreas Enge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oa8wtt38.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=22808@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.