From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: Trying to build latest Icedtea / Java 6 [security update]
Date: Wed, 01 Jun 2016 08:07:53 +0200
Message-ID: <87oa7lcuh2.fsf@elephly.net>
References: <20160530045937.GA32652@jasmine> <87pos2ca7z.fsf@elephly.net>
	<20160531225234.GA19511@jasmine>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48809)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1b7zK5-0005ZU-S9
	for guix-devel@gnu.org; Wed, 01 Jun 2016 02:08:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1b7zK0-0000UE-OJ
	for guix-devel@gnu.org; Wed, 01 Jun 2016 02:08:08 -0400
Received: from sender163-mail.zoho.com ([74.201.84.163]:24373)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1b7zK0-0000S1-Ff
	for guix-devel@gnu.org; Wed, 01 Jun 2016 02:08:04 -0400
In-reply-to: <20160531225234.GA19511@jasmine>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org


Leo Famulari <leo@famulari.name> writes:

> On Tue, May 31, 2016 at 09:13:04PM +0200, Ricardo Wurmus wrote:
>> Leo Famulari <leo@famulari.name> writes:
>> 
>> > Icedtea 1.13.11 was released, which fixes a number of security bugs:
>> >
>> > http://blog.fuseyism.com/index.php/2016/05/04/security-icedtea-1-13-11-for-openjdk-6-released/
>> >
>> > I tried to build it with the attached patch, but it fails for me. I've
>> > attached the tail of the build log. Any advice?
>> 
>> The patch looks good to me.  If I understand correctly this may be
>> because we’re bootstrapping with GCJ, which implements Java 1.5.  You
>> can see in the log that “javac” runs with “-source 1.5 -target 5”, which
>> means that it assumes that the code is written in compliance with Java
>> 1.5.  Maybe this file simply is not valid Java 1.5.
>> 
>> According to http://stackoverflow.com/a/8697805/519736 “@Override” is
>> interpreted more strictly in 1.5.  I don’t know much about Java and I
>> haven’t looked at the sources in question, but I guess there are
>> “@Override” annotations above the five method declarations.  We might be
>> able to just remove them.
>> 
>> I think this should be reported to Andrew; looks like a bug as
>> bootstrapping with GCJ should work for OpenJDK 6.
>
> Done: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=2990

Thank you.  Since this has been fixed here

   http://icedtea.classpath.org/hg/icedtea6/rev/60be25a84f2d

we should apply this change to the 1.13.11 sources.

~~ Ricardo