From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: Patch to rename NIX_CONF_DIR to GUIX_CONF_DIR
Date: Fri, 24 Jun 2016 14:21:40 +0200
Message-ID: <87oa6q6aln.fsf@gnu.org>
References: <CAL1_immtFeqaiwq_xYFLLJ3T1wXjtUmOcD=aAJW5XEbyMp6e8A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34353)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bGQ7J-0001Ap-9D
	for guix-devel@gnu.org; Fri, 24 Jun 2016 08:21:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bGQ7E-0007r8-9Q
	for guix-devel@gnu.org; Fri, 24 Jun 2016 08:21:48 -0400
In-Reply-To: <CAL1_immtFeqaiwq_xYFLLJ3T1wXjtUmOcD=aAJW5XEbyMp6e8A@mail.gmail.com>
	(David Craven's message of "Thu, 23 Jun 2016 21:07:49 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

Hello!

David Craven <david@craven.ch> skribis:

> First I have to say `guix build guix --with-source=3D.` is totally awesom=
e!!

Thanks!  Don=E2=80=99t miss --with-input too!  ;-)

  https://www.gnu.org/software/guix/manual/html_node/Package-Transformation=
-Options.html

> I couldn't find any documentation on the git commit message
> convention, hope I did it right.

ng0 already replied on that point; you=E2=80=99re almost there.  :-)

The patch omits to change references to =E2=80=98NIX_CONF_DIR=E2=80=99 in t=
he *.cc and
*.h files under nix/.  Could you update it accordingly?

While at it, can you make it =E2=80=98GUIX_CONFIGURATION_DIRECTORY=E2=80=99=
 instead of
=E2=80=98GUIX_CONF_DIR=E2=80=99 (following the Scheme tradition of avoiding
abbreviations ;-))?

Last, please run the test suite to make sure nothing goes wrong:

  https://www.gnu.org/software/guix/manual/html_node/Running-the-Test-Suite=
.html

Thank you for looking into it!

Ludo=E2=80=99.