From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Wingo Subject: Re: [PATCH] openssh service Date: Fri, 05 Aug 2016 15:47:50 +0200 Message-ID: <87oa57jpix.fsf@igalia.com> References: <20160805141840.447dd381@polymos> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46364) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVfUN-0006pr-EQ for guix-devel@gnu.org; Fri, 05 Aug 2016 09:48:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bVfUI-0004oD-HU for guix-devel@gnu.org; Fri, 05 Aug 2016 09:48:39 -0400 Received: from pb-sasl1.pobox.com ([64.147.108.66]:52098 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVfUI-0004em-DQ for guix-devel@gnu.org; Fri, 05 Aug 2016 09:48:34 -0400 In-Reply-To: <20160805141840.447dd381@polymos> (Julien Lepiller's message of "Fri, 5 Aug 2016 14:18:40 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Julien Lepiller Cc: guix-devel@gnu.org On Fri 05 Aug 2016 14:18, Julien Lepiller writes: > here is a patch that adds a service definition for openssh. Very nice! > + (let ((pid (primitive-fork))) > + (case pid > + ((0) > + (execl (string-append #$openssh "/bin/ssh-keygen") > + "ssh-keygen" "-A") > + (else > + (zero? (cdr (waitpid pid))))))) I guess you could system* this one instead; would be easier I think. Dunno. Other than that looks all good to me. Would need an addition to the manual eventually though. Andy