From: ludo@gnu.org (Ludovic Courtès)
To: Ting-Wei Lan <lantw44@gmail.com>
Cc: 22004-done@debbugs.gnu.org
Subject: bug#22004: guix-environment-container.sh test fails when building guix on tmpfs
Date: Sun, 28 Aug 2016 16:05:33 +0200 [thread overview]
Message-ID: <87oa4d2dle.fsf@gnu.org> (raw)
In-Reply-To: <1472027940.26857.5.camel@gmail.com> (Ting-Wei Lan's message of "Wed, 24 Aug 2016 16:39:00 +0800")
Ting-Wei Lan <lantw44@gmail.com> skribis:
> They are on tmpfs and the order of the two arguments of 'string-
> prefix?' function seems to be wrong, so these 3 entries are ignored.
>
> A simple fix:
>
> diff --git a/tests/guix-environment-container.sh b/tests/guix-environment-container.sh
> index 12da950..d7c1b70 100644
> --- a/tests/guix-environment-container.sh
> +++ b/tests/guix-environment-container.sh
> @@ -72,7 +72,7 @@ mount_test_code="
> ;; correspond to a parent file system.
> ((_ mount (or \"tmpfs\" \"proc\" \"sysfs\" \"devtmpfs\"
> \"devpts\" \"cgroup\" \"mqueue\") _ _ _)
> - (and (string-prefix? mount (getcwd))
> + (and (string-prefix? (getcwd) mount)
> mount))
> ((_ mount _ _ _ _)
> mount)))
>
> After changing the order, guix-environment-container.sh passes.
Good catch! Applied, thanks!
Ludo’.
prev parent reply other threads:[~2016-08-28 14:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 15:57 bug#22004: guix-environment-container.sh test fails when building guix on tmpfs Ting-Wei Lan
2016-07-31 16:54 ` Ludovic Courtès
2016-08-01 4:43 ` Ting-Wei Lan
2016-08-01 13:13 ` Ludovic Courtès
2016-08-24 8:39 ` Ting-Wei Lan
2016-08-28 14:05 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oa4d2dle.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=22004-done@debbugs.gnu.org \
--cc=lantw44@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.