[PATCH] gnu: Add mtd-utils.

[PATCH] gnu: Add mtd-utils.

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]


* gnu/packages/linux.scm (mtd-utils): New variable.
---
 gnu/packages/linux.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-mtd-utils.patch --]
[-- Type: text/x-patch; name="0001-gnu-Add-mtd-utils.patch", Size: 1990 bytes --]

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 07fd6e5..7ab9b3c 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -32,6 +32,7 @@
 
 (define-module (gnu packages linux)
   #:use-module (gnu packages)
+  #:use-module (gnu packages acl)
   #:use-module (gnu packages admin)
   #:use-module (gnu packages algebra)
   #:use-module (gnu packages attr)
@@ -2898,3 +2899,37 @@ native Linux file system, and has been part of the Linux kernel since version
     ;; The files src/key_mod/ecryptfs_key_mod_{openssl,pkcs11_helper,tspi}.c
     ;; grant additional permission to link with OpenSSL.
     (license license:gpl2+)))
+
+(define-public mtd-utils
+  (package
+    (name "mtd-utils")
+    (version "1.5.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                "ftp://ftp.infradead.org/pub/mtd-utils/mtd-utils-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "007lhsd8yb34l899r4m37whhzdw815cz4fnjbpnblfha524p7dax"))
+              (file-name (string-append "mtd-utils-" version))))
+    (inputs
+     `(("acl" ,acl)
+       ("libuuid" ,util-linux)
+       ("lzo", lzo)
+       ("zlib" ,zlib)))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:test-target "tests"
+       #:phases (modify-phases %standard-phases
+         (add-before 'build 'patch-installation-prefix
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out")))
+               (substitute* '("common.mk")
+                 (("PREFIX=/usr") (string-append "PREFIX=" out))))))
+         (delete 'configure))))
+    (synopsis "MTD Flash Storage Utilities")
+    (description
+     "@code{mtd-utils} provides utilities for testing, partitioning
+etc of flash storage.")
+    (home-page "http://www.linux-mtd.infradead.org/")
+    (license (list license:gpl2 license:mpl1.1 license:bsd-3))))

Re: [PATCH] gnu: Add mtd-utils.

[Alex Kost]

Danny Milosavljevic (2016-08-30 02:24 +0300) wrote:

> * gnu/packages/linux.scm (mtd-utils): New variable.
> ---
>  gnu/packages/linux.scm | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
>
>
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index 07fd6e5..7ab9b3c 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -32,6 +32,7 @@
>  
>  (define-module (gnu packages linux)
>    #:use-module (gnu packages)
> +  #:use-module (gnu packages acl)
>    #:use-module (gnu packages admin)
>    #:use-module (gnu packages algebra)
>    #:use-module (gnu packages attr)
> @@ -2898,3 +2899,37 @@ native Linux file system, and has been part of the Linux kernel since version
>      ;; The files src/key_mod/ecryptfs_key_mod_{openssl,pkcs11_helper,tspi}.c
>      ;; grant additional permission to link with OpenSSL.
>      (license license:gpl2+)))
> +
> +(define-public mtd-utils
> +  (package
> +    (name "mtd-utils")
> +    (version "1.5.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                "ftp://ftp.infradead.org/pub/mtd-utils/mtd-utils-" version ".tar.bz2"))

bad indentation ^^^   I would write it like this:

              (uri (string-append
                    "ftp://ftp.infradead.org/pub/mtd-utils/mtd-utils-"
                    version ".tar.bz2"))


> +              (sha256
> +               (base32
> +                "007lhsd8yb34l899r4m37whhzdw815cz4fnjbpnblfha524p7dax"))
> +              (file-name (string-append "mtd-utils-" version))))

'file-name' is not needed as the name of the source tarball is already
good enough.  It is needed, for example, when the source name does not
have a package name, like "v0.1.tar.gz" (the case of github tag
snapshots).

Also note that if 'file-name' would be required here, it should be ended
with ".tar.bz2": you rename it to "mtd-utils-1.5.2" and this is a bad
name for a "tar.bz2" file.

> +    (inputs
> +     `(("acl" ,acl)
> +       ("libuuid" ,util-linux)
> +       ("lzo", lzo)
> +       ("zlib" ,zlib)))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:test-target "tests"
> +       #:phases (modify-phases %standard-phases
> +         (add-before 'build 'patch-installation-prefix
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((out (assoc-ref outputs "out")))
> +               (substitute* '("common.mk")
> +                 (("PREFIX=/usr") (string-append "PREFIX=" out))))))

Please add #t in the end of this phase: a phase should return non-false
value if it succeeds.

> +         (delete 'configure))))
> +    (synopsis "MTD Flash Storage Utilities")
> +    (description
> +     "@code{mtd-utils} provides utilities for testing, partitioning
> +etc of flash storage.")
> +    (home-page "http://www.linux-mtd.infradead.org/")
> +    (license (list license:gpl2 license:mpl1.1 license:bsd-3))))

It would be good if you write a comment before licenses, like what files
have what licenses.  Also is it really 'gpl2'?  If the license says "or
any later version", it should be 'gpl2+'.

-- 
Alex

Re: [PATCH] gnu: Add mtd-utils.

[Danny Milosavljevic]

On Tue, 30 Aug 2016 11:08:17 +0300
Alex Kost <alezost@gmail.com> wrote:

> It would be good if you write a comment before licenses, like what files
> have what licenses.  Also is it really 'gpl2'?  If the license says "or
> any later version", it should be 'gpl2+'.

They are:

./compr.c: "  * JFFS2 -- Journalling Flash File System, Version 2.  *  * Copyright  ( C )  2004 Ferenc Havasi <havasi@inf.u-szeged.hu>,  *                    University of Szeged, Hungary  *  * For licensing information, see the file 'LICENCE' in this directory  * in the jffs2 directory.  "
./compr.h: "  * JFFS2 -- Journalling Flash File System, Version 2.  *  * Copyright  ( C )  2004 Ferenc Havasi <havasi@inf.u-szeged.hu>,  *                    University of Szeged, Hungary  *  * For licensing information, see the file 'LICENCE' in the  * jffs2 directory.  "
./compr_rtime.c: '  * JFFS2 -- Journalling Flash File System, Version 2.  *  * Copyright  ( C )  2001-2003 Red Hat, Inc.  *  * Created by Arjan van de Ven <arjanv@redhat.com>  *  * For licensing information, see the file \'LICENCE\' in this directory.  *  '
./flashcp.c: '  * Copyright  ( c )  2d3D, Inc.  * Written by Abraham vd Merwe <abraham@2d3d.co.za>  * All rights reserved.  *  * Renamed to flashcp.c to avoid conflicts with fcp from fsh package  *  * Redistribution and use in source and binary forms, with or without  * modification, are permitted provided that the following conditions  * are met:  * 1. Redistributions of source code must retain the above copyright  *\t  notice, this list of conditions and the following disclaimer.  * 2. Redistributions in binary form must reproduce the above copyright  *\t  notice, this list of conditions and the following disclaimer in the  *\t  documentation and/or other materials provided with the distribution.  * 3. Neither the name of the author nor the names of other contributors  *\t  may be used t
 o endorse or promote products derived from this software  *\t  without specific prior written permission.  *  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"  * AND ANY
  EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,  * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE  * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE  * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL  * DAMAGES  ( INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR  * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION )  HOWEVER  * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,  * OR TORT  ( INCLUDING NEGLIGENCE OR OTHERWISE )  ARISING IN ANY WAY OUT OF THE USE  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.  '
./ftl_check.c: ' Ported to MTD system.  * Based on:  ======================================================================    Utility to create an FTL partition in a memory region    ftl_check.c 1.10 1999/10/25 20:01:35    The contents of this file are subject to the Mozilla Public   License Version 1.1  ( the "License" ) ; you may not use this file   except in compliance with the License. You may obtain a copy of   the License at http://www.mozilla.org/MPL/    Software distributed under the License is distributed on an "AS   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or   implied. See the License for the specific language governing   rights and limitations under the License.    The initial developer of the original code is David A. Hinds   <dhinds@pcmcia.sourceforge.org>.  P
 ortions created by David A. Hinds   are Copyright  ( C )  1999 David A. Hinds.  All Rights Reserved.    Alternatively, the contents of this file may be used under the   terms of the GNU Public Licen
 se version 2  ( the "GPL" ) , in which   case the provisions of the GPL are applicable instead of the   above.  If you wish to allow the use of your version of this file   only under the terms of the GPL and not to allow others to use   your version of this file under the MPL, indicate your decision   by deleting the provisions above and replace them with the notice   and other provisions required by the GPL.  If you do not delete   the provisions above, a recipient may use your version of this   file under either the MPL or the GPL.    ======================================================================'
./ftl_format.c: ' Ported to MTD system.  * Based on:  ======================================================================    Utility to create an FTL partition in a memory region    ftl_format.c 1.13 1999/10/25 20:01:35    The contents of this file are subject to the Mozilla Public   License Version 1.1  ( the "License" ) ; you may not use this file   except in compliance with the License. You may obtain a copy of   the License at http://www.mozilla.org/MPL/    Software distributed under the License is distributed on an "AS   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or   implied. See the License for the specific language governing   rights and limitations under the License.    The initial developer of the original code is David A. Hinds   <dhinds@pcmcia.sourceforge.org>. 
  Portions created by David A. Hinds   are Copyright  ( C )  1999 David A. Hinds.  All Rights Reserved.    Alternatively, the contents of this file may be used under the   terms of the GNU Public Lic
 ense version 2  ( the "GPL" ) , in which   case the provisions of the GPL are applicable instead of the   above.  If you wish to allow the use of your version of this file   only under the terms of the GPL and not to allow others to use   your version of this file under the MPL, indicate your decision   by deleting the provisions above and replace them with the notice   and other provisions required by the GPL.  If you do not delete   the provisions above, a recipient may use your version of this   file under either the MPL or the GPL.    ======================================================================'
./include/linux/jffs2.h: "  * JFFS2 -- Journalling Flash File System, Version 2.  *  * Copyright  ( C )  2001-2003 Red Hat, Inc.  *  * Created by David Woodhouse <dwmw2@infradead.org>  *  * For licensing information, see the file 'LICENCE' in the  * jffs2 directory.  *  * $Id: jffs2.h,v 1.38 2005/09/26 11:37:23 havasi Exp $  *  "
./jffs2reader.c: IS COPYRIGHT HEADER b" vi: set sw=4 ts=4:   * jffs2reader v0.0.18 A jffs2 image reader  *  * Copyright  ( c )  2001 Jari Kirma <Jari.Kirma@hut.fi>  *  * This software is provided 'as-is', without any express or implied  * warranty. In no event will the author be held liable for any damages  * arising from the use of this software.  *  * Permission is granted to anyone to use this software for any  * purpose, including commercial applications, and to alter it and  * redistribute it freely, subject to the following restrictions:  *  * 1. The origin of this software must not be misrepresented; you must  * not claim that you wrote the original software. If you use this  * software in a product, an acknowledgment in the product  * documentation would be appreciated but is not r
 equired.  *  * 2. Altered source versions must be plainly marked as such, and must  * not be misrepresented as being the original software.  *  * 3. This notice may not be removed or altered from an
 y source  * distribution.  *  *  *********  *  This code was altered September 2001  *  Changes are Copyright  ( c )  Erik Andersen <andersen@codepoet.org>  *  * In compliance with  ( 2 )  above, this is hereby marked as an altered  * version of this software.  It has been altered as follows:  *      * )  Listing a directory now mimics the behavior of 'ls -l'  *      * )  Support for recursive listing has been added  *      * )  Without options, does a recursive 'ls' on the whole filesystem  *      * )  option parsing now uses getopt (  )   *      * )  Now uses printf, and error messages go to stderr.  *      * )  The copyright notice has been cleaned up and reformatted  *      * )  The code has been reformatted  *      * )  Several twisty code paths have been fixed so I can understand th
 em.  *  -Erik, 1 September 2001  *  *      * )  Made it show major/minor numbers for device nodes  *      * )  Made it show symlink targets  *  -Erik, 13 September 2001   TODO:  - Add CRC checking c
 ode to places marked with XXX. - Add support for other node compression types.  - Test with real life images. - Maybe port into bootloader.   BUGS:  - Doesn't check CRC checksums.  "
./mkfs.ubifs/crc16.h: '  * Implements the standard CRC-16:  *   Width 16  *   Poly  0x8005  ( x^16 + x^15 + x^2 + 1 )   *   Init  0  *  * Copyright  ( c )  2005 Ben Gardner <bgardner@wabtec.com>  *  * This code was taken from the linux kernel. The license is GPL Version 2.  '
./mkfs.ubifs/hashtable/hashtable.c: ' Copyright  ( C )  2004 Christopher Clark <firstname.lastname@cl.cam.ac.uk> '
./mkfs.ubifs/hashtable/hashtable.h: ' Copyright  ( C )  2002 Christopher Clark <firstname.lastname@cl.cam.ac.uk> '
./mkfs.ubifs/hashtable/hashtable_itr.c: ' Copyright  ( C )  2002, 2004 Christopher Clark  <firstname.lastname@cl.cam.ac.uk> '
./mkfs.ubifs/hashtable/hashtable_itr.h: ' Copyright  ( C )  2002, 2004 Christopher Clark <firstname.lastname@cl.cam.ac.uk> '
./mkfs.ubifs/hashtable/hashtable_private.h: ' Copyright  ( C )  2002, 2004 Christopher Clark <firstname.lastname@cl.cam.ac.uk> '
./mtd_debug.c: '  * Copyright  ( c )  2d3D, Inc.  * Written by Abraham vd Merwe <abraham@2d3d.co.za>  * All rights reserved.  *  * Redistribution and use in source and binary forms, with or without  * modification, are permitted provided that the following conditions  * are met:  * 1. Redistributions of source code must retain the above copyright  *\t  notice, this list of conditions and the following disclaimer.  * 2. Redistributions in binary form must reproduce the above copyright  *\t  notice, this list of conditions and the following disclaimer in the  *\t  documentation and/or other materials provided with the distribution.  * 3. Neither the name of the author nor the names of other contributors  *\t  may be used to endorse or promote products derived from this software  *\t  without
  specific prior written permission.  *  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"  * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,  * THE 
 IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE  * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE  * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL  * DAMAGES  ( INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR  * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION )  HOWEVER  * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,  * OR TORT  ( INCLUDING NEGLIGENCE OR OTHERWISE )  ARISING IN ANY WAY OUT OF THE USE  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.  '
./summary.h: IS COPYRIGHT HEADER b"  * JFFS2 -- Journalling Flash File System, Version 2.  *  * Copyright  ( C )  2004  Ferenc Havasi <havasi@inf.u-szeged.hu>,  *                     Zoltan Sogor <weth@inf.u-szeged.hu>,  *                     Patrik Kluba <pajko@halom.u-szeged.hu>,  *                     University of Szeged, Hungary  *  * For licensing information, see the file 'LICENCE' in this directory.  "
./tests/checkfs/checkfs.c: '   * Copyright Daniel Industries.  *  * Created by: Vipin Malik  ( vipin.malik@daniel.com )   *  * This code is released under the GPL version 2. See the file COPYING  * for more details.  *  * Software distributed under the Licence is distributed on an "AS IS"  * basis, WITHOUT WARRANTY OF ANY KIND, either express or implied.  * See the Licence for the specific language governing rights and  * limitations under the Licence. '
./tests/checkfs/makefiles.c: '   * Copyright Daniel Industries.   * Created by: Vipin Malik  ( vipin.malik@daniel.com )   *  * This is GPL code. See the file COPYING for more details  *  * Software distributed under the Licence is distributed on an "AS IS"  * basis, WITHOUT WARRANTY OF ANY KIND, either express or implied.  * See the Licence for the specific language governing rights and  * limitations under the Licence.'

GPL2-only parts (which constitute the vast majority) were omitted.

I'd say the entire thing can only be distributed under GPLv2. What do you think?

Re: [PATCH] gnu: Add mtd-utils.

[Alex Kost]

Danny Milosavljevic (2016-08-30 11:39 +0300) wrote:

> On Tue, 30 Aug 2016 11:08:17 +0300
> Alex Kost <alezost@gmail.com> wrote:
>
>> It would be good if you write a comment before licenses, like what files
>> have what licenses.  Also is it really 'gpl2'?  If the license says "or
>> any later version", it should be 'gpl2+'.
>
> They are:
>
> ./compr.c: "  * JFFS2 -- Journalling Flash File System, Version 2.  *  * Copyright  ( C )  2004 Ferenc Havasi <havasi@inf.u-szeged.hu>,  *                    University of Szeged, Hungary  *  * For licensing information, see the file 'LICENCE' in this directory  * in the jffs2 directory.  "
> ./compr.h: "  * JFFS2 -- Journalling Flash File System, Version 2.  *  * Copyright  ( C )  2004 Ferenc Havasi <havasi@inf.u-szeged.hu>,  *                    University of Szeged, Hungary  *  * For licensing information, see the file 'LICENCE' in the  * jffs2 directory.  "
> ./compr_rtime.c: '  * JFFS2 -- Journalling Flash File System, Version 2.  *  * Copyright  ( C )  2001-2003 Red Hat, Inc.  *  * Created by Arjan van de Ven <arjanv@redhat.com>  *  * For licensing information, see the file \'LICENCE\' in this directory.  *  '
> ./flashcp.c: '  * Copyright  ( c )  2d3D, Inc.  * Written by Abraham vd Merwe <abraham@2d3d.co.za>  * All rights reserved.  *  * Renamed to flashcp.c to avoid conflicts with fcp from fsh package  *  * Redistribution and use in source and binary forms, with or without  * modification, are permitted provided that the following conditions  * are met:  * 1. Redistributions of source code must retain the above copyright  *\t  notice, this list of conditions and the following disclaimer.  * 2. Redistributions in binary form must reproduce the above copyright  *\t  notice, this list of conditions and the following disclaimer in the  *\t  documentation and/or other materials provided with the distribution.  * 3. Neither the name of the author nor the names of other contributors  *\t  may be used
  t
>  o endorse or promote products derived from this software  *\t  without specific prior written permission.  *  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"  * AND ANY
>   EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,  * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE  * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE  * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL  * DAMAGES  ( INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR  * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION )  HOWEVER  * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,  * OR TORT  ( INCLUDING NEGLIGENCE OR OTHERWISE )  ARISING IN ANY WAY OUT OF THE USE  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.  '
> ./ftl_check.c: ' Ported to MTD system.  * Based on:  ======================================================================    Utility to create an FTL partition in a memory region    ftl_check.c 1.10 1999/10/25 20:01:35    The contents of this file are subject to the Mozilla Public   License Version 1.1  ( the "License" ) ; you may not use this file   except in compliance with the License. You may obtain a copy of   the License at http://www.mozilla.org/MPL/    Software distributed under the License is distributed on an "AS   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or   implied. See the License for the specific language governing   rights and limitations under the License.    The initial developer of the original code is David A. Hinds   <dhinds@pcmcia.sourceforge.org>. 
  P
>  ortions created by David A. Hinds   are Copyright  ( C )  1999 David A. Hinds.  All Rights Reserved.    Alternatively, the contents of this file may be used under the   terms of the GNU Public Licen
>  se version 2  ( the "GPL" ) , in which   case the provisions of the GPL are applicable instead of the   above.  If you wish to allow the use of your version of this file   only under the terms of the GPL and not to allow others to use   your version of this file under the MPL, indicate your decision   by deleting the provisions above and replace them with the notice   and other provisions required by the GPL.  If you do not delete   the provisions above, a recipient may use your version of this   file under either the MPL or the GPL.    ======================================================================'
> ./ftl_format.c: ' Ported to MTD system.  * Based on:  ======================================================================    Utility to create an FTL partition in a memory region    ftl_format.c 1.13 1999/10/25 20:01:35    The contents of this file are subject to the Mozilla Public   License Version 1.1  ( the "License" ) ; you may not use this file   except in compliance with the License. You may obtain a copy of   the License at http://www.mozilla.org/MPL/    Software distributed under the License is distributed on an "AS   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or   implied. See the License for the specific language governing   rights and limitations under the License.    The initial developer of the original code is David A. Hinds   <dhinds@pcmcia.sourceforge.org>
 . 
>   Portions created by David A. Hinds   are Copyright  ( C )  1999 David A. Hinds.  All Rights Reserved.    Alternatively, the contents of this file may be used under the   terms of the GNU Public Lic
>  ense version 2  ( the "GPL" ) , in which   case the provisions of the GPL are applicable instead of the   above.  If you wish to allow the use of your version of this file   only under the terms of the GPL and not to allow others to use   your version of this file under the MPL, indicate your decision   by deleting the provisions above and replace them with the notice   and other provisions required by the GPL.  If you do not delete   the provisions above, a recipient may use your version of this   file under either the MPL or the GPL.    ======================================================================'
> ./include/linux/jffs2.h: "  * JFFS2 -- Journalling Flash File System, Version 2.  *  * Copyright  ( C )  2001-2003 Red Hat, Inc.  *  * Created by David Woodhouse <dwmw2@infradead.org>  *  * For licensing information, see the file 'LICENCE' in the  * jffs2 directory.  *  * $Id: jffs2.h,v 1.38 2005/09/26 11:37:23 havasi Exp $  *  "
> ./jffs2reader.c: IS COPYRIGHT HEADER b" vi: set sw=4 ts=4:   * jffs2reader v0.0.18 A jffs2 image reader  *  * Copyright  ( c )  2001 Jari Kirma <Jari.Kirma@hut.fi>  *  * This software is provided 'as-is', without any express or implied  * warranty. In no event will the author be held liable for any damages  * arising from the use of this software.  *  * Permission is granted to anyone to use this software for any  * purpose, including commercial applications, and to alter it and  * redistribute it freely, subject to the following restrictions:  *  * 1. The origin of this software must not be misrepresented; you must  * not claim that you wrote the original software. If you use this  * software in a product, an acknowledgment in the product  * documentation would be appreciated but is not
  r
>  equired.  *  * 2. Altered source versions must be plainly marked as such, and must  * not be misrepresented as being the original software.  *  * 3. This notice may not be removed or altered from an
>  y source  * distribution.  *  *  *********  *  This code was altered September 2001  *  Changes are Copyright  ( c )  Erik Andersen <andersen@codepoet.org>  *  * In compliance with  ( 2 )  above, this is hereby marked as an altered  * version of this software.  It has been altered as follows:  *      * )  Listing a directory now mimics the behavior of 'ls -l'  *      * )  Support for recursive listing has been added  *      * )  Without options, does a recursive 'ls' on the whole filesystem  *      * )  option parsing now uses getopt (  )   *      * )  Now uses printf, and error messages go to stderr.  *      * )  The copyright notice has been cleaned up and reformatted  *      * )  The code has been reformatted  *      * )  Several twisty code paths have been fixed so I can understand 
 th
>  em.  *  -Erik, 1 September 2001  *  *      * )  Made it show major/minor numbers for device nodes  *      * )  Made it show symlink targets  *  -Erik, 13 September 2001   TODO:  - Add CRC checking c
>  ode to places marked with XXX. - Add support for other node compression types.  - Test with real life images. - Maybe port into bootloader.   BUGS:  - Doesn't check CRC checksums.  "
> ./mkfs.ubifs/crc16.h: '  * Implements the standard CRC-16:  *   Width 16  *   Poly  0x8005  ( x^16 + x^15 + x^2 + 1 )   *   Init  0  *  * Copyright  ( c )  2005 Ben Gardner <bgardner@wabtec.com>  *  * This code was taken from the linux kernel. The license is GPL Version 2.  '
> ./mkfs.ubifs/hashtable/hashtable.c: ' Copyright  ( C )  2004 Christopher Clark <firstname.lastname@cl.cam.ac.uk> '
> ./mkfs.ubifs/hashtable/hashtable.h: ' Copyright  ( C )  2002 Christopher Clark <firstname.lastname@cl.cam.ac.uk> '
> ./mkfs.ubifs/hashtable/hashtable_itr.c: ' Copyright  ( C )  2002, 2004 Christopher Clark  <firstname.lastname@cl.cam.ac.uk> '
> ./mkfs.ubifs/hashtable/hashtable_itr.h: ' Copyright  ( C )  2002, 2004 Christopher Clark <firstname.lastname@cl.cam.ac.uk> '
> ./mkfs.ubifs/hashtable/hashtable_private.h: ' Copyright  ( C )  2002, 2004 Christopher Clark <firstname.lastname@cl.cam.ac.uk> '
> ./mtd_debug.c: '  * Copyright  ( c )  2d3D, Inc.  * Written by Abraham vd Merwe <abraham@2d3d.co.za>  * All rights reserved.  *  * Redistribution and use in source and binary forms, with or without  * modification, are permitted provided that the following conditions  * are met:  * 1. Redistributions of source code must retain the above copyright  *\t  notice, this list of conditions and the following disclaimer.  * 2. Redistributions in binary form must reproduce the above copyright  *\t  notice, this list of conditions and the following disclaimer in the  *\t  documentation and/or other materials provided with the distribution.  * 3. Neither the name of the author nor the names of other contributors  *\t  may be used to endorse or promote products derived from this software  *\t  witho
 ut
>   specific prior written permission.  *  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"  * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,  * THE 
>  IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE  * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE  * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL  * DAMAGES  ( INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR  * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION )  HOWEVER  * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,  * OR TORT  ( INCLUDING NEGLIGENCE OR OTHERWISE )  ARISING IN ANY WAY OUT OF THE USE  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.  '
> ./summary.h: IS COPYRIGHT HEADER b"  * JFFS2 -- Journalling Flash File System, Version 2.  *  * Copyright  ( C )  2004  Ferenc Havasi <havasi@inf.u-szeged.hu>,  *                     Zoltan Sogor <weth@inf.u-szeged.hu>,  *                     Patrik Kluba <pajko@halom.u-szeged.hu>,  *                     University of Szeged, Hungary  *  * For licensing information, see the file 'LICENCE' in this directory.  "
> ./tests/checkfs/checkfs.c: '   * Copyright Daniel Industries.  *  * Created by: Vipin Malik  ( vipin.malik@daniel.com )   *  * This code is released under the GPL version 2. See the file COPYING  * for more details.  *  * Software distributed under the Licence is distributed on an "AS IS"  * basis, WITHOUT WARRANTY OF ANY KIND, either express or implied.  * See the Licence for the specific language governing rights and  * limitations under the Licence. '
> ./tests/checkfs/makefiles.c: '   * Copyright Daniel Industries.   * Created by: Vipin Malik  ( vipin.malik@daniel.com )   *  * This is GPL code. See the file COPYING for more details  *  * Software distributed under the Licence is distributed on an "AS IS"  * basis, WITHOUT WARRANTY OF ANY KIND, either express or implied.  * See the Licence for the specific language governing rights and  * limitations under the Licence.'
>
> GPL2-only parts (which constitute the vast majority) were omitted.
>
> I'd say the entire thing can only be distributed under GPLv2. What do you think?

This question is too hard for me :-)

- Some of these files reference LICENSE/COPYING which is a usual "GNU
  GPLv2 or later" file.

- Some (for example, "docfdisk.c") have a usual license header with "or
  any later version".

- Some (for example, "compr_lzo.c") have a proper license header, but
  without "or any later".

So I would probably use both gpl2 and gpl2+, but I don't really know.

-- 
Alex

Re: [PATCH] gnu: Add mtd-utils.

[Ludovic Courtès]

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> On Tue, 30 Aug 2016 11:08:17 +0300
> Alex Kost <alezost@gmail.com> wrote:
>
>> It would be good if you write a comment before licenses, like what files
>> have what licenses.  Also is it really 'gpl2'?  If the license says "or
>> any later version", it should be 'gpl2+'.
>
> They are:

Based on
<http://metadata.ftp-master.debian.org/changelogs//main/m/mtd-utils/mtd-utils_1.5.2-1_copyright>,
the combined work seems to be GPLv2+.

> GPL2-only parts (which constitute the vast majority) were omitted.

Are there GPLv2 license headers that lack the “or any later version”
wording, or anything that explicitly says “version 2 only”?  If not,
it’s v2-or-later.

HTH,
Ludo’.

Re: [PATCH] gnu: Add mtd-utils.

[Danny Milosavljevic]

On Wed, 31 Aug 2016 22:59:11 +0200
ludo@gnu.org (Ludovic Courtès) wrote:

> Are there GPLv2 license headers that lack the “or any later version”
> wording, or anything that explicitly says “version 2 only”?  If not,
> it’s v2-or-later.

./ftl_format.c: ' Ported to MTD system.  * Based on:  ======================================================================    Utility to create an FTL partition in a memory region    ftl_format.c 1.13 1999/10/25 20:01:35    The contents of this file are subject to the Mozilla Public   License Version 1.1  ( the "License" ) ; you may not use this file   except in compliance with the License. You may obtain a copy of   the License at http://www.mozilla.org/MPL/    Software distributed under the License is distributed on an "AS   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or   implied. See the License for the specific language governing   rights and limitations under the License.    The initial developer of the original code is David A. Hinds   <dhinds@pcmcia.sourceforge.org>.  Portions created by David A. Hinds   are Copyright  ( C )  1999 David A. Hinds.  All Rights Reserved.    Alternatively, the contents of this file may be used under the   terms of the GNU Public Lic
 ense version 2  ( the "GPL" ) , in which   case the provisions of the GPL are applicable instead of the   above.  If you wish to allow the use of your version of this file   only under the terms of the GPL and not to allow others to use   your version of this file under the MPL, indicate your decision   by deleting the provisions above and replace them with the notice   and other provisions required by the GPL.  If you do not delete   the provisions above, a recipient may use your version of this   file under either the MPL or the GPL.    ======================================================================'

./mkfs.ubifs/crc16.h: '  * Implements the standard CRC-16:  *   Width 16  *   Poly  0x8005  ( x^16 + x^15 + x^2 + 1 )   *   Init  0  *  * Copyright  ( c )  2005 Ben Gardner <bgardner@wabtec.com>  *  * This code was taken from the linux kernel. The license is GPL Version 2.  '

Re: [PATCH] gnu: Add mtd-utils.

[Ludovic Courtès]

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> On Wed, 31 Aug 2016 22:59:11 +0200
> ludo@gnu.org (Ludovic Courtès) wrote:
>
>> Are there GPLv2 license headers that lack the “or any later version”
>> wording, or anything that explicitly says “version 2 only”?  If not,
>> it’s v2-or-later.

[...]

> ./mkfs.ubifs/crc16.h: '  * Implements the standard CRC-16:  *   Width 16  *   Poly  0x8005  ( x^16 + x^15 + x^2 + 1 )   *   Init  0  *  * Copyright  ( c )  2005 Ben Gardner <bgardner@wabtec.com>  *  * This code was taken from the linux kernel. The license is GPL Version 2.  '

OK, GPLv2-only!

Ludo'.

Re: [PATCH] gnu: Add mtd-utils.

[Alex Kost]

Ludovic Courtès (2016-09-01 15:13 +0300) wrote:

> Danny Milosavljevic <dannym@scratchpost.org> skribis:
>
>> On Wed, 31 Aug 2016 22:59:11 +0200
>> ludo@gnu.org (Ludovic Courtès) wrote:
>>
>>> Are there GPLv2 license headers that lack the “or any later version”
>>> wording, or anything that explicitly says “version 2 only”?  If not,
>>> it’s v2-or-later.
>
> [...]
>
>> ./mkfs.ubifs/crc16.h: ' * Implements the standard CRC-16: * Width 16 *
>> Poly 0x8005 ( x^16 + x^15 + x^2 + 1 ) * Init 0 * * Copyright ( c )
>> 2005 Ben Gardner <bgardner@wabtec.com> * * This code was taken from
>> the linux kernel. The license is GPL Version 2.  '
>
> OK, GPLv2-only!

Wait, why?  There are files that have a full license headers with "or
any later version", for example "docfdisk.c", "flash_erase.c" and
others.  That's why I thought both gpl2 and gpl2+ should be listed.

-- 
Alex

Re: [PATCH] gnu: Add mtd-utils.

[Alex Vong]

Alex Kost <alezost@gmail.com> writes:

> Ludovic Courtès (2016-09-01 15:13 +0300) wrote:
>
>> Danny Milosavljevic <dannym@scratchpost.org> skribis:
>>
>>> On Wed, 31 Aug 2016 22:59:11 +0200
>>> ludo@gnu.org (Ludovic Courtès) wrote:
>>>
>>>> Are there GPLv2 license headers that lack the “or any later version”
>>>> wording, or anything that explicitly says “version 2 only”?  If not,
>>>> it’s v2-or-later.
>>
>> [...]
>>
>>> ./mkfs.ubifs/crc16.h: ' * Implements the standard CRC-16: * Width 16 *
>>> Poly 0x8005 ( x^16 + x^15 + x^2 + 1 ) * Init 0 * * Copyright ( c )
>>> 2005 Ben Gardner <bgardner@wabtec.com> * * This code was taken from
>>> the linux kernel. The license is GPL Version 2.  '
>>
>> OK, GPLv2-only!
>
> Wait, why?  There are files that have a full license headers with "or
> any later version", for example "docfdisk.c", "flash_erase.c" and
> others.  That's why I thought both gpl2 and gpl2+ should be listed.

I think Ludovic is referring to this gpl compatibility matrix[0]. We
have to be careful thought, this only applies to under [AL]*GPL, but not
other license (unless explicitly allowed re-licensed under GPL,
e.g. MPL).

[0]: https://www.gnu.org/licenses/gpl-faq.en.html#AllCompatibility

Re: [PATCH] gnu: Add mtd-utils.

[Ludovic Courtès]

Alex Kost <alezost@gmail.com> skribis:

> Ludovic Courtès (2016-09-01 15:13 +0300) wrote:
>
>> Danny Milosavljevic <dannym@scratchpost.org> skribis:
>>
>>> On Wed, 31 Aug 2016 22:59:11 +0200
>>> ludo@gnu.org (Ludovic Courtès) wrote:
>>>
>>>> Are there GPLv2 license headers that lack the “or any later version”
>>>> wording, or anything that explicitly says “version 2 only”?  If not,
>>>> it’s v2-or-later.
>>
>> [...]
>>
>>> ./mkfs.ubifs/crc16.h: ' * Implements the standard CRC-16: * Width 16 *
>>> Poly 0x8005 ( x^16 + x^15 + x^2 + 1 ) * Init 0 * * Copyright ( c )
>>> 2005 Ben Gardner <bgardner@wabtec.com> * * This code was taken from
>>> the linux kernel. The license is GPL Version 2.  '
>>
>> OK, GPLv2-only!
>
> Wait, why?  There are files that have a full license headers with "or
> any later version", for example "docfdisk.c", "flash_erase.c" and
> others.  That's why I thought both gpl2 and gpl2+ should be listed.

But they are combined, so the combined work, which is what we (should)
care about, is ‘gpl2’.

At least that’s how I usually do it, but I agree that this is an
undocumented convention that’s probably not unanimously followed.

Ludo’.