From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Cl=C3=A9ment?= Lassieur <clement@lassieur.org>
Subject: Re: [PATCH] gnu: Add git-review.
Date: Fri, 09 Sep 2016 10:23:20 +0200
Message-ID: <87oa3xfpmv.fsf@lassieur.org>
References: <20160908070630.18458-1-clement@lassieur.org>
	<439770f1-4691-45ac-348e-9e41bc126e0d@uq.edu.au>
	<20160908183217.GK12493@macbook42.flashner.co.il>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53202)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <clement@lassieur.org>) id 1biH59-0002y8-SS
	for guix-devel@gnu.org; Fri, 09 Sep 2016 04:22:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <clement@lassieur.org>) id 1biH55-00080s-IX
	for guix-devel@gnu.org; Fri, 09 Sep 2016 04:22:42 -0400
Received: from mail.lassieur.org ([83.152.10.219]:35666)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <clement@lassieur.org>) id 1biH55-0007zs-BV
	for guix-devel@gnu.org; Fri, 09 Sep 2016 04:22:39 -0400
In-reply-to: <20160908183217.GK12493@macbook42.flashner.co.il>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org

Efraim Flashner <efraim@flashner.co.il> writes:

> On Thu, Sep 08, 2016 at 10:28:37PM +1000, Ben Woodcroft wrote:

>> I think including git simply as an input is problematic because git-re=
view
>> calls git via 'subprocess', as evidenced by
>>=20
>> $ ./pre-inst-env guix environment -C --ad-hoc git-review
>> $ git-review
>> [..]
>>   File "/gnu/store/m4gc2wx4q9if1vrhgclpspdil7rqsn21-python-3.4.3/lib/p=
ython3.4/subprocess.py",
>> line 1457, in _execute_child
>>     raise child_exception_type(errno_num, err_msg)
>> FileNotFoundError: [Errno 2] No such file or directory: 'git'
>>=20
>> So, I think we need to patch the source code to call the full path to =
git,
>> or otherwise wrap the 'git-review' executable.
>>=20
>> > +    (home-page "http://docs.openstack.org/infra/git-review/")
>> > +    (synopsis "Command-line tool for Gerrit")
>> > +    (description
>> > +     "Git-review is a command-line tool that helps submitting Git b=
ranches to
>> > +Gerrit for review, or fetching existing ones.")
>> > +    (license asl2.0)))
>> Otherwise seems OK to me. Can you test with environment -C -N?
>> ben
>>=20
>
> Try it with the attached patch

Hi, sorry for the mess and thanks for the reviews.

I did not know about the "guix environment -C -N" way of testing
packages, and I'm very happy to learn this.

The attached patch seems to work for git, but the same error now happens
with ssh.

--=20
Cl=C3=A9ment