Re: [PATCH] gnu: Add darkhttpd.

[Alex Kost <alezost@gmail.com>]

Arun Isaac (2016-09-10 12:21 +0530) wrote:

> * gnu/packages/web.scm (darkhttpd): New variable.
> ---
>  gnu/packages/web.scm | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
>
> diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
> index 20c7d12..287c389 100644
> --- a/gnu/packages/web.scm
> +++ b/gnu/packages/web.scm
> @@ -14,6 +14,7 @@
>  ;;; Copyright © 2016 Ben Woodcroft <donttrustben@gmail.com>
>  ;;; Copyright © 2016 Clément Lassieur <clement@lassieur.org>
>  ;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
> +;;; Copyright © 2016 Arun Isaac <arunisaac@systemreboot.net>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -3633,3 +3634,35 @@ provides a unix command line interface to a variety of popular www search engine
>  and similar services.")
>      (home-page "https://surfraw.alioth.debian.org/")
>      (license l:public-domain)))
> +
> +(define-public darkhttpd
> +  (package
> +    (name "darkhttpd")
> +    (version "1.12")
> +    (source
> +     (origin
> +       (method git-fetch)

Why 'git-fetch'?  There is a release tarball:

https://unix4lyfe.org/darkhttpd/darkhttpd-1.12.tar.bz2

> +       (uri (git-reference
> +             (url (string-append "https://unix4lyfe.org/git/darkhttpd"))
> +             (commit "master")))
> +       (sha256
> +        (base32
> +         "0wi8dfgj4ic0fsy4dszl69xgxdxlwxz4c30vsw2i2dpnczgjm04k"))
> +       (file-name (string-append name "-" version))))

I think (file-name (string-append name "-" version "-checkout")) is a
cleaner name for a git checkout directory (but using the tarball is
preferred).

> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:make-flags '("CC=gcc")
> +       #:tests? #f ; No test suite
> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure)
> +         (replace 'install
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (install-file "darkhttpd"
> +                           (string-append (assoc-ref outputs "out") "/bin")))))))

If a phase succeed, it should return non-false value, while the value of
'install-file' is unspecified.  In such cases we add #t to the end of
the phase.  BTW I would shorten that last line by moving "/bin" to the
next one.

> +    (synopsis "Simple static web server")
> +    (description "darkhttpd is a simple static web server.  It is
> +standalone and does not need inetd or ucspi-tcp.  It does not need any
> +config files---you only have to specify the www root.")
> +    (home-page "https://unix4lyfe.org/darkhttpd/")
> +    (license l:isc)))

-- 
Alex