From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add schismtracker.
Date: Sat, 10 Sep 2016 14:55:12 +0200
Message-ID: <87oa3voqxb.fsf@gnu.org>
References: <87r38sg1h6.fsf@openmailbox.org>
	<87poocqkc7.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44064)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bihoY-0003Oh-PK
	for guix-devel@gnu.org; Sat, 10 Sep 2016 08:55:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bihoT-0001Pg-C1
	for guix-devel@gnu.org; Sat, 10 Sep 2016 08:55:21 -0400
In-Reply-To: <87poocqkc7.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me>
	(Marius Bakke's message of "Sat, 10 Sep 2016 08:34:32 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org

Marius Bakke <mbakke@fastmail.com> skribis:

> Kei Kebreau <kei@openmailbox.org> writes:

[...]

>> +    (home-page "http://schismtracker.org")
>> +    (synopsis "Impulse Tracker clone")
>
> I think this should be more generic. The tagline from github works
> pretty well: "Oldschool sample-based music composition tool".

+1

> The rest LGTM. But! The package records build time in version.c. I
> managed to make it reproducible by adding a phase like this:
>
>           (add-before 'build 'make-reproducible
>             (lambda _
>               ;; Remove use of __DATE__ and __TIME__ for reproducibility.
>               (substitute* "schism/version.c"
>                 (("Schism Tracker built %s %s.*$")
>                  (string-append "Schism Tracker version " ,version "\");"=
)))
>               #t))

I would suggest making it a =E2=80=98snippet=E2=80=99 instead, as we usuall=
y do in such
cases.

Thanks Kei & Marius!

Ludo=E2=80=99.