From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kei Kebreau Subject: Re: [PATCH] gnu: lynx: Fix GnuTLS support. Date: Sun, 09 Oct 2016 16:16:44 -0400 Message-ID: <87oa2tjn0z.fsf@openmailbox.org> References: <87oa2x3rxc.fsf@openmailbox.org> <20161007012854.GB6335@jasmine> <877f9k8bkx.fsf@openmailbox.org> <20161008214708.GA27027@jasmine> <87shs5jtkx.fsf@openmailbox.org> <20161009192019.GB3025@jasmine> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btKWv-0004ed-Ks for guix-devel@gnu.org; Sun, 09 Oct 2016 16:17:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btKWs-0004bn-8j for guix-devel@gnu.org; Sun, 09 Oct 2016 16:17:05 -0400 Received: from mail.openmailbox.org ([62.4.1.34]:51075) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btKWr-0004bU-R1 for guix-devel@gnu.org; Sun, 09 Oct 2016 16:17:02 -0400 In-Reply-To: <20161009192019.GB3025@jasmine> (Leo Famulari's message of "Sun, 9 Oct 2016 15:20:19 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Famulari writes: > On Sun, Oct 09, 2016 at 01:55:10PM -0400, Kei Kebreau wrote: >> Leo Famulari writes: >>=20 >> > On Fri, Oct 07, 2016 at 10:42:38AM -0400, Kei Kebreau wrote: >> >> I get the same problem here. Lynx does mention that GnuTLS support is >> >> experimental. Your and Tobias' page work using OpenSSL instead. Try t= he >> >> new patch attached. >> > >> >> From ee3a889e6902686de4d7c949afcb8cd4a810bd0f Mon Sep 17 00:00:00 2001 >> >> From: Kei Kebreau >> >> Date: Fri, 7 Oct 2016 10:36:11 -0400 >> >> Subject: [PATCH] gnu: lynx: Support HTTPS (SSL) connections >> >>=20 >> >> * gnu/packages/lynx.scm (lynx)[inputs]: Add 'openssl' and remove 'gnu= tls'. >> >> [arguments]: Add configure flags for OpenSSL support; remove >> >> configure flags >> >> for GnuTLS support. >> > >> > Thanks, this works for me. >> > >> > I think it's fine to use the "dev" releases with GnuTLS too. Debian and >> > Fedora both use them. >>=20 >> I can confirm that lynx 2.8.9dev.9 works properly with GnuTLS. Should we >> use the current stable release with OpenSSL or the development release >> with GnuTLS? And if we use the development release, should I submit the >> patches as a single version bump with the necessary small adjustments? > > I would do it all in one: update to 2.8.9dev.9 and correct the configure > flags so it works correctly. I think that "update" and "make the updated > version work correctly" belong in the same commit since one change > doesn't make sense without the other. Alright. Does this commit message look good to you? --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename=0001-gnu-lynx-Update-to-2.8.9dev.9-and-fix-GnuTLS-support.patch Content-Transfer-Encoding: quoted-printable From=20c08ba395fe1c1df29d8509350ee287c0832a1970 Mon Sep 17 00:00:00 2001 From: Kei Kebreau Date: Sun, 9 Oct 2016 16:10:09 -0400 Subject: [PATCH] gnu: lynx: Update to 2.8.9dev.9 and fix GnuTLS support. * gnu/packages/lynx.scm (lynx): Update to 2.8.9dev.9. [arguments]: Append the path to the GnuTLS to "--with-gnutls=3D". =2D-- gnu/packages/lynx.scm | 34 +++++++++++++++++++--------------- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/gnu/packages/lynx.scm b/gnu/packages/lynx.scm index 3182b3e..6e4ed6c 100644 =2D-- a/gnu/packages/lynx.scm +++ b/gnu/packages/lynx.scm @@ -1,5 +1,6 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright =C2=A9 2014 Mark H Weaver +;;; Copyright =C2=A9 2016 Kei Kebreau ;;; ;;; This file is part of GNU Guix. ;;; @@ -33,14 +34,15 @@ (define-public lynx (package (name "lynx") =2D (version "2.8.8rel.2") + (version "2.8.9dev.9") (source (origin (method url-fetch) (uri (string-append "http://invisible-mirror.net/archives/lynx/tarballs" "/lynx" version ".tar.bz2")) (sha256 =2D (base32 "1rxysl08acqll5b87368f04kckl8sggy1qhnq59gsxyny1ff= g039")))) + (base32 + "1m72ga89hywm097kazcm8w6sqrfjnl83gh31pkbhk4zhzhfpzxgh")))) (build-system gnu-build-system) (native-inputs `(("pkg-config" ,pkg-config) ("perl" ,perl))) @@ -53,19 +55,21 @@ ("gzip" ,gzip) ("bzip2" ,bzip2))) (arguments =2D `(#:configure-flags '("--with-pkg-config" =2D "--with-screen=3Dncurses" =2D "--with-zlib" =2D "--with-bzlib" =2D "--with-gnutls" =2D ;; "--with-socks5" ; XXX TODO =2D "--enable-widec" =2D "--enable-ascii-ctypes" =2D "--enable-local-docs" =2D "--enable-htmlized-cfg" =2D "--enable-gzip-help" =2D "--enable-nls" =2D "--enable-ipv6") + `(#:configure-flags + (let ((gnutls (assoc-ref %build-inputs "gnutls"))) + `("--with-pkg-config" + "--with-screen=3Dncurses" + "--with-zlib" + "--with-bzlib" + ,(string-append "--with-gnutls=3D" gnutls) + ;; "--with-socks5" ; XXX TODO + "--enable-widec" + "--enable-ascii-ctypes" + "--enable-local-docs" + "--enable-htmlized-cfg" + "--enable-gzip-help" + "--enable-nls" + "--enable-ipv6")) #:tests? #f ; no check target #:phases (alist-replace 'install =2D-=20 2.10.0 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX+qWsAAoJEOal7jwZRnoN+44P/iJ0XkaY8V1aG2hVXtLb/toY tubgWO3nCthP2TlRAfofNZ0OG52mCsyohO2mQUFuVyS9vIMYHuHBWPK0oqK/swoS ByQfvV+HCTP+wg8YzvymifSpFtM33MlWsxbk+xe8uDIYVre9T2tnEatEJo4RslFR ZnjLcuLSeoA20OW8dVC8Y131kYCK0Qswxs/RnISQoXEfAuoklCx/z0XELJqGNnqq Vua9Q7qvRoOKDR/BhoC2Gsyj68W/WKv/B8ccCJotK6KuhJIAeJ391HWrDmH9ySWK 9EMqAIF9gltxc/p9+aFT8pv4x7BBaceBFFwOCZHZHMXZz2DAfpjKgyjYeTd6uwsJ SwoMLLV8weILW6R+PB3rsn/clUfpYk5d+qWy45mqWi+xIv2ZOcv6sSNTOc25i5i8 iZxiwBBDm6vpeE6qotlUplN7VpdiYkNZ09UE0HSRDMMk+Cp2ftxbSjvm50vODISp 5ICx9Zc80wYox/TzNZS+D8BU9Ch48O0DT/hROLPIBvuQJv1Co3FG3uhYkO1NFTJG IXzzS/N5eL8s6pvelZsr/Ivan5SXS2ljdBX7MYZwhd1EQ/JtiyU8C+ZneQnHKgg1 +7iYMLfC7H3iWEHbgGOzDCHfTSMNUbXKfz4vtFO+LxLAZe1p0AM/3Ck2eeyDd0lv ESS1Z0Gf6CsM6pLVr/Gw =UfIV -----END PGP SIGNATURE----- --==-=-=--