From: Kei Kebreau <kei@openmailbox.org>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: lynx: Fix GnuTLS support.
Date: Sun, 09 Oct 2016 16:16:44 -0400 [thread overview]
Message-ID: <87oa2tjn0z.fsf@openmailbox.org> (raw)
In-Reply-To: <20161009192019.GB3025@jasmine> (Leo Famulari's message of "Sun, 9 Oct 2016 15:20:19 -0400")
[-- Attachment #1.1: Type: text/plain, Size: 1638 bytes --]
Leo Famulari <leo@famulari.name> writes:
> On Sun, Oct 09, 2016 at 01:55:10PM -0400, Kei Kebreau wrote:
>> Leo Famulari <leo@famulari.name> writes:
>>
>> > On Fri, Oct 07, 2016 at 10:42:38AM -0400, Kei Kebreau wrote:
>> >> I get the same problem here. Lynx does mention that GnuTLS support is
>> >> experimental. Your and Tobias' page work using OpenSSL instead. Try the
>> >> new patch attached.
>> >
>> >> From ee3a889e6902686de4d7c949afcb8cd4a810bd0f Mon Sep 17 00:00:00 2001
>> >> From: Kei Kebreau <kei@openmailbox.org>
>> >> Date: Fri, 7 Oct 2016 10:36:11 -0400
>> >> Subject: [PATCH] gnu: lynx: Support HTTPS (SSL) connections
>> >>
>> >> * gnu/packages/lynx.scm (lynx)[inputs]: Add 'openssl' and remove 'gnutls'.
>> >> [arguments]: Add configure flags for OpenSSL support; remove
>> >> configure flags
>> >> for GnuTLS support.
>> >
>> > Thanks, this works for me.
>> >
>> > I think it's fine to use the "dev" releases with GnuTLS too. Debian and
>> > Fedora both use them.
>>
>> I can confirm that lynx 2.8.9dev.9 works properly with GnuTLS. Should we
>> use the current stable release with OpenSSL or the development release
>> with GnuTLS? And if we use the development release, should I submit the
>> patches as a single version bump with the necessary small adjustments?
>
> I would do it all in one: update to 2.8.9dev.9 and correct the configure
> flags so it works correctly. I think that "update" and "make the updated
> version work correctly" belong in the same commit since one change
> doesn't make sense without the other.
Alright. Does this commit message look good to you?
[-- Attachment #1.2: 0001-gnu-lynx-Update-to-2.8.9dev.9-and-fix-GnuTLS-support.patch --]
[-- Type: text/plain, Size: 2949 bytes --]
From c08ba395fe1c1df29d8509350ee287c0832a1970 Mon Sep 17 00:00:00 2001
From: Kei Kebreau <kei@openmailbox.org>
Date: Sun, 9 Oct 2016 16:10:09 -0400
Subject: [PATCH] gnu: lynx: Update to 2.8.9dev.9 and fix GnuTLS support.
* gnu/packages/lynx.scm (lynx): Update to 2.8.9dev.9.
[arguments]: Append the path to the GnuTLS to "--with-gnutls=".
---
gnu/packages/lynx.scm | 34 +++++++++++++++++++---------------
1 file changed, 19 insertions(+), 15 deletions(-)
diff --git a/gnu/packages/lynx.scm b/gnu/packages/lynx.scm
index 3182b3e..6e4ed6c 100644
--- a/gnu/packages/lynx.scm
+++ b/gnu/packages/lynx.scm
@@ -1,5 +1,6 @@
;;; GNU Guix --- Functional package management for GNU
;;; Copyright © 2014 Mark H Weaver <mhw@netris.org>
+;;; Copyright © 2016 Kei Kebreau <kei@openmailbox.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -33,14 +34,15 @@
(define-public lynx
(package
(name "lynx")
- (version "2.8.8rel.2")
+ (version "2.8.9dev.9")
(source (origin
(method url-fetch)
(uri (string-append
"http://invisible-mirror.net/archives/lynx/tarballs"
"/lynx" version ".tar.bz2"))
(sha256
- (base32 "1rxysl08acqll5b87368f04kckl8sggy1qhnq59gsxyny1ffg039"))))
+ (base32
+ "1m72ga89hywm097kazcm8w6sqrfjnl83gh31pkbhk4zhzhfpzxgh"))))
(build-system gnu-build-system)
(native-inputs `(("pkg-config" ,pkg-config)
("perl" ,perl)))
@@ -53,19 +55,21 @@
("gzip" ,gzip)
("bzip2" ,bzip2)))
(arguments
- `(#:configure-flags '("--with-pkg-config"
- "--with-screen=ncurses"
- "--with-zlib"
- "--with-bzlib"
- "--with-gnutls"
- ;; "--with-socks5" ; XXX TODO
- "--enable-widec"
- "--enable-ascii-ctypes"
- "--enable-local-docs"
- "--enable-htmlized-cfg"
- "--enable-gzip-help"
- "--enable-nls"
- "--enable-ipv6")
+ `(#:configure-flags
+ (let ((gnutls (assoc-ref %build-inputs "gnutls")))
+ `("--with-pkg-config"
+ "--with-screen=ncurses"
+ "--with-zlib"
+ "--with-bzlib"
+ ,(string-append "--with-gnutls=" gnutls)
+ ;; "--with-socks5" ; XXX TODO
+ "--enable-widec"
+ "--enable-ascii-ctypes"
+ "--enable-local-docs"
+ "--enable-htmlized-cfg"
+ "--enable-gzip-help"
+ "--enable-nls"
+ "--enable-ipv6"))
#:tests? #f ; no check target
#:phases (alist-replace
'install
--
2.10.0
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2016-10-09 20:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 0:48 [PATCH] gnu: lynx: Fix GnuTLS support Kei Kebreau
2016-10-07 1:28 ` Leo Famulari
2016-10-07 1:56 ` Tobias Geerinckx-Rice
2016-10-07 2:02 ` Tobias Geerinckx-Rice
2016-10-07 6:27 ` ng0
2016-10-07 14:42 ` Kei Kebreau
2016-10-08 13:58 ` ng0
2016-10-08 16:22 ` Kei Kebreau
2016-10-08 21:47 ` Leo Famulari
2016-10-09 17:55 ` Kei Kebreau
2016-10-09 19:20 ` Leo Famulari
2016-10-09 20:16 ` Kei Kebreau [this message]
2016-10-09 20:36 ` Leo Famulari
2016-10-09 21:00 ` Kei Kebreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oa2tjn0z.fsf@openmailbox.org \
--to=kei@openmailbox.org \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.