From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add supertuxkart.
Date: Tue, 18 Oct 2016 14:44:29 +0200
Message-ID: <87oa2hltci.fsf@gnu.org>
References: <20161017213754.8462-1-rekado@elephly.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44428)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bwTkx-00012U-4r
	for guix-devel@gnu.org; Tue, 18 Oct 2016 08:44:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bwTku-0001ca-20
	for guix-devel@gnu.org; Tue, 18 Oct 2016 08:44:35 -0400
In-Reply-To: <20161017213754.8462-1-rekado@elephly.net> (Ricardo Wurmus's
	message of "Mon, 17 Oct 2016 23:37:54 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org

Ricardo Wurmus <rekado@elephly.net> skribis:

> * gnu/packages/games.scm (supertuxkart): New variable.

Woohoo!

> +       (snippet
> +        ;; Delete bundled library sources
> +        '(begin
> +           ;; FIXME: try to unbundle enet, and angelscript
> +           (for-each delete-file-recursively
> +                     '("lib/zlib"
> +                       "lib/libpng"
> +                       "lib/jpeglib"
> +                       "lib/glew"
> +                       "lib/wiiuse"))
> +           #t))))

[...]

> +             (substitute* "CMakeLists.txt"
> +               ;; Supertuxkart uses modified versions of the Irrlicht en=
gine
> +               ;; and the bullet library.  The developers gave an explan=
ation here:
> +               ;; http://forum.freegamedev.net/viewtopic.php?f=3D17&t=3D=
3906
> +               (("add_subdirectory\\(.*/(glew|zlib)\"\\)") "")

I think this clause should go to the snippet above.

Otherwise LGTM, thanks!

Ludo=E2=80=99.