From mboxrd@z Thu Jan 1 00:00:00 1970 From: Theodoros Foradis Subject: Re: [PATCH v2 3/3] gnu: Add python2-wxpython. Date: Tue, 25 Oct 2016 20:13:55 +0300 Message-ID: <87oa28tkq4.fsf@openmailbox.org> References: <20161025124841.GA887@jasmine> <20161025160907.30181-1-theodoros.for@openmailbox.org> <20161025160907.30181-4-theodoros.for@openmailbox.org> <20161025163524.GB3404@jasmine> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33895) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bz5Lq-0005ky-S1 for guix-devel@gnu.org; Tue, 25 Oct 2016 13:17:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bz5Lo-0004yI-6k for guix-devel@gnu.org; Tue, 25 Oct 2016 13:17:26 -0400 Received: from smtp6.openmailbox.org ([62.4.1.40]:33187) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bz5Ln-0004xv-Ub for guix-devel@gnu.org; Tue, 25 Oct 2016 13:17:24 -0400 In-reply-to: <20161025163524.GB3404@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel Leo Famulari writes: > On Tue, Oct 25, 2016 at 07:09:07PM +0300, Theodoros Foradis wrote: >> * gnu/packages/wxwidgets.scm (python2-wxpython): New variable. > >> + #:tests? #f ; tests fail > I'll try to give this one a second look. > We should try to fix this, or at least understand why they are failing. > >> + (native-inputs >> + `(("gtk+" ,gtk+-2) >> + ("expat" ,expat) >> + ("libjpeg" ,libjpeg) >> + ("libpng" ,libpng) >> + ("libtiff" ,libtiff) >> + ("libsm" ,libsm) >> + ("libx11" ,libx11) >> + ("mesa" ,mesa) >> + ("pkg-config" ,pkg-config) >> + ("python2-setuptools" ,python2-setuptools) >> + ("zlib" ,zlib))) > > To clarify, all these native-inputs are only used while building? > Native inputs typically are not intended to be available once the > package has been built and installed. To quote Danny Milosavljevic, whose original patch of python2-wxpython I modified: > I added gtk, opengl etc as native inputs instead of regular inputs because from the point of view of Python they are not direct inputs. I guess this applies to gtk+,opengl,mesa and expat(?) (the others are intented to be native-inputs for sure). I am unsure if they are intended to be available at runtime. I assumed they were not, based on the previous comment. If they, they should be moved to inputs. How could I figure that out? -- Theodoros Foradis