From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH 1/3] gnu: lua: Update to 5.3.3. Date: Mon, 31 Oct 2016 23:51:53 +0000 Message-ID: <87oa20uleu.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me> References: <20161031132944.2353-1-mbakke@fastmail.com> <20161031132944.2353-2-mbakke@fastmail.com> <20161031175534.GB27555@jasmine> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42529) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1MN1-0002CL-2r for guix-devel@gnu.org; Mon, 31 Oct 2016 19:52:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1MMw-0008L4-7x for guix-devel@gnu.org; Mon, 31 Oct 2016 19:52:03 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:43723) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c1MMw-0008KV-3P for guix-devel@gnu.org; Mon, 31 Oct 2016 19:51:58 -0400 In-Reply-To: <20161031175534.GB27555@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Famulari writes: > On Mon, Oct 31, 2016 at 01:29:42PM +0000, Marius Bakke wrote: >> * gnu/packages/lua.scm (lua): Update to 5.3.3. >> [source]: Use https URL. >> [home-page]: Use https URL. >> (lua-5.2): New variable. >> (lua-5.1)[source]: Use https URL. >> --- >> gnu/packages/lua.scm | 23 ++++++++++++++++++----- >> 1 file changed, 18 insertions(+), 5 deletions(-) >>=20 >> diff --git a/gnu/packages/lua.scm b/gnu/packages/lua.scm >> index 8fdba61..55e529e 100644 >> --- a/gnu/packages/lua.scm >> +++ b/gnu/packages/lua.scm >> @@ -40,13 +40,13 @@ >> (define-public lua >> (package >> (name "lua") >> - (version "5.2.4") >> + (version "5.3.3") >> (source (origin >> (method url-fetch) >> - (uri (string-append "http://www.lua.org/ftp/lua-" >> + (uri (string-append "https://www.lua.org/ftp/lua-" >> version ".tar.gz")) >> (sha256 >> - (base32 "0jwznq0l8qg9wh5grwg07b5cy3lzngvl5m2nl1ikp6vqssmf= 9qmr")) >> + (base32 "18mcfbbmjyp8f2l9yy7n6dzk066nq6man0kpwly4bppphilc= 04si")) >> (patches (search-patches "lua-pkgconfig.patch" >> "lua52-liblua-so.patch")))) > > Does this lua52-liblua-so.patch still apply / is it still needed for Lua > 5.3? I remember that there were significant differences between how Lua > 5.1 and 5.2 in terms of building a dynamic Lua library. > > If so, I guess we should rename it. I tried building 5.3 initially without patches and noticed the shared library was not created. It applies cleanly and works as advertised. Should I rename it to just lua-liblua-so.patch? IMO the version number is useful information, even if it applies for a later minor release. I'm in favor of keeping it, and create the lua54 equivalent if/when needed. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCgAGBQJYF9kZAAoJEKKgbfKjOlT66XQH/2gHo6/U04aY3H3UILwjkXVT oioBYwZj98iKWtFqgnX3EKOe/a2IINBRcBXD7qGPP6mSSickurbRfkHvSblfUtqq mQ8Nr7FNYl53RXjwK4hnVG/sG5feGXk3u1ncBcwMLzy8f04Ditwe/fWh9Ed9ipsd OAxS+n/yzxn4MR12S21ZVU44bb9+MU6SuRO30K2iUIdC5yXXX09mU1csMfUOlCjV a5sJq6pqGFM5wOex7eCK56KwOIWdv26YWy8LgEyIxQmHgL8QHCbu/vFenOCWeGQ4 zI4snuRrEBp7d+UzVK9BkXVu9JF3N0wTqGQ9tb+Q7qbgniaW9FtRz8NEg00u8yk= =vZk1 -----END PGP SIGNATURE----- --=-=-=--