Re: [PATCH v2] gnu: Add ghc-markdown-unlit.

[Marius Bakke <mbakke@fastmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2081 bytes --]

Danny Milosavljevic <dannym@scratchpost.org> writes:

> * gnu/packages/haskell.scm (ghc-markdown-unlit): New variable.
> ---
>  gnu/packages/haskell.scm | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index de061a630..1f6611d0b 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -8073,4 +8073,33 @@ It features a complete, well-tested parser and pretty printer for all of C99
>  and a large set of GNU extensions.")
>      (license license:bsd-3)))
>  
> +(define-public ghc-markdown-unlit
> +  (package
> +   (name "ghc-markdown-unlit")
> +   (version "0.4.0")
> +   (source (origin
> +     (method url-fetch)
> +     (uri (string-append
> +            "https://hackage.haskell.org/package/markdown-unlit/"
> +            "markdown-unlit-" version ".tar.gz"))
> +     (sha256
> +       (base32
> +         "1kj2bffl7ndd8ygwwa3r1mbpwbxbfhyfgnbla8k8g9i6ffp0qrbw"))))
> +   (build-system haskell-build-system)
> +   (inputs
> +    `(("ghc-base-compat" ,ghc-base-compat)
> +      ("ghc-hspec" ,ghc-hspec)
> +      ("ghc-quickcheck" ,ghc-quickcheck)
> +      ("ghc-silently" ,ghc-silently)
> +      ("ghc-stringbuilder" ,ghc-stringbuilder)
> +      ("ghc-temporary" ,ghc-temporary)))
> +   (native-inputs
> +    `(("hspec-discover" ,hspec-discover)))
> +   (home-page "https://github.com/sol/markdown-unlit#readme")
> +   (synopsis "Literate Haskell support for Markdown")
> +   (description "This package allows you to have a README.md that at the
> +same time is a literate Haskell program.  See also $url{Documentation,
> +https://github.com/sol/markdown-unlit#readme}.")

I don't think linking the home page in the description is necessary.
What do you think about removing the last sentence? Otherwise LGTM with
a few indentation changes that can be fixed before pushing ;-)

As a side note, do we have volunteers to make the hackage importer
return a "mirror://hackage" uri? IIRC this is needed for pypi too.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]