Re: [PATCH 3/3] gnu: Add filezilla.

[Maxim Cournoyer <maxim.cournoyer@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3179 bytes --]

Hi,

rennes <rennes@openmailbox.org> writes:

> * gnu/packages/ftp.scm (filezilla): New variable.
> ---
>  gnu/packages/ftp.scm | 48 +++++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 47 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/ftp.scm b/gnu/packages/ftp.scm
> index 0fef1b160..129f04ef6 100644
> --- a/gnu/packages/ftp.scm
> +++ b/gnu/packages/ftp.scm
> @@ -27,12 +27,20 @@
>    #:use-module (guix packages)
>    #:use-module (gnu packages)
>    #:use-module (gnu packages autotools)
> -  #:use-module (gnu packages check)  
> +  #:use-module (gnu packages glib)
> +  #:use-module (gnu packages gtk)

Minor thing, and I'm not sure if we have a convention for this, but it'd
be neat to keep the use-module statements ordered alphabetically.

> +  #:use-module (gnu packages check)
> +  #:use-module (gnu packages databases)
> +  #:use-module (gnu packages freedesktop)  
>    #:use-module (gnu packages gettext)
> +  #:use-module (gnu packages libidn)  
>    #:use-module (gnu packages ncurses)
> +  #:use-module (gnu packages nettle)  
>    #:use-module (gnu packages readline)
>    #:use-module (gnu packages pkg-config)
>    #:use-module (gnu packages tls)
> +  #:use-module (gnu packages wxwidgets)
> +  #:use-module (gnu packages xml)  
>    #:use-module (gnu packages compression))
>  
>  (define-public lftp
> @@ -183,3 +191,41 @@ as required.")
>       "This package offering some basic functionality to build high-performing,
>  platform-independent programs.")
>      (license gpl3+)))
> +
> +(define-public filezilla
> +  (package
> +    (name "filezilla")
> +    (version "3.24.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://sourceforge.net/projects/" name
> +                           "/files/FileZilla_Client/" version
> +                           "/FileZilla_" version "_src" ".tar.bz2"))
> +       (sha256
> +        (base32
> +         "1bacrl8lj90hqbh129hpbgqj78k1i84j83rkzn507jnykj4x8p9x"))))
> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("gettext" ,gettext-minimal)
> +       ("pkg-config" ,pkg-config)
> +       ("pugixml" ,pugixml)
> +       ("xdg-utils" ,xdg-utils)))
> +    (inputs
> +     `(("dbus" ,dbus)
> +       ("gnutls" ,gnutls)
> +       ("gtk+" ,gtk+)
> +       ("libfilezilla" ,libfilezilla)
> +       ("libidn" ,libidn)
> +       ("nettle" ,nettle)
> +       ("sqlite" ,sqlite)
> +       ("wxwidgets" ,wxwidgets)))
> +    (home-page "https://filezilla-project.org")
> +    (synopsis "Full-featured graphical FTP/FTPS/SFTP client")
> +    (description
> +     "Filezilla client supports FTP, FTP over SSL/TLS (FTPS),
> +SSH File Transfer Protocol (SFTP), HTTP/1.1, SOCKS5, FTP-Proxy, IPv6
> +and others features such as bookmarks, drag and drop, filename filters,
> +directory comparison and more.")
> +    (license gpl3+)

Again, I'm under the impression that this should rather be gpl2+. I'd be
happy to be proven wrong otherwise!

> +    (properties '((upstream-name . "FileZilla")))))

Otherwise LGTM (haven't tested though).

Maxim

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]